From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DcJ1GgjxgWJzfgYAWB0awg (envelope-from ) for ; Mon, 16 May 2022 02:36:56 -0400 Received: by simark.ca (Postfix, from userid 112) id 5F3541E220; Mon, 16 May 2022 02:36:56 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=S0E5FnLW; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 721E41E00D for ; Mon, 16 May 2022 02:36:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D0A6E385803D for ; Mon, 16 May 2022 06:36:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0A6E385803D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652683014; bh=7Utm7Fs4uCO1W/CrJhzqkS1zlHXdJ9M2vlu7Il4pRu4=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=S0E5FnLWrspuaWlmdVmuomx6PpQcNxA/QF7+wHIy1Kd744BTuP4oiYncf9gO+OMX3 gl66Px6ed3aZaZaBTiKzQoJSZeGvGTfyt826+5DhRhD36swWdFhYjTiQhOVZXkbVjE znFML3JRr7HMYbjH/OmwskDh2kjp1r+wVQ7NiM5E= Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2076.outbound.protection.outlook.com [40.107.223.76]) by sourceware.org (Postfix) with ESMTPS id AA9D63858C50 for ; Mon, 16 May 2022 06:36:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AA9D63858C50 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aGOhumjL05jio+UHj4NOHeXteBC/wu5pZvLBAQN18sO1bVR/3yPgtB2+n5c9c7mqdiY/CpYdxwUPjsK2DKObW4lKQIFn/imgpKUC83AX9UwQMtt+O5YbE6YT6IEYL3gfXqfb4ahH08MjOTABNQ2JaqctpNBsFWgphgnRWyGCaTkN/8wVXTudpleSbyRAfyALeHP6BSD++3hQ1a0vF94bDzdObVekomvgs5Civ9/vrBRzgCdFTqHf0hs44pONcYHTB8SqwvSuGNza2/MdIo78ENqw4HB/PtHiKrPMkjq4XPo97D7f3VPAXPielHquJMRo7rqIZqI4v/FQgAWouDznFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Utm7Fs4uCO1W/CrJhzqkS1zlHXdJ9M2vlu7Il4pRu4=; b=fywIvRoQ55H5f4MW3rbkGkiy6lOce7Asrmuh4cRMzBf2Ws8zD8joK6jicsQOTvEhxcYpb2kqc0/wB69mhjsEEoe3fg00M322+qAWc1g56PmsTEkx8BCjOOP6c8Gq+52uhRGXTdmNJN89zI+UZH5TE5zs9ytcg5C1QnCWC1YNOcjd69V9jZj0c7tTK1YRVY2Ep6ckJTaVa6nPc9+0QPzBT8GHsbpJJBkmMUZd0YqDHEjObORH4tLJ/WycF8TJT6jR0lRkkT+xJJySOJ8T4VwnXhQx8wSmezJCwe6DLGILpgVMuROkZI8XyGSPErsoE9D4v3BywPSzs99z8uWSYt1y2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BY5PR12MB4965.namprd12.prod.outlook.com (2603:10b6:a03:1c4::16) by MW3PR12MB4347.namprd12.prod.outlook.com (2603:10b6:303:2e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 06:36:31 +0000 Received: from BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::8126:6133:60e9:cc7c]) by BY5PR12MB4965.namprd12.prod.outlook.com ([fe80::8126:6133:60e9:cc7c%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 06:36:31 +0000 To: "Kempke, Nils-Christian" , "gdb-patches@sourceware.org" Subject: RE: [PATCH 18/18] gdb/testsuite: fixup common-block.exp for intel compilers Thread-Topic: [PATCH 18/18] gdb/testsuite: fixup common-block.exp for intel compilers Thread-Index: AQHYZHnk2iQVH6GDVkC6DQ9YcYSxba0ZrVSAgAAiIQCAB0GDMA== Date: Mon, 16 May 2022 06:36:31 +0000 Message-ID: References: <20220510142437.1397399-1-nils-christian.kempke@intel.com> <20220510142437.1397399-19-nils-christian.kempke@intel.com> <87wnesjiyu.fsf@redhat.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=4e107f94-c75f-4eff-afaf-92d02e14c27d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-05-16T06:20:07Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e4fabf3c-93f2-4b31-de47-08da370669d1 x-ms-traffictypediagnostic: MW3PR12MB4347:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LQrGPx4hKIYBat2o/6QToToKBI84rkdKbPB2Xc/RxRfGF6629gAQqrp3+lBDxQhUsGggXgQhd8b8+DhN1JCHj8FzETZLnZVIz5Bvhzmugg1nIup3gtpIwue90mP3G7cObcl66zW+70/2qOU08GbaaB19lTLgzOrMK/wwO7Sa8bp/5r1yel7jZrhnY2gOeIun/16IS9HDBL45+xRUoeYtHoHSDjXhAX4KmNHjLF7Boq/9JemeXlYX98rt7TtFTxZIx5wum/jOYGRg6xYwHuKgTfPqz9WhvfQza2ZfrCsNIUq9nHL/YyIfWhnbO5UFbeiZsv+FlHLWdjn9e6mC1sx0Kp58q19obc5SqeQ0shoHJBugdeIeeVzyL9bOCL515/4fGXA0Ls16zDpFih8vw89iBqN1ocms4AX6jnXOtGdHSjzM0oFp2AoFlXMGcXUfRl7AqiNPunQM/gZRwc3daaZPMJoKcbe7uzC6x/jpYjULx/4WBuLKhpUqZN9/0Kcan2SLnlbq6c1X6KBTof6Gh2HJqlwNpIop1UmQQS2eemgBe0USZnsMf4IIVVCXUHLOAv+qG9JhLWwRXw3Lrjj0JtlGD6samVLca6wvBvwX+zeiOcMtzKGnVhcyFw2sjqhZZle7ZKKWwpN3i2p7sZw604WvsBxn/DJ0ZwNg4oWp2wbepjJtPQUrspYG8avCRp2y/E2YdHWGSJGy3ZmnK7z8mQVg+9VoPVmDj9vRzwmtocuCelGtCfpV0O6qAhiGlfKg3p59DmJiAtkXSrY1ZymJhDT0EMrB/35XMpezg/5UZTUa634= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4965.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(8676002)(6506007)(5660300002)(52536014)(45080400002)(122000001)(26005)(186003)(110136005)(9686003)(316002)(2906002)(33656002)(38100700002)(76116006)(86362001)(84970400001)(64756008)(38070700005)(55016003)(53546011)(71200400001)(66946007)(66476007)(83380400001)(7696005)(508600001)(66446008)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dEtejF0fVPB7NzFcmmR7QEzFiAYdlJvfjzYNyC4erZJMi4LkCOJjFVZSWlh6?= =?us-ascii?Q?9AG1drLz0MORyxjloS66YTuJO0h1UmAy3GcMJxMWqboyuqDO5v2e6GcX1Hpx?= =?us-ascii?Q?Am9oNxVJpOm73+K/Y0ac/JNR30G9VjAYcRoOAm0WGUQVZ1X41NLiNPZBDk+8?= =?us-ascii?Q?6xEP7fxe9DhJqI/8EQZkDpY0eMtbJcKJe1qOQnOtQz+7GhUJHK+YwFx8a+uS?= =?us-ascii?Q?5DLRhE+TQRzfztJfnIgAr8onE9G9yiuXhuP7GEvAFf3oTsg5j3q2g8V5j8R4?= =?us-ascii?Q?X3lgyu8lP5F1DRyKHF7DY0gDwDgdMYzXEKomW9GDRdwQGp1ZbtzTSFLANFkY?= =?us-ascii?Q?AbZYHKsVPSK6Q7yN8YlhwcTanWq0R88z9w4tHjMa5nMXw3RxYBskSc9H0818?= =?us-ascii?Q?a3pPT0kEOl7OR5hLp4GgNTDs1iINfGQe/LdcyKMC8uUjzNeVFvtSiKXZmOFD?= =?us-ascii?Q?IQJmuP/TcKS5BsIODBjLdF6U07wHCvvHF3dnyQkgbVhF3hhB1RnXS+/f5m3Z?= =?us-ascii?Q?TY+mRVg4icKeHGjKb7fquv95JNYshR1Y5Li9QLU0UgZ9rxXDoPTWm1Imsl1n?= =?us-ascii?Q?4jYYI+7rgDZg8dUEu6fqxDzed0PoMtwGQUntXAJmS6kW8IL0QZx+cv0MmEkJ?= =?us-ascii?Q?/Bwbyx1LIqGJ0WhIA5I8Qyr/Xcbb6Er2gKeJpb9C+YfnlWAkup/URxUoU3tQ?= =?us-ascii?Q?Uln8mNXrolhED/DTMhReY7ZpZiCCJWcmwHQqVb9OmwAVvwOTI4uu5G15bu3W?= =?us-ascii?Q?3icDim9XkfYaiihtYIQk6LGtTomTabYYukKI+VY4kP3DutBk6gYSe2NnsXes?= =?us-ascii?Q?iDQHkwJC0mIa+RSL/XPu2f9ZXs4laAET+SS9oOmK3IBaT27U46JN38+nuzga?= =?us-ascii?Q?NXxlyd1St4GnQspNWIorV3ugbhp9BJj9djpH/nRfxO82RlhaJc3LYcnLS4P3?= =?us-ascii?Q?ZDbfg//PG9OyMv2+MrA6r4X/OAhE/njVxQc9chRJ+eQQZTAs85aMDfeWBZPr?= =?us-ascii?Q?5+U9pCbvLzcvuFOXpyxx3eNvL5re6TCDdhpQKiHDLhtVgk8L6IVpuz9x+FuN?= =?us-ascii?Q?bA4bn7QeNoRs6QVPQ0N55or6c7tA3bcRn69eu6mBZhVhiAeoAjAjdUWelSHY?= =?us-ascii?Q?j249VcFRo0L4bSTskmFSHtMOUMvGEmUnD+cJ40zsJKiKLeY5Sv2usOUjbchm?= =?us-ascii?Q?yufE5MGxtEq5yEiIdMGYKwqyWVJJvnVrpubn6pSi/0kAoOPDlXIC7nQW4/K6?= =?us-ascii?Q?nbTxCBHXQXzwww7hoP88cL4xKlPiNSaejoTgux7LxhS9zXzamKyCELRZd3gb?= =?us-ascii?Q?Of8QpD1ehwX3oORE1CaL/Y89fVNW/uWYFfPqPj32UVobqi5yKejvbNfo9GLz?= =?us-ascii?Q?qlBewnpiuSbZSAV8VJBMb+c4Luzg9jAWp7o8TRsKdfS4rmOrXyGivGhQRw1X?= =?us-ascii?Q?2EnXRul4mqbexhx1pEAWIW4BhKFjSD8c78W8P/AC6nuV8ErjOSr8dDHmyzsk?= =?us-ascii?Q?o8mUhOvGNdhbmjYKPqy7Gzc0lW4ezyNetkNaiPAx5pObG1dTWnQHydodO/ph?= =?us-ascii?Q?44OmHjdeIpJAydALIywgyRKCTbtriVve0mxX8Mn13kW6IcDsZVM9l2+pJ6c8?= =?us-ascii?Q?L24B/57SrSYbOr9egkpn5bwHhW/rr/Z6KgHetjDu4DXAKPgsoLYidl41h+AY?= =?us-ascii?Q?7X90he9nVY/iCz5rlTIT6xDTXX0azfeNQ39w0C17KWrWXNhZ1LP+moJjK001?= =?us-ascii?Q?IKGmCXuMug=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4965.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4fabf3c-93f2-4b31-de47-08da370669d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 06:36:31.0882 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4JujkuLYsfQXo5QPxIIKEG4HZilabgy6p36glALAsbHclZhTj20F48XYHl/N7NOieXp9NSyO+CAypVG65EaYzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4347 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "George, Jini Susan via Gdb-patches" Reply-To: "George, Jini Susan" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" [Public] Thanks for your patches, Nils, Cristian, Abdul, Felix -- these are extremel= y helpful. I have tried your patches with AMD AOCC flang and these boost up= the fortran tests pass rate for flang also hugely. A very minor suggestion: gdb.fortran/common-block.exp (lines 62 and 73): it would be great if you co= uld add flang also along with ifx/ifort in the comments. Thanks, Jini. >>-----Original Message----- >>From: Gdb-patches >bounces+jigeorge=3Damd.com@sourceware.org> On Behalf Of Kempke, Nils- >>Christian via Gdb-patches >>Sent: Wednesday, May 11, 2022 9:02 PM >>To: Andrew Burgess ; gdb-patches@sourceware.org >>Subject: RE: [PATCH 18/18] gdb/testsuite: fixup common-block.exp for inte= l >>compilers >> >>[CAUTION: External Email] >> >>> -----Original Message----- >>> From: Andrew Burgess >>> Sent: Wednesday, May 11, 2022 3:29 PM >>> To: Kempke, Nils-Christian ; gdb- >>> patches@sourceware.org >>> Cc: JiniSusan.George@amd.com; Kempke, Nils-Christian >> christian.kempke@intel.com> >>> Subject: Re: [PATCH 18/18] gdb/testsuite: fixup common-block.exp for >>> intel compilers >>> >>> Nils-Christian Kempke writes: >>> >>> > The order in which the variables in info common and info locals are >>> > displayed is compiler (and dwarf) dependent. While all symbols >>> > should be displayed the order is not fixed. >>> > >>> > I added a gdb_test_multiple that lets ifx and ifort pass in cases >>> > where only the order differs. >>> > --- >>> > gdb/testsuite/gdb.fortran/common-block.exp | 38 >>> ++++++++++++++++++++-- >>> > 1 file changed, 35 insertions(+), 3 deletions(-) >>> > >>> > diff --git a/gdb/testsuite/gdb.fortran/common-block.exp >>> b/gdb/testsuite/gdb.fortran/common-block.exp >>> > index ac39a4a575..fc38b8d772 100644 >>> > --- a/gdb/testsuite/gdb.fortran/common-block.exp >>> > +++ b/gdb/testsuite/gdb.fortran/common-block.exp >>> > @@ -54,8 +54,27 @@ gdb_test "whatis fo_o$suffix" "No symbol >>> \"fo_o$suffix\" in current context." >>> > gdb_test "ptype fo_o$suffix" "No symbol \"fo_o$suffix\" in current >>> context." >>> > gdb_test "p fo_o$suffix" "No symbol \"fo_o$suffix\" in current conte= xt." >>> > >>> > -gdb_test "info locals" "ix_x =3D 11\r\niy_y =3D 22\r\niz_z =3D 33\r\= nix =3D >>> > 1\r\niy =3D >>> 2\r\niz =3D 3" "info locals out" >>> > -gdb_test "info common" "Contents of F77 COMMON block >>> > 'fo_o':\r\nix_x >>> =3D 11\r\niy_y =3D 22\r\niz_z =3D 33\r\n\r\nContents of F77 COMMON bloc= k >>> 'foo':\r\nix =3D 1\r\niy =3D 2\r\niz =3D 3" "info common out" >>> > +gdb_test_multiple "info locals" "info locals out" { >>> > + # gfortran >>> > + -re "ix_x =3D 11\r\niy_y =3D 22\r\niz_z =3D 33\r\nix =3D 1\r\niy= =3D >>> > +2\r\niz =3D >>> 3.*$gdb_prompt $" { >>> > + pass $gdb_test_name >>> > + } >>> >>> You can use: >>> >>> -re -wrap "ix_x =3D 11\r\niy_y =3D 22\r\niz_z =3D 33\r\nix =3D 1\r\ni= y =3D 2\r\niz =3D 3" { >>> ... >>> } >>> >>> to avoid having to add the $gdb_prompt in all of these tests. >>> >>> Thanks, >>> Andrew >> >>Thanks! That is more convenient indeed. >>Changed in v2. >> >>Nils >> >>Intel Deutschland GmbH >>Registered Address: Am Campeon 10, 85579 Neubiberg, Germany >>Tel: +49 89 99 8853-0, >>https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.in= t >>el.de%2F&data=3D05%7C01%7CJiniSusan.George%40amd.com%7C386b8a27 >>b41c4c31135e08da3363612b%7C3dd8961fe4884e608e11a82d994e183d%7C0% >>7C0%7C637878799180300920%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL >>jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C >>%7C&sdata=3DiahWHgSrYwg0K1Fb6%2Fm%2B49ZdPwxx%2F9sGZP1oUc09Z7 >>4%3D&reserved=3D0 >>>tel.de%2F&data=3D05%7C01%7CJiniSusan.George%40amd.com%7C386b8a2 >>7b41c4c31135e08da3363612b%7C3dd8961fe4884e608e11a82d994e183d%7C0 >>%7C0%7C637878799180300920%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 >>wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C >>%7C%7C&sdata=3DiahWHgSrYwg0K1Fb6%2Fm%2B49ZdPwxx%2F9sGZP1oUc >>09Z74%3D&reserved=3D0> >>Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva >>Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munic= h >>Commercial Register: Amtsgericht Muenchen HRB 186928