From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81562 invoked by alias); 10 Sep 2015 14:09:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81542 invoked by uid 89); 10 Sep 2015 14:09:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1bon0137.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.111.137) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Thu, 10 Sep 2015 14:09:37 +0000 Received: from BY2PR0301MB1527.namprd03.prod.outlook.com (10.163.27.153) by BY2PR0301MB1526.namprd03.prod.outlook.com (10.163.27.152) with Microsoft SMTP Server (TLS) id 15.1.262.15; Thu, 10 Sep 2015 14:09:32 +0000 Received: from BY2PR0301MB1527.namprd03.prod.outlook.com ([10.163.27.153]) by BY2PR0301MB1527.namprd03.prod.outlook.com ([10.163.27.153]) with mapi id 15.01.0262.011; Thu, 10 Sep 2015 14:09:33 +0000 From: Nistor Mihail To: Yao Qi CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdb/18947: [aarch64]Step into shared library is very slow. Date: Thu, 10 Sep 2015 14:09:00 -0000 Message-ID: References: <1441876920-32009-1-git-send-email-mihail.nistor@freescale.com> <86613i7b1b.fsf@gmail.com> <861te674zl.fsf@gmail.com> In-Reply-To: <861te674zl.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=mihail.nistor@freescale.com; x-microsoft-exchange-diagnostics: 1;BY2PR0301MB1526;5:0NHkKWeQRdKgudu+fnfXyweNXseQbLE6MmPW9c34wJ6aqRDCtLrEcP4rtvVFCxVKwstHZJGvwRe6nbInv3VC+ZHQbRKfQykU19YW83eAD8D5eUo5j6fktBcfxTpVpsNoGaSiNSuTyPz0Q+wDC514ZQ==;24:1sTQ2fhvsEKyPHDoUg++3IefMUdJ5iW+6HClF3MhsgadrwrHeS8EqEWgKoUiM4ccFAhBS/OLMKFCx/lNc37x52P0s6uPqz8i+RtNQvsXJNY=;20:MiO6R062gy/+sKr72s11MLFfKFa71wcniXWq9DOD+p5nOhIeKwuPfyN2CWbW+TW5BDSpPLyd65vaRoAHVFYzgQ== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB1526; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:BY2PR0301MB1526;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB1526; x-forefront-prvs: 06952FC175 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(199003)(13464003)(377454003)(68736005)(76576001)(77096005)(102836002)(33656002)(50986999)(122556002)(189998001)(92566002)(4001540100001)(46102003)(77156002)(74316001)(87936001)(5007970100001)(1411001)(62966003)(99286002)(86362001)(5001830100001)(110136002)(105586002)(93886004)(5004730100002)(5001860100001)(101416001)(10400500002)(40100003)(106356001)(2900100001)(64706001)(19580395003)(5003600100002)(5002640100001)(54356999)(106116001)(81156007)(66066001)(76176999)(19580405001)(2950100001)(5001960100002)(97736004);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB1526;H:BY2PR0301MB1527.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: freescale.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2015 14:09:32.8248 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB1526 X-SW-Source: 2015-09/txt/msg00167.txt.bz2 SGkgWWFvLA0KDQpJIGRvbid0IGhhdmUgdGhlIHdyaXRlIGFjY2VzcyBvbiBn aXQuIENvdWxkIHlvdSBwbGVhc2UgcHV0IHRoaXMgcGF0Y2ggb24gZ2l0Lg0K DQpCZXN0IHJlZ2FyZHMsDQpNaWhhaQ0KLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCkZyb206IFlhbyBRaSBbbWFpbHRvOnFpeWFvbHRjQGdtYWlsLmNv bV0gDQpTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVyIDEwLCAyMDE1IDQ6NTYg UE0NClRvOiBOaXN0b3IgTWloYWlsLU1OSVNUT1IxIDxtaWhhaWwubmlzdG9y QGZyZWVzY2FsZS5jb20+DQpDYzogWWFvIFFpIDxxaXlhb2x0Y0BnbWFpbC5j b20+OyBnZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZw0KU3ViamVjdDogUmU6 IFtQQVRDSF0gZ2RiLzE4OTQ3OiBbYWFyY2g2NF1TdGVwIGludG8gc2hhcmVk IGxpYnJhcnkgaXMgdmVyeSBzbG93Lg0KDQpOaXN0b3IgTWloYWlsIDxtaWhh aWwubmlzdG9yQGZyZWVzY2FsZS5jb20+IHdyaXRlczoNCg0KPiBJIGhhdmUg cnVuIEdEQiB0ZXN0c3VpdGUgZm9yIGFhcmNoNjQgYW5kIEkgZG9uJ3Qgc2Vl IGFueSByZWdyZXNzaW9uLiANCg0KR3JlYXQsIHBsZWFzZSBwdXNoIHlvdXIg Y29tbWl0IGluIHRoZW4uDQoNCi0tIA0KWWFvICjpvZDlsKcpDQo= >From gdb-patches-return-125928-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Sep 10 14:17:41 2015 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 127465 invoked by alias); 10 Sep 2015 14:17:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 127456 invoked by uid 89); 10 Sep 2015 14:17:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Sep 2015 14:17:40 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 0ED09C0AA264; Thu, 10 Sep 2015 14:17:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8AEHa4s000705; Thu, 10 Sep 2015 10:17:37 -0400 Message-ID: <55F19100.30600@redhat.com> Date: Thu, 10 Sep 2015 14:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Paul Pluzhnikov , gdb-patches ml CC: Paul Pluzhnikov , "Maciej W. Rozycki" Subject: Re: [patch] Fix BZ15121 -- x/a broken for addresses in shared libraries References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00168.txt.bz2 Content-length: 723 On 09/06/2015 09:03 PM, Paul Pluzhnikov wrote: > index 91bf49e..0624b90 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -2927,7 +2927,13 @@ unpack_pointer (struct type *type, const gdb_byte *valaddr) > { > /* Assume a CORE_ADDR can fit in a LONGEST (for now). Not sure > whether we want this to be true eventually. */ > - return unpack_long (type, valaddr); > + LONGEST ret = unpack_long (type, valaddr); > + int len = TYPE_LENGTH (type); > + if (sizeof (CORE_ADDR) > len && ret < 0) { > + /* Don't sign-extend 32-bit pointer. BZ 15121. */ > + return ret & ((1UL << (8 * len)) - 1); > + } > + return ret; > } Do we need to keep sign-extending on MIPS? Adding Maciej. Thanks, Pedro Alves