From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0jNXJbGAA2lkBRIAWB0awg (envelope-from ) for ; Thu, 30 Oct 2025 11:13:53 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=uvjZrPy4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 87D0B1E0BC; Thu, 30 Oct 2025 11:13:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 080A91E04C for ; Thu, 30 Oct 2025 11:13:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 774343858407 for ; Thu, 30 Oct 2025 15:13:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 774343858407 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=uvjZrPy4 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c107::3]) by sourceware.org (Postfix) with ESMTPS id D59D33858D2A for ; Thu, 30 Oct 2025 15:13:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D59D33858D2A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D59D33858D2A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c107::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1761837194; cv=pass; b=xgptJqqLSRtw54tsa8oL6K5Kgt99n1zLvrC7iUdsYQzVjNQxUGMoF3SVvEOcxLsfBg1LINfISyU3cBLPfsJX7KaIFK4usJr3KVAvk187b7JL32ozRbp14YzGdE5bsF7m4qI4XzFrUBPOtrmWjtt2oOqq2WQg72Os85lghTYRc/I= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1761837194; c=relaxed/simple; bh=NHRbxkjdUYkLFccDk4CWSx+Zi4qrBEJHIJTCwDYmIEI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=q1E3OtIP+u/GobXiSReRuqBAPH2EJAdbpTGuKiVxF/gdleKdKFUbn4e9HKtriNzNWngXtcQxjHhAn3LvcU1wrjp4rh+/PLMiKRJu99qwPbBecs+JlYzlQk0K9YGj80MaZukp/Fw/93sYmbiPDGgzj/Y31wUrMbEooo73VF3m2Sg= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D59D33858D2A ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kHY4SPdwuSLKToYiUIgQvNaKII9j3rNfKWrL/z+9xUo0et6t15sAVAkCCQR36zz4cX2WQ5PlhLg0SjyYNixiun20Vsvl8XPHYu6ygF/OOtBQGcY62GWWC/kEy5Dva+aD7PJnt0Sra+XbArv5knlhSq//K3T4b/aZKiOfW9bHU/BQLRIvVUYjoYM9uaT0ynFCMl+Ltb+tr2INUCnU6D0xpVxTIcj6OmxReNAgVayiAMr1D+VZMd3+u9Eu8nYYUVxSuW6GpSVBOtByX72hYMSdrDzAWUqy7PlYzrJWdmSCKSAL4z8bGl1sSqE5RNElk3BaAfs1g/5nV3ANZOzLm/lq2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DfQH7RSt/OB7sgpIblXp4M9GpM7TJBEPbsKcbtZyjAE=; b=eReW2Ayeog01D9JtYuXlsqiT8LFdbv8QAzUfhbZltwUEUgH+reKKwsAjh8BXNcv9igs4w8mj1i2290JAd/S5R8lAyz44kljq0wkexDnL+tTe8JYTYCtqs37eppizey/HcDsvgu6qiIRbMUc1HQRWD8fpULiCYyn6scmbSOwgarFXh0WBXcl9S/RJ8umL/pKBpfZlxjfnn97XQLuah6a29rED3OwIaCOx/2/hUfppN4Xp2Bg5MUcEo/ThflEUN53lBm16VBcuOSqoffUA3R3odwVb8plvUzkEW2DvaysP67kJZEdVOKJiEcA15roLhghMxSgf4MIFHKT+VJjIA3bHIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfQH7RSt/OB7sgpIblXp4M9GpM7TJBEPbsKcbtZyjAE=; b=uvjZrPy4hN7gqYDurl8z/iYKYBwu+8ubB/Y9LeCbObVxMBs2tpeZl7ehNMyePgdPyzjZmYrEzLNnkYMpggPjMVpEtsmEKBmI/SIeSn3vtSlusCTdAFwzpjuTH6uZmM0/oDdMQ1gEoyJno2gJMkXznHLMj9jfiRt+jcymDJH+Xo0= Received: from BN7PPF915F74166.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6d9) by CY8PR12MB7413.namprd12.prod.outlook.com (2603:10b6:930:5f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.13; Thu, 30 Oct 2025 15:13:07 +0000 Received: from BN7PPF915F74166.namprd12.prod.outlook.com ([fe80::4b:439a:8d8b:a666]) by BN7PPF915F74166.namprd12.prod.outlook.com ([fe80::4b:439a:8d8b:a666%8]) with mapi id 15.20.9253.018; Thu, 30 Oct 2025 15:13:07 +0000 From: "Machado, Luis" To: "Six, Lancelot" , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix device index in gdb.rocm/addr-bp-gpu-no-deb-info.exp Thread-Topic: [PATCH] Fix device index in gdb.rocm/addr-bp-gpu-no-deb-info.exp Thread-Index: AQHcSayx9ELIwdMp50SSYljWpxR0nrTay/5H Date: Thu, 30 Oct 2025 15:13:07 +0000 Message-ID: References: <20251030095404.422806-1-luis.machado@amd.com> In-Reply-To: Accept-Language: en-150, en-US Content-Language: aa X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=True; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2025-10-30T15:13:06.855Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=1; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PPF915F74166:EE_|CY8PR12MB7413:EE_ x-ms-office365-filtering-correlation-id: d474046b-1f38-4c1d-3887-08de17c6d4d2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700021|13003099007|7053199007; x-microsoft-antispam-message-info: =?us-ascii?Q?7Bo6CSQdDkLKTcKDtpcBIEcYO4NhrihdLiMEp4R4bxmFmYwPTKiDoNYuPEC9?= =?us-ascii?Q?lT6aOTgCrxrSs5YTplxCvyX6LoQroWmxkjih72VB229/utRMiyMx6d/tUvXs?= =?us-ascii?Q?ziLRnmBA/vd0vHcCHxwfWSOr8WzoV+RfDc3RnhuJF8rtzRY7Tc+XuJiyILiM?= =?us-ascii?Q?sik1g8nTs40aSR7PaZTQYccRZkTXXc3LUflzsaNw/9KgTrW83Q98LJR5Dv2j?= =?us-ascii?Q?6DlvAlgKWXkLacrVxFGRF3chS5fcuEsqzfgPxdh+8tvXG1MpVAidlACmpRgw?= =?us-ascii?Q?3LrEo1QmVXU/6adr/CC2dRmdyMLruEQDCzRAzycYRl8ZObyIYc+tykCcfdde?= =?us-ascii?Q?0Tw0/JtxeFhytRb4Esc2RxXuZvCPobSmuQUWCY4BtvlHzJQiJRxaYrEtmFna?= =?us-ascii?Q?uNxCz87JEzYQJjLbCWRgmG0hoLN61ODiM4D4/TE5B1BCAoX6fyKOduJV1VEj?= =?us-ascii?Q?fjXhC6XECq6Evt1lkO2ur3QaJ3BfGn0zoTTc5VfWDwyB0cec1yO6z0pK60Cl?= =?us-ascii?Q?migYe3sTCnSembqg5MdkQkpu1Crk6lzEfewLBhPACTSVF7yd3lRokuqVlLqA?= =?us-ascii?Q?6QqCsOwVUual77RPR2zPCP06svxD+ZnDfr/JThDIIa+ya2OjNTgglh8awPee?= =?us-ascii?Q?awQsTJTsSHQrNcN9lODpYmPJsupYsyt/NcAae3d4Wof+YYnrYdBLZKbrRlJO?= =?us-ascii?Q?3bnUF7p3h/96UxYfU4WCF6g23jnIhoS2ARMHFi7spPxr6qhEgd0YZ0l4Zbu0?= =?us-ascii?Q?TATjn26xgGeRgRQbGP0xnSQq9026UOwW2KCF40RgRV0LWUPimfAodm0qWARD?= =?us-ascii?Q?l4lV1BpTktT+LjsFKWlIawjGxDAMo498S49imZnylm5PyAGRskTB2elBceLl?= =?us-ascii?Q?+52nagK7GaIQXMnrYrTIYMTj5KcXiy1Wf5YD53o3tjzA3jJjFX2JYccUL6O2?= =?us-ascii?Q?lRGVtZvtlihh0rzW1jHM8dwreDv/JM1DMWy5uV5CvAOyLv6A8SJf8L7BIjeF?= =?us-ascii?Q?1jxWjY42jaGCmEy6qUrA9ZlaiDRE3Z+ewWQmPh+TS+6MPqqAhYq7R1Bm3kvA?= =?us-ascii?Q?zVDuka6IYcJBh+eQebXUoAexcIvM5w9YHPoLa67VYXJJoCrbL9MG41W50Tqg?= =?us-ascii?Q?QcA+QlZq8BpAi/J4KM0pnExCulJWLP6/v0aEEBexeJzgbLoWT5SV/m+2BXJp?= =?us-ascii?Q?3rSuTyfovkiOduebVsoROTK11TwCsFuagjQPfUmvMHL8tMZG5hE7h//BDFzm?= =?us-ascii?Q?Nv9+LPFTD+01mpBJNMIP9tzYlYq9cVylBToEFKCZuKT9FRmFs9eHST5ibl8x?= =?us-ascii?Q?bX/7O7p80Skn2WswCDdNOd8vfjsD+lNDvqsghrL7NqADACylA2IAix2pzIdA?= =?us-ascii?Q?La5cd6uJ40VEEKIElNeF5thVX8rAFbDlyocfzZcrXUmWrgTa/T1REe+8vgeF?= =?us-ascii?Q?/BPBq2KtB4CBQvE5rP3nKG/P0coQ+Bbg9NLFQNVWf8UXOPJ5FFfhwg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PPF915F74166.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700021)(13003099007)(7053199007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ErKzP1bG7+neSijV5v6SWwRMQA7pdip+KgoEi3aWGk8qel4ZL4suxRTr31HT?= =?us-ascii?Q?HzXnFYZjqsYxt9sQD6KEbDP7OTHWYkxDjLY9ceboI/dklMPgaufh2mOFGkIG?= =?us-ascii?Q?tWBxJpzx9LRUBCNSRAGnnjutzSP7knRfroCNprLM2yY6I0OB6T8bp+UBsUdA?= =?us-ascii?Q?y0r1KI1YnH7g1kyoLIqhh9hH0XtEOU1zOeD6lvAkdmvro7P1SxtMsFzI1Rn5?= =?us-ascii?Q?6hQ0bnsVMH8p5Y4iMWo4xgmHX4QDqcanzRiaO9rewHpf4nkHZ1VlKv2q30/N?= =?us-ascii?Q?iLqSMGFGfmKOz/m1IunueaVlyhGfyL/8YvqmFHqxHMzDl8/mfkjfoODji5Rx?= =?us-ascii?Q?JbskVes0qxHEEHdiyr0fQy+HTreUH81c8vYJ25VLiFboewb0rQNfKZorqnWR?= =?us-ascii?Q?v7yJhCDvHIT5h9L7seyse0kdbhHihQXXLt3x33/ayou0yoYawWSSCKw6apGl?= =?us-ascii?Q?Opm9bl+8RVC/2coIU8iVbnATCaz/vzMW1FagGicjf8zPkzJL4bem2uObSD9G?= =?us-ascii?Q?fvCBdWvyKTmJ8KPip7B5dOLs31S0JXk7+AcF7qotsc5fybufyDkTABHk04XW?= =?us-ascii?Q?5w2g61rMJwFcH/l3zwgsTQLjxLHoIlOChVMeXMwda6ZKW9Mnp3ofWFp3b2f9?= =?us-ascii?Q?Tuy1zbgQjK8GPotIY4vlKwoPsCs9f9Zd5vlfm41ZviPkeiKVVNDRnq/kuZnd?= =?us-ascii?Q?bWQMNufFKsE0l4IR6ZvFb+ODge0UTwv6AUZYyLDqHhsgrS6Zd1y0kuOU+wOJ?= =?us-ascii?Q?CLN7E/pNV4cZIXN3fbrQBGIslMCC7T/PEMO9WtzpJcTaT2kRJv/eZhI0Ap7L?= =?us-ascii?Q?vH7jOMNSRPr40DPFFPs1qQWPTUomnDLaewJP6ReZiI0R7VtWINw8QYISVsI7?= =?us-ascii?Q?YTP2qVRLfeh+8dG58fhTyqVsAVT3K6NPMrbW3gB2/LpBM//rvGkToalFrmJ3?= =?us-ascii?Q?utsoOxFHtYAwxJOGRozIhbY5n3vvoD71YxzCavrH1NQR7fRiX43Ph2woW8b5?= =?us-ascii?Q?dgv205Gkkhzybwz7tguTwXrIKc09cU50ks66dXAyXoWXRVXAk/Zw0A360yqh?= =?us-ascii?Q?s1RTbDvbNHdE+93fDgAJnDGgPT+QrxaEZHYkAcds58K6OinbJXF+3Hw3FS9/?= =?us-ascii?Q?QtHpLrqodyDWLsEhfS3Pz8dwPkkj68JoUpNB4GnLnBYOA5EOKCvAKSbpOT7y?= =?us-ascii?Q?Wsn2NTy+vu4KXWafVlb9xXV4CZH/f2zIT9FqpryDKFv86H92evOn+cOdOq7a?= =?us-ascii?Q?Gx+sVfKmid+ROYAoChqTcWYGVMzB2RS7mW2QAxTb7LbowI9+RYS3T9+9jdab?= =?us-ascii?Q?uhWWy/7JwuyhRX4C9p0x20vF2P7pfOwFq/rT525NghuDssinZB//kAwa6Cta?= =?us-ascii?Q?3mV5skCA3rTSzMY4OaSVeB7EtPs640WeizDCECzA9FAkWbSzSVOsw3zbLPjO?= =?us-ascii?Q?J1AcKOSt6FiC95AO1xoP+N3k1k7gW3+LZeYPHM/WSsZo8bMadbXanOvbf6bT?= =?us-ascii?Q?pwqXoMJIa5JIUPSDvmqNWw9GWiwYOTiQ3SMgys+J4mBxAZZhjJLMPPGle5Ob?= =?us-ascii?Q?HJL/vnlQuA4kMpSxZmY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PPF915F74166.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d474046b-1f38-4c1d-3887-08de17c6d4d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2025 15:13:07.4423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fZEbw6ubDxRoBeXNqHEhb0s180sBbr5nxdCKkCppEGSbdv11IbsCBgLFa21cOWZ55sZMz3Zj9WxGP+tcwJpxNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7413 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks. Pushed now.=0A= =0A= =0A= ________________________________________=0A= From: Six, Lancelot =0A= Sent: Thursday, 30 October 2025 14:51=0A= To: Machado, Luis; gdb-patches@sourceware.org=0A= Subject: Re: [PATCH] Fix device index in gdb.rocm/addr-bp-gpu-no-deb-info.e= xp=0A= =0A= On Thu, Oct 30, 2025 at 09:54:04AM +0000, Luis Machado wrote:=0A= > On a system with a single GPU, I spotted this test failing. The environme= nt=0A= > variable ROCR_VISIBLE_DEVICES can be a bit misleading, as it actually exp= ects=0A= > a list of device id's as opposed to a literal number of devices to make= =0A= > visible.=0A= >=0A= > This test sets it to 1, which is the second GPU on the system. As a resul= t,=0A= > systems with a single GPU will have no visible GPU's and the test will FA= IL.=0A= >=0A= > Set ROCR_VISIBLE_DEVICES to 0 to make use of the first GPU on the system.= =0A= >=0A= =0A= This looks good to me, thanks for fixing this.=0A= =0A= Approvid-by: Lancelot Six (AMDGPU)=0A= =0A= Best,=0A= Lancelot.=0A= =0A= > ---=0A= > gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp | 7 ++++---=0A= > 1 file changed, 4 insertions(+), 3 deletions(-)=0A= >=0A= > diff --git a/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp b/gdb/tes= tsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp=0A= > index be459673dc9..2719f0d8b13 100644=0A= > --- a/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp=0A= > +++ b/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp=0A= > @@ -28,9 +28,10 @@ if {[build_executable "failed to prepare" $testfile $s= rcfile {hip}]} {=0A= >=0A= > clean_restart $::testfile=0A= >=0A= > -# We may have multiple GPUs, resulting in many possible locations. This = is=0A= > -# needed to ensure we get a single address to break on.=0A= > -gdb_test_no_output "set environment ROCR_VISIBLE_DEVICES=3D1"=0A= > +# We may have multiple GPUs, resulting in many possible locations. This= is=0A= > +# needed to ensure we get a single address to break on, so make device 0= the=0A= > +# only visible one.=0A= > +gdb_test_no_output "set environment ROCR_VISIBLE_DEVICES=3D0"=0A= >=0A= > # Make the HIP runtime load all the GPU code objects during initializati= on.=0A= > gdb_test_no_output "set environment HIP_ENABLE_DEFERRED_LOADING=3D0"=0A= > --=0A= > 2.43.0=0A=