From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13450 invoked by alias); 21 Dec 2014 09:13:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13438 invoked by uid 89); 21 Dec 2014 09:13:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1bon0131.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.111.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Sun, 21 Dec 2014 09:13:21 +0000 Received: from BN1PR0301MB0628.namprd03.prod.outlook.com (25.160.171.13) by BN1PR0301MB0628.namprd03.prod.outlook.com (25.160.171.13) with Microsoft SMTP Server (TLS) id 15.1.49.12; Sun, 21 Dec 2014 09:13:17 +0000 Received: from BN1PR0301MB0628.namprd03.prod.outlook.com ([25.160.171.13]) by BN1PR0301MB0628.namprd03.prod.outlook.com ([25.160.171.13]) with mapi id 15.01.0049.002; Sun, 21 Dec 2014 09:13:17 +0000 From: "mihail.nistor@freescale.com" To: Joel Brobecker CC: Keith Seitz , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2] Bug 17394: we cannot put a break-point at a global function for ASM file Date: Sun, 21 Dec 2014 09:13:00 -0000 Message-ID: References: <1410954786-17690-1-git-send-email-mihail.nistor@freescale.com> <542459B9.9090705@redhat.com> <23ca9e13576840e280392b69e5cc7de8@BN1PR0301MB0628.namprd03.prod.outlook.com> <7dec43bc41e044fcbba3289ca7cb2697@BN1PR0301MB0628.namprd03.prod.outlook.com> <542B0854.6050804@redhat.com> <20141213130429.GA12185@adacore.com> <20141220163307.GE12884@adacore.com> In-Reply-To: <20141220163307.GE12884@adacore.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=mihail.nistor@freescale.com; x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0628; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0628; x-forefront-prvs: 0432A04947 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(377454003)(51704005)(13464003)(189002)(43544003)(45984002)(24454002)(199003)(106356001)(87936001)(107046002)(2656002)(68736005)(110136001)(106116001)(105586002)(2950100001)(2900100001)(102836002)(64706001)(77156002)(66066001)(62966003)(122556002)(20776003)(74316001)(101416001)(19580395003)(97736003)(76576001)(46102003)(19580405001)(93886004)(92566001)(86362001)(31966008)(54206007)(40100003)(33656002)(21056001)(50986999)(76176999)(120916001)(99396003)(4396001)(99286002)(54606007)(54356999);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR0301MB0628;H:BN1PR0301MB0628.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: freescale.com does not designate permitted sender hosts) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2014 09:13:17.2454 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0628 X-SW-Source: 2014-12/txt/msg00600.txt.bz2 Hello Joel, Thank you very much for your help and guidance. In the future I will do as you told me and I hope everything will go smooth= ly. Thank you again, Mihai -----Original Message----- From: Joel Brobecker [mailto:brobecker@adacore.com]=20 Sent: Saturday, December 20, 2014 6:33 PM To: Nistor Mihail-MNISTOR1 Cc: Keith Seitz; gdb-patches@sourceware.org Subject: Re: [PATCH v2] Bug 17394: we cannot put a break-point at a global = function for ASM file On Mon, Dec 15, 2014 at 08:47:19PM +0000, mihail.nistor@freescale.com wrote: > Thank you very much for your support. >=20 > You will find enclosed a new patch. [...] > > gdb/ChangeLog: > > 2014-09-30 Keith Seitz > > Mihail-Marian Nistor > >=20 > > PR gdb/17394 > > * linespec.c (struct collect_minsyms): Add new member `symtab'. > > (add_minsym): Handle cases where info.symtab is non-NULL. > > (search_minsyms_for_name): Add new parameter `symtab'. > > Handle limiting searches to a specific symtab. > > (add_matching_symtabs_to_info): Search through minimal symbols > > for language_asm files for which no new symbols are found. > >=20 > > gdb/testsuite/ChangeLog: > > 2014-09-30 Mihail-Marian Nistor > >=20 > > PR gdb/17394 > > * gdb.linespec/break-asm-file.c: New file. > > * gdb.linespec/break-asm-file.exp: New file. > > * gdb.linespec/break-asm-file0.s: New file. > > * gdb.linespec/break-asm-file1.s: New file. Thank you. The patch is approved. I have a few small additional remarks that came up following the review: The most important one that I almost tripped over, is the fact that the pat= ch no longer builds on today's master due to a change in struct symtab. Thi= s goes to show that, when one asks for the patch to be rebased, we should j= ust go ahead and do not just that, but also re-test it, even if the file th= at it touches hasn't changed in the interim. I've made the required changes= and re-done testing this time around. In the future, it would really help if you could send the commits to us, ra= ther than just the diff. What we're interesting in, in addition to the diff= , is the commit's revision log. It should contain a detailed description of= the problem you're trying to solve, and how you're solving it (usually, we= try to put the "why" in the code). We try to do that at every iteration of the review, so we can= keep an eye on the contents of the revision log and make sure it's complet= e and accurate. And another advantage is that it allows me to push your pat= ch in under 10 seconds rather than having to apply a diff, make sure I don'= t miss some changes along the way, commit, write the revision log, get your= email address (as commit author), etc. Since there is a PR and testcase, and this patch has been delayed quite a b= it for lack of review, I will take care of creating the commit this time. Attached is the commit I just pushed. -- Joel