From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13469 invoked by alias); 10 Dec 2014 21:11:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13446 invoked by uid 89); 10 Dec 2014 21:11:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bl2-obe.outbound.protection.outlook.com Received: from mail-bl2on0138.outbound.protection.outlook.com (HELO na01-bl2-obe.outbound.protection.outlook.com) (65.55.169.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Wed, 10 Dec 2014 21:11:24 +0000 Received: from BN1PR0301MB0628.namprd03.prod.outlook.com (25.160.171.13) by BN1PR0301MB0705.namprd03.prod.outlook.com (25.160.78.12) with Microsoft SMTP Server (TLS) id 15.1.31.17; Wed, 10 Dec 2014 21:11:20 +0000 Received: from BN1PR0301MB0628.namprd03.prod.outlook.com ([25.160.171.13]) by BN1PR0301MB0628.namprd03.prod.outlook.com ([25.160.171.13]) with mapi id 15.01.0031.000; Wed, 10 Dec 2014 21:11:20 +0000 From: "mihail.nistor@freescale.com" To: "palves@redhat.com" , "brobecker@adacore.com" , "kevinb@redhat.com" , "cagney@gnu.org" , "dje@google.com" , "drow@false.org" , "kettenis@gnu.org" , "jan.kratochvil@redhat.com" , "stan@codesourcery.com" , "tromey@redhat.com" , "Ulrich.Weigand@de.ibm.com" , "elena.zannoni@oracle.com" , "eliz@gnu.org" , "gdb-patches@sourceware.org" CC: "keiths@redhat.com" , "mihaela.ilies@freescale.com" Subject: RE: [PING] [PATCH v2] Bug 17394: we cannot put a break-point at a global function for ASM file Date: Wed, 10 Dec 2014 21:11:00 -0000 Message-ID: x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0705; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0705; x-forefront-prvs: 0421BF7135 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(504964003)(13464003)(51704005)(377454003)(377424004)(479174003)(189002)(199003)(2501002)(97736003)(20776003)(46102003)(31966008)(66066001)(64706001)(4396001)(76576001)(77156002)(62966003)(105586002)(33656002)(54206007)(54356999)(92566001)(50986999)(54606007)(2201001)(86362001)(107046002)(40100003)(21056001)(120916001)(2656002)(99286002)(68736005)(102836002)(106116001)(106356001)(87936001)(19580405001)(122556002)(101416001)(99396003)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR0301MB0705;H:BN1PR0301MB0628.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-SW-Source: 2014-12/txt/msg00232.txt.bz2 Hello global maintainers, The deadline to receive the review for patch from a maintainer expired. Kei= th Seitz required a review from a maintainer for this patch on 30 September= 2014. Please help us to find a maintainer that can do the review for this patch. =20=20 Thank you in advance for your support. Mihai -----Original Message----- From: Nistor Mihail-MNISTOR1=20 Sent: Tuesday, December 09, 2014 5:02 PM To: 'gdb-patches@sourceware.org'; 'palves@redhat.com' Cc: 'keiths@redhat.com' Subject: FW: [PING] [PATCH v2] Bug 17394: we cannot put a break-point at a = global function for ASM file Hello Pedro, We need support from a maintainer to give the final approval for this patch= . Can you please help us to look over this patch or recommend another maint= ainer to do it. Thank you, Mihai -----Original Message----- From: Nistor Mihail-MNISTOR1 Sent: Saturday, November 15, 2014 7:35 PM To: 'gdb-patches@sourceware.org' Cc: 'Keith Seitz' Subject: FW:[PING] [PATCH v2] Bug 17394: we cannot put a break-point at a g= lobal function for ASM file Dear all, I would like to remind you that the patch attached is still pending for the= final approval. When we last exchanged messages there seemed to be no problem; has anything= happened since ? I'm looking forward to your reply. Thank you, Mihai -----Original Message----- From: Keith Seitz [mailto:keiths@redhat.com] Sent: Tuesday, September 30, 2014 10:45 PM To: Nistor Mihail-MNISTOR1; gdb-patches@sourceware.org Subject: Re: [PATCH v2] Bug 17394: we cannot put a break-point at a global = function for ASM file On 09/28/2014 09:08 AM, mihail.nistor@freescale.com wrote: > -----Original Message----- > From: Nistor Mihail-MNISTOR1 > Sent: Sunday, September 28, 2014 6:47 PM > To: Keith Seitz; gdb-patches@sourceware.org > Cc: Nistor Mihail-MNISTOR1 > Subject: RE: [PATCH v2] Bug 17394: we cannot put a break-point at a=20 > global function for ASM file > > Your changes look very well, I have one little observation regarding the = filtering condition when we need to get information from minimal symbol. > Scenario: We can mix objects that were compiled/assembled by different ve= ndors and the third party assembler provides debug information and it doesn= 't have this limitation. An application may contain more than one file that= have the same name. We cannot put a breakpoint at a function in all object= s that have the same name if an object that comes from ASM file has debug i= nfo and is linked before the objects assembled with the GNU-GAS. In the new= test case I have tried to emulate the third party assembler behavior in th= e break-asm-file1.s. > That makes sense to me. FWIW, here is a combined patch which I think a main= tainer should give a final look over. Thank you for the patch! Keith gdb/ChangeLog: 2014-09-30 Keith Seitz Mihail-Marian Nistor PR gdb/17394 * linespec.c (struct collect_minsyms): Add new member `symtab'. (add_minsym): Handle cases where info.symtab is non-NULL. (search_minsyms_for_name): Add new parameter `symtab'. Handle limiting searches to a specific symtab. (add_matching_symtabs_to_info): Search through minimal symbols for language_asm files for which no new symbols are found. gdb/testsuite/ChangeLog: 2014-09-30 Mihail-Marian Nistor PR gdb/17394 * gdb.linespec/break-asm-file.c: New file. * gdb.linespec/break-asm-file.exp: New file. * gdb.linespec/break-asm-file0.s: New file. * gdb.linespec/break-asm-file1.s: New file.