Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: John David Anglin <dave.anglin@bell.net>
To: Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFC PATCH] hppa-hpux-tdep.c: Fix host dependency.
Date: Tue, 12 Mar 2013 03:10:00 -0000	[thread overview]
Message-ID: <BLU0-SMTP32C93B36114D0080E297C297E20@phx.gbl> (raw)
In-Reply-To: <513DF86E.7030203@redhat.com>

On 11-Mar-13, at 11:29 AM, Pedro Alves wrote:

> Would you be able to help giving this patch a quick try
> on HP-UX?

Patched file compiles fine on both hppa2.0w-hp-hpux11.11 and
hppa64-hp-hpux11.11.  I think the trampoline works on hppa64:

(gdb) p var
$4 = (tree) 0x800003fffdeaab48
(gdb) p debug_tree (var)
  <var_decl 800003fffdeaab48 D.1404
     type <integer_type 800003fffddc97e0 long unsigned int public  
unsigned DI
         size <integer_cst 800003fffddc05a0 constant 64>
         unit size <integer_cst 800003fffddc05c0 constant 8>
         align 64 symtab 0 alias set -1 canonical type  
800003fffddc97e0 precision 64 min <integer_cst 800003fffddc09a0 0> max  
<integer_cst 800003fffddc0980 18446744073709551615>>
     used unsigned ignored DI file /test/gnu/gcc/gcc/gcc/testsuite/ 
gcc.c-torture/compile/pr55921.c line 10 col 1 size <integer_cst  
800003fffddc05a0 64> unit size <integer_cst 800003fffddc05c0 8>
     align 64 context <function_decl 800003fffde9d700 foo>>
$5 = void
(gdb)

Haven't tested 32-bit yet.

There is one small unrelated issue that needs fixing:

gcc -g -O2   -I. -I../../src/gdb -I../../src/gdb/common -I../../src/ 
gdb/config -DLOCALEDIR="\"/opt/gnu64/share/locale\"" -DHAVE_CONFIG_H - 
I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../ 
src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/ 
gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber  - 
I../../src/gdb/gnulib/import -Ibuild-gnulib/import   -DTUI=1  -Wall - 
Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno- 
pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch - 
Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement  
-Wempty-body -Werror -c -o hppa-hpux-nat.o -MT hppa-hpux-nat.o -MMD - 
MP -MF .deps/hppa-hpux-nat.Tpo ../../src/gdb/hppa-hpux-nat.c
../../src/gdb/hppa-hpux-nat.c:45:1: error: no previous prototype for  
'hppa_hpux_save_state_offset' [-Werror=missing-prototypes]
cc1: all warnings being treated as errors

Believe the function should be static.

Dave
--
John David Anglin	dave.anglin@bell.net




  parent reply	other threads:[~2013-03-12  3:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 16:22 Pedro Alves
2013-03-08 22:56 ` Joel Brobecker
2013-03-11 15:30   ` Pedro Alves
2013-03-11 15:36     ` John David Anglin
2013-03-11 15:54       ` Pedro Alves
2013-03-12  3:10     ` John David Anglin [this message]
2013-03-13 18:47       ` Pedro Alves
2013-03-22 18:06         ` Pedro Alves
2013-03-13 18:47       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLU0-SMTP32C93B36114D0080E297C297E20@phx.gbl \
    --to=dave.anglin@bell.net \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox