Re: [PING][PING] Added x86_64 stub for debugging embedded systems running on Intel x86_64 processor architecture.

Simon Marchi
2020-10-20T13:09:30Z

On 2020-10-19 6:23 p.m., Battig, Caleb wrote:
> Simon,
>
> Thanks so much for looking into this. This is a significant addition to GDB that has the potential to help a lot of developers.
>
> I've made some formatting changes. See the attached patch. I'm not sure what you meant by your comment on whitespace and indentation, but I made all the other changes.
>
> Thanks,

For example, if a line is indented by 18 columns, that means you'll have
two tabs (worth 16 columns) followed by two spaces (for a total of 18
columns).

You can find the faulty lines using:

$ grep -E '^\t* ' x86_64-stub.c

Can you please send your patch using git-send-email? It's not
convenient to send in-line comments for a patch sent as attachment.

"if" blocks should be formatted like this:

if (something)
{
..
}

"if" blocks that contain a single line don't need braces. The exception
is if you ou have nested "if" blocks, the outer ones need to have
braces:

if (something)
printf ("Something");

but:

if (something)
{
if (something_else)
printf ("Something 1");
}
else
printf ("Something 2");

Thanks,

Simon