Simon, Thanks so much for looking into this. This is a significant addition to GDB that has the potential to help a lot of developers. I've made some formatting changes. See the attached patch. I'm not sure what you meant by your comment on whitespace and indentation, but I made all the other changes. Thanks, Caleb Battig Platform Software Engineer NetApp 724.741.5226 Direct Phone Caleb.Battig@netapp.com netapp.com [cid:5a931cc2-66e3-499f-8b2b-29088799aaeb] ________________________________ From: Simon Marchi Sent: Monday, October 19, 2020 9:45 AM To: Battig, Caleb ; gdb-patches@sourceware.org Cc: Lovett, Stuart ; Peikes, Wendy Subject: Re: [PING][PING] Added x86_64 stub for debugging embedded systems running on Intel x86_64 processor architecture. NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. On 2020-10-19 10:43 a.m., Battig, Caleb wrote: > Simon, > > Thanks for getting back to me! I resent the original message below. Please let me know if it still hasn't gone through. > > The use case of the new x86_64 stub is the same as the old x86 stub, except it works with newer 64-bit processors. See - > https://sourceware.org/gdb/onlinedocs/gdb/Remote-Stub.html (Notice that there is no 64-bit stub in the list of stubs provided by GDB.) > https://sourceware.org/gdb/onlinedocs/gdb/Debug-Session.html#Debug-Session > > Thanks and let me know if you have any further questions! Thanks. I've reached to other maintainers to know what our policy is today with these files, regarding licensing. The existing stubs have been contributed a loooong time ago, so it might have changed. I'll let you know. In the mean time, could you do your best to make the code adhere to our formatting conventions? What I spotted mostly: - Whitespaces: Indentation of 2 columns. Whole groups of 8 columns use a tab, and then spaces are used for the remainder. - "static" and the return type on their own line: static void foo (int bar) { ... } - Space before parenthesis in prototypes and calls. Basically, just look at other files, such as gdb/infrun.c, that will give you a good idea. Thanks, Simon