Simon,

Thanks for getting back to me. I am unfortunately unable to use 'gdb send-email' to send git patches. This is because my organization requires two factor authentication for Outlook (our email client) and I don't think Git Credential Manager can be setup with 2fa. For instance -

 Send this email? ([y]es|[n]o|[q]uit|[a]ll):   y
  5.7.3 Authentication unsuccessful [SA0PR11CA0047.namprd11.prod.outlook.com]

The GDB Contribution Checklist - https://sourceware.org/gdb/wiki/ContributionChecklist#Submitting_patches - says, "If using git send-email is not possible for you, you can still try to send it using your email client, pasting the output of git format-patch in the email body." So I have opted for this instead.

I have cleaned up all the whitespace coding standard violations. See the attachment.

Thanks,


Caleb Battig

Platform Software Engineer



NetApp

724.741.5226 Direct Phone

Caleb.Battig@netapp.com<mailto:Eugene.Novak@netapp.com>

netapp.com<http://www.netapp.com/us/>


[cid:1f8fcc99-6da2-4a8a-8f86-465d04044777]

________________________________
From: Simon Marchi <simark@simark.ca>
Sent: Tuesday, October 20, 2020 7:09 AM
To: Battig, Caleb <Caleb.Battig@netapp.com>; gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: Lovett, Stuart <Stuart.Lovett@netapp.com>; Peikes, Wendy <Wendy.Peikes@netapp.com>
Subject: Re: [PING][PING] Added x86_64 stub for debugging embedded systems running on Intel x86_64 processor architecture.

NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.




On 2020-10-19 6:23 p.m., Battig, Caleb wrote:
> Simon,
>
> Thanks so much for looking into this. This is a significant addition to GDB that has the potential to help a lot of developers.
>
> I've made some formatting changes. See the attached patch. I'm not sure what you meant by your comment on whitespace and indentation, but I made all the other changes.
>
> Thanks,

For example, if a line is indented by 18 columns, that means you'll have
two tabs (worth 16 columns) followed by two spaces (for a total of 18
columns).

You can find the faulty lines using:

    $ grep -E '^\t*        ' x86_64-stub.c

Can you please send your patch using git-send-email?  It's not
convenient to send in-line comments for a patch sent as attachment.

"if" blocks should be formatted like this:

  if (something)
    {
      ..
    }

"if" blocks that contain a single line don't need braces.  The exception
is if you ou have nested "if" blocks, the outer ones need to have
braces:

  if (something)
    printf ("Something");

but:

  if (something)
    {
      if (something_else)
        printf ("Something 1");
    }
  else
    printf ("Something 2");

Thanks,

Simon