From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25081 invoked by alias); 30 Jan 2005 15:32:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24958 invoked from network); 30 Jan 2005 15:32:46 -0000 Received: from unknown (HELO rwcrmhc11.comcast.net) (204.127.198.35) by sourceware.org with SMTP; 30 Jan 2005 15:32:46 -0000 Received: from [10.0.1.2] (h000393256f12.ne.client2.attbi.com[24.61.199.96]) by comcast.net (rwcrmhc11) with SMTP id <2005013015323201300lbl9ae>; Sun, 30 Jan 2005 15:32:45 +0000 User-Agent: Microsoft-Entourage/11.1.0.040913 Date: Sun, 30 Jan 2005 15:32:00 -0000 Subject: Re: [gdbserver/patch] Z packet support From: Paul Schlie To: Daniel Jacobowitz , Orjan Friberg CC: Message-ID: Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-SW-Source: 2005-01/txt/msg00304.txt.bz2 In the spirit of the present structure of the file, might it make more sense to actually add decode_Z_packet (... ) to remote-utils.c, along with possibly the thread stuff, and use it correspondingly in server.c, before it gets out of hand? And while at it, move CORE_ADDR tweak server.h to wherever it likely belongs? (and/or redefine it to void* if more appropriate)? /* FIXME: This should probably be autoconf'd for. It's an integer type at least the size of a (void *). */ typedef long long CORE_ADDR; And remove redundant declarations from server.h, and include required respective headers in server.c /* Functions from remote-utils.c */ void decode_M_packet (char *from, CORE_ADDR * mem_addr_ptr, unsigned int *len_ptr, char *to); ... /* Functions from ``signals.c''. */ ... ??? (although I know it's easier said than done?)