From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22685 invoked by alias); 4 Jan 2005 07:31:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22649 invoked from network); 4 Jan 2005 07:31:43 -0000 Received: from unknown (HELO rwcrmhc11.comcast.net) (204.127.198.35) by sourceware.org with SMTP; 4 Jan 2005 07:31:43 -0000 Received: from [10.0.1.2] (h000393256f12.ne.client2.attbi.com[24.61.199.96]) by comcast.net (rwcrmhc11) with SMTP id <2005010407314101300dd8j0e>; Tue, 4 Jan 2005 07:31:42 +0000 User-Agent: Microsoft-Entourage/11.1.0.040913 Date: Tue, 04 Jan 2005 07:31:00 -0000 Subject: Re: [RFA] initialize err variable in load_section_callback() From: Paul Schlie To: CC: "Theodore A. Roth" , Andrew Cagney Message-ID: Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-SW-Source: 2005-01/txt/msg00012.txt.bz2 Might Ted please be given authorization to check his October patch into both the 6.3 and head branches, as it fixes an uninitialized variable problem which has already been subsequently independently found with identical fixes proposed at least a few times since: http://sources.redhat.com/ml/gdb-patches/2004-10/msg00324.html (Although there appeared to be some discussion with Andrew on the subject, this fix should be considered the least fragile way to guarantee that the err variable declared within this function's scope is initialized, as it's likely too fragile to assume that all functions which may signal errors, explicitly also signal success [other than via the absents of an error, which typically necessitates the utilized shared signaling variable be initialized as being error-free]. Where then if there is a desire to check/refined all error signaling functions within GDB such that they both explicitly signal success and failure, and guarantee that at least one such function is always called to initialize otherwise un-initialized error variables prior to being tested, this may be done independently of this proposed simple less fragile quick fix.)