From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28279 invoked by alias); 18 Nov 2004 22:00:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27968 invoked from network); 18 Nov 2004 22:00:34 -0000 Received: from unknown (HELO sccrmhc13.comcast.net) (204.127.202.64) by sourceware.org with SMTP; 18 Nov 2004 22:00:34 -0000 Received: from [10.0.1.2] (h000393256f12.ne.client2.attbi.com[24.61.199.96]) by comcast.net (sccrmhc13) with SMTP id <2004111822003301600lhntae>; Thu, 18 Nov 2004 22:00:33 +0000 User-Agent: Microsoft-Entourage/11.1.0.040913 Date: Thu, 18 Nov 2004 22:00:00 -0000 Subject: Re: [patch - sort of] for 6.3 "int err;" not initialized in symfile.c/"load_section_callback (...)" From: Paul Schlie To: "Theodore A. Roth" CC: Message-ID: In-Reply-To: Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-SW-Source: 2004-11/txt/msg00385.txt.bz2 But as a minor follow up to your earlier note; I suspect "err" is best initialized here, as it seems prudent to assume that called functions may only signal errors; not necessary assert the absents of one. Just a thought, -paul- > From: "Theodore A. Roth" > > On Thu, 18 Nov 2004, Paul Schlie wrote: > >> Hi, sorry, not exactly a patch, but it might help someone keep their hair >> a little longer... >> >> In symfile.c within "load_section_callback (...)", "int err;" is not >> initialized and may not be set by "target_write_memory_partial (...)", >> so therefore may appear to fail, although all is well; which was a minor >> pain discovering. (causing an apparent failure when loading remote memory) > > I already brought this up a while back. Here's a link to the thread: > > http://sources.redhat.com/ml/gdb-patches/2004-10/msg00324.html > > --- > Ted Roth > PGP Key ID: 0x18F846E9 > Jabber ID: troth@jabber.org