From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7167 invoked by alias); 10 Jul 2019 15:44:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6991 invoked by uid 89); 10 Jul 2019 15:44:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30056.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 15:44:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iPQBnuHSH8xebC0Xy7E2BhmsDASUl/qyd6KhjM11kxU=; b=BeBSDFqiuiScDxwbIowxSyd9Go/kt32wcHlwOUg9nXhzEriyMDgkkH3hQn4OgtIO/9YBGtIhWGd1ytRPSA0sn0MIsLqt0+/L0tyyemMC+0jGoJB2gajsdie2xZJ6vfVtiqnaTnCnQkrQ4OZN9tabFtcoGjjedD5rh/VpGzYc/9U= Received: from DB6PR0802CA0034.eurprd08.prod.outlook.com (2603:10a6:4:a3::20) by VI1PR0801MB1854.eurprd08.prod.outlook.com (2603:10a6:800:5c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Wed, 10 Jul 2019 15:44:49 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::201) by DB6PR0802CA0034.outlook.office365.com (2603:10a6:4:a3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10 via Frontend Transport; Wed, 10 Jul 2019 15:44:49 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18 via Frontend Transport; Wed, 10 Jul 2019 15:44:46 +0000 Received: ("Tessian outbound 350ce6c32571:v24"); Wed, 10 Jul 2019 15:44:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 795a83b83dc649ea X-CR-MTA-TID: 64aa7808 Received: from 12ad96dd1a60.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.6.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id F400577F-8183-4DE3-8B92-297A1728A4C3.1; Wed, 10 Jul 2019 15:44:38 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 12ad96dd1a60.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Wed, 10 Jul 2019 15:44:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gnrkyd8dxqOHNn5naH2rLpg0XajQeZ+VZ/8sNszrMZBAEP4gRDEvimSyVWrsdKWK7U2ItybmgVPzlfHBUU5ikoT+qd2zxvGKBbf0o/uBwKvWS4Ig88FQLU20NQ2nTBiAiJpjebfDsQgPN4BS+EcbnvcC8339ghtMPoaaWnbObJ3EQsOkG2KdpNbrn2IzJAKsgpiulYhL4VvkzrfXQ7I0a3f+88xWnOQkKliHA6UVYam0khPYSQTxA9hYXcUR5lJtk4r04UlosfSqqMLR+dEU5y4O42dBzbWa5s3XBZTS9jPfLojR5lkhHeEsTQjGNMvF7wZ8/tjgEPp/Rk2BSFqocQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iPQBnuHSH8xebC0Xy7E2BhmsDASUl/qyd6KhjM11kxU=; b=bRE2k7v1dLE2xP6EjsPQ9GLGaKpv5oq3efMjb2VMl0H6absqlmSosGEn4MlMOdkKO8BJ6N6yDtQHisvbbXenjlW8zhDCw3j3PHeeVV699L3vmzDh73vgKga+PDQszgH2uyLWc79CuF2LAj/MEgA4EyXkIatzDmuFTIMRuJiducuzQWIiiLReFsEvakdy60M0VyTghfcG1OCBqd5493n2pScOMhKIPPn0tPiD2ZdA9o+Tc6OdCDar9GonnG4R4N4kyo92dN6nM2W6qyZOmK7qmcT7ywh74HTV0QiEMb/hBQ/TvrtkSsjqOmaYwxYWKk/Q8TMWTjNyPYhMW6JK1wI3og== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iPQBnuHSH8xebC0Xy7E2BhmsDASUl/qyd6KhjM11kxU=; b=BeBSDFqiuiScDxwbIowxSyd9Go/kt32wcHlwOUg9nXhzEriyMDgkkH3hQn4OgtIO/9YBGtIhWGd1ytRPSA0sn0MIsLqt0+/L0tyyemMC+0jGoJB2gajsdie2xZJ6vfVtiqnaTnCnQkrQ4OZN9tabFtcoGjjedD5rh/VpGzYc/9U= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2536.eurprd08.prod.outlook.com (10.172.252.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Wed, 10 Jul 2019 15:44:37 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::259b:8edf:fb65:2760]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::259b:8edf:fb65:2760%8]) with mapi id 15.20.2052.020; Wed, 10 Jul 2019 15:44:37 +0000 From: Alan Hayward To: Simon Marchi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 6/7] Arm: Use read_description funcs in gdbserver Date: Wed, 10 Jul 2019 15:44:00 -0000 Message-ID: References: <20190705094525.51536-1-alan.hayward@arm.com> <20190705094525.51536-7-alan.hayward@arm.com> <3b3d8fc5-24ae-a8a5-08ff-c5a776929284@simark.ca> In-Reply-To: <3b3d8fc5-24ae-a8a5-08ff-c5a776929284@simark.ca> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2536; X-MS-Exchange-PUrlCount: 1 x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(199004)(189003)(6512007)(6306002)(5660300002)(50226002)(6246003)(7736002)(81156014)(57306001)(81166006)(8936002)(8676002)(305945005)(68736007)(11346002)(476003)(486006)(446003)(316002)(4326008)(54906003)(86362001)(36756003)(256004)(76176011)(2616005)(186003)(6916009)(102836004)(53546011)(26005)(6506007)(478600001)(14454004)(33656002)(66446008)(64756008)(66066001)(91956017)(66476007)(76116006)(71200400001)(71190400001)(6486002)(66946007)(25786009)(3846002)(6116002)(53936002)(99286004)(229853002)(2906002)(66556008)(6436002)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2536;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: oVxtt+VXo+gB15Rus5FEMf9acldoYAlxOlnBlEzcJiOX8YPu2OVWChmJPQNnmZDrsDAgVSgYtIGdC9giQRUyXcMSbaExkbGJyZdUuWqMARymz8+rAuELKcPq2BhJ3KtSdw2NgIp/mLxqOOD+SQAFjGh8icnZtRQeTwZhp+lnLTKAZMtnaPn9Qr0+iOIiVkMxNe/XH101lLqRqLt3W7O93f/Nm77+k1LHkzCDH5DAil/qshOZp+5WNiQQQGyVvK76BTOWGZeoT8/1svldkc8ZI01I2erpj7Xh0K6ZZu9MPtHTDT1NL3eHq5DTiD/dUD+ffuwH6lB6EQNxssHzR/CYAVM9VUydPvpxBL6L53UvMOkMQ7r1evrO1p7Stey9SJW3TeLqmgnukKpJJ/EsuYMGK2AK86H5bPKoIzgrCWW1TRI= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7925c284-b78a-485f-7f81-08d7054d83b1 X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00257.txt.bz2 DQoNCj4gT24gMTAgSnVsIDIwMTksIGF0IDA1OjA0LCBTaW1vbiBNYXJjaGkg PHNpbWFya0BzaW1hcmsuY2E+IHdyb3RlOg0KPiANCj4+IGRpZmYgLS1naXQg YS9nZGIvZ2Ric2VydmVyL2xpbnV4LWFhcmNoMzItdGRlc2MuYyBiL2dkYi9n ZGJzZXJ2ZXIvbGludXgtYWFyY2gzMi10ZGVzYy5jDQo+PiBuZXcgZmlsZSBt b2RlIDEwMDY0NA0KPj4gaW5kZXggMDAwMDAwMDAwMC4uNmYwZThjOWFhOQ0K Pj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIvZ2RiL2dkYnNlcnZlci9saW51 eC1hYXJjaDMyLXRkZXNjLmMNCj4+IEBAIC0wLDAgKzEsNDYgQEANCj4+ICsv KiBDb3B5cmlnaHQgKEMpIDIwMTkgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u LCBJbmMuDQo+PiArDQo+PiArICAgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR0RC Lg0KPj4gKw0KPj4gKyAgIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJl OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+PiAr ICAgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkNCj4+ICsgICB0aGUgRnJlZSBT b2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBM aWNlbnNlLCBvcg0KPj4gKyAgIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVy IHZlcnNpb24uDQo+PiArDQo+PiArICAgVGhpcyBwcm9ncmFtIGlzIGRpc3Ry aWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQo+ PiArICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4g dGhlIGltcGxpZWQgd2FycmFudHkgb2YNCj4+ICsgICBNRVJDSEFOVEFCSUxJ VFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUg dGhlDQo+PiArICAgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1v cmUgZGV0YWlscy4NCj4+ICsNCj4+ICsgICBZb3Ugc2hvdWxkIGhhdmUgcmVj ZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z ZQ0KPj4gKyAgIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90LCBz ZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LiAgKi8NCj4+ICsN Cj4+ICsjaW5jbHVkZSAic2VydmVyLmgiDQo+PiArI2luY2x1ZGUgInRkZXNj LmgiDQo+PiArI2luY2x1ZGUgImFyY2gvYWFyY2gzMi5oIg0KPj4gKyNpbmNs dWRlIDxpbnR0eXBlcy5oPg0KPj4gKw0KPj4gK3N0cnVjdCB0YXJnZXRfZGVz YyAqdGRlc2NfYWFyY2gzMjsNCj4gDQo+IHN0YXRpYw0KDQpEb25lLg0KDQo+ IA0KPj4gZGlmZiAtLWdpdCBhL2dkYi9nZGJzZXJ2ZXIvbGludXgtYXJtLXRk ZXNjLmMgYi9nZGIvZ2Ric2VydmVyL2xpbnV4LWFybS10ZGVzYy5jDQo+PiBu ZXcgZmlsZSBtb2RlIDEwMDY0NA0KPj4gaW5kZXggMDAwMDAwMDAwMC4uZmE1 NGU0ODU5Mg0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIvZ2RiL2dkYnNl cnZlci9saW51eC1hcm0tdGRlc2MuYw0KPj4gQEAgLTAsMCArMSw2MiBAQA0K Pj4gKy8qIENvcHlyaWdodCAoQykgMjAxOSBGcmVlIFNvZnR3YXJlIEZvdW5k YXRpb24sIEluYy4NCj4+ICsNCj4+ICsgICBUaGlzIGZpbGUgaXMgcGFydCBv ZiBHREIuDQo+PiArDQo+PiArICAgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29m dHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkN Cj4+ICsgICBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPj4gKyAgIHRoZSBG cmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2Yg dGhlIExpY2Vuc2UsIG9yDQo+PiArICAgKGF0IHlvdXIgb3B0aW9uKSBhbnkg bGF0ZXIgdmVyc2lvbi4NCj4+ICsNCj4+ICsgICBUaGlzIHByb2dyYW0gaXMg ZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1 bCwNCj4+ICsgICBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQg ZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0KPj4gKyAgIE1FUkNIQU5U QUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4g IFNlZSB0aGUNCj4+ICsgICBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBm b3IgbW9yZSBkZXRhaWxzLg0KPj4gKw0KPj4gKyAgIFlvdSBzaG91bGQgaGF2 ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBM aWNlbnNlDQo+PiArICAgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBu b3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLw0K Pj4gKw0KPj4gKyNpbmNsdWRlICJzZXJ2ZXIuaCINCj4+ICsjaW5jbHVkZSAi dGRlc2MuaCINCj4+ICsjaW5jbHVkZSAiYXJjaC9hcm0uaCINCj4+ICsjaW5j bHVkZSA8aW50dHlwZXMuaD4NCj4+ICsNCj4+ICsvKiBBbGwgcG9zc2libGUg QXJtIHRhcmdldCBkZXNjcmlwdG9ycy4gICovDQo+PiArc3RydWN0IHRhcmdl dF9kZXNjICp0ZGVzY19hcm1fbGlzdFtBUk1fRlBfVFlQRV9JTlZBTElEXTsN Cj4gDQo+IHN0YXRpYw0KDQpEb25lLg0KDQo+IA0KPj4gKw0KPj4gKy8qIFNl ZSBsaW51eC1hcm0tdGRlc2MuaC4gICovDQo+PiArDQo+PiArY29uc3QgdGFy Z2V0X2Rlc2MgKg0KPj4gK2FybV9saW51eF9yZWFkX2Rlc2NyaXB0aW9uIChh cm1fZnBfdHlwZSBmcF90eXBlKQ0KPj4gK3sNCj4+ICsgIHN0cnVjdCB0YXJn ZXRfZGVzYyAqdGRlc2MgPSB0ZGVzY19hcm1fbGlzdFtmcF90eXBlXTsNCj4+ ICsNCj4+ICsgIGlmICh0ZGVzYyA9PSBudWxscHRyKQ0KPj4gKyAgICB7DQo+ PiArICAgICAgdGRlc2MgPSBhcm1fY3JlYXRlX3RhcmdldF9kZXNjcmlwdGlv biAoZnBfdHlwZSk7DQo+PiArDQo+PiArICAgICAgc3RhdGljIGNvbnN0IGNo YXIgKmV4cGVkaXRlX3JlZ3NbXSA9IHsgInIxMSIsICJzcCIsICJwYyIsIDAg fTsNCj4+ICsgICAgICBpbml0X3RhcmdldF9kZXNjICh0ZGVzYywgZXhwZWRp dGVfcmVncyk7DQo+PiArDQo+PiArICAgICAgdGRlc2NfYXJtX2xpc3RbZnBf dHlwZV0gPSB0ZGVzYzsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgcmV0dXJu IHRkZXNjOw0KPj4gK30NCj4+ICsNCj4+ICsvKiBTZWUgbGludXgtYXJtLXRk ZXNjLmguICAqLw0KPj4gKw0KPj4gK2FybV9mcF90eXBlIGFybV9saW51eF9n ZXRfdGRlc2NfZnBfdHlwZSAoY29uc3QgdGFyZ2V0X2Rlc2MgKnRkZXNjKQ0K PiANCj4gUmV0dXJuIHR5cGUgb24gaXRzIG93biBsaW5lLg0KDQpEb25lLg0K DQo+IA0KPj4gK3sNCj4+ICsgIGlmICh0ZGVzYyA9PSBudWxscHRyKQ0KPj4g KyAgICByZXR1cm4gQVJNX0ZQX1RZUEVfSU5WQUxJRDsNCj4gDQo+IENhbiB0 aGlzICh0ZGVzYyA9PSBudWxscHRyKSBhY3R1YWxseSBoYXBwZW4/ICBJZiB5 b3UgZXhwZWN0IGl0J3Mgbm90IHBvc3NpYmxlLA0KPiBkb24ndCBoZXNpdGF0 ZSB0byB1c2UgYSBnZGJfYXNzZXJ0IGluc3RlYWQuICBJdCBoZWxwcyBjYXRj aCBidWdzIGFuZCBhY3RzIGFzDQo+IHNvbWUga2luZCBvZiBzZWxmLWRvY3Vt ZW50YXRpb24gb2YgdGhlIGFsbG93ZWQgdmFsdWVzLg0KDQpJdCB3b3VsZCBt ZWFuIHRoYXQgcmVnY2FjaGUtPnRkZXNjIHdhcyBudWxsLCB3aGljaCBhcyBm YXIgYXMgSSBjYW4gdGVsbCBpcyBub3QNCnBvc3NpYmxlLiBUaGVyZSBhcmUg bm8gZmFpbHMgd2hlbiB0ZXN0aW5nIGVpdGhlci4NCknigJlsbCBzd2l0Y2gg dG8gZ2RiX2Fzc2VydC4NCg0KPiANCj4+ICsNCj4+ICsgIC8qIE1hbnkgb2Yg dGhlIHRkZXNjX2FybV9saXN0IGVudHJpZXMgbWF5IG5vdCBoYXZlIGJlZW4g aW5pdGlhbGlzZWQgeWV0LiAgVGhpcw0KPj4gKyAgICAgaXMgb2ssIGJlY2F1 c2UgdGRlc2MgbXVzdCBiZSBvbmUgb2YgdGhlIGluaXRpYWxpc2VkIG9uZXMu ICAqLw0KPj4gKyAgZm9yIChpbnQgaSA9IEFSTV9GUF9UWVBFX1ZGUFYyOyBp IDwgQVJNX0ZQX1RZUEVfSU5WQUxJRDsgaSsrKQ0KPiANCj4gSXMgaXQgaW50 ZW5kZWQgaGVyZSB0aGF0IHlvdSBza2lwIEFSTV9GUF9UWVBFX05PTkU/ICBX aHk/DQoNCk15IG1pc3Rha2UuIEFuIGVhcmxpZXIgdmVyc2lvbiBkaWRu4oCZ dCBoYXZlIEFSTV9GUF9UWVBFX05PTkUsIGFuZCBJIG1pc3NlZCB0aGlzLg0K Rml4ZWQgdG8gc3RhcnQgd2l0aCBBUk1fRlBfVFlQRV9OT05FLg0KDQoNCj4g DQo+IFNpbW9uDQo+IA0KDQo= >From gdb-patches-return-157430-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jul 10 15:49:11 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 88338 invoked by alias); 10 Jul 2019 15:49:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 88323 invoked by uid 89); 10 Jul 2019 15:49:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 15:49:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 93924561E0; Wed, 10 Jul 2019 11:39:51 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NUG2vGsIlahr; Wed, 10 Jul 2019 11:39:51 -0400 (EDT) Received: from murgatroyd.Home (97-122-178-82.hlrn.qwest.net [97.122.178.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 3F9E156128; Wed, 10 Jul 2019 11:39:51 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 5/9] Change spu-tdep.c to use type-safe registry Date: Wed, 10 Jul 2019 15:49:00 -0000 Message-Id: <20190710153947.25721-6-tromey@adacore.com> In-Reply-To: <20190710153947.25721-1-tromey@adacore.com> References: <20190710153947.25721-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-07/txt/msg00258.txt.bz2 Content-length: 2293 This changes spu-tdep.c to use the type-safe registry. gdb/ChangeLog 2019-07-10 Tom Tromey * spu-tdep.c (spu_overlay_data): Change type. (spu_get_overlay_table, spu_overlay_new_objfile) (_initialize_spu_tdep): Update. --- gdb/ChangeLog | 6 ++++++ gdb/spu-tdep.c | 12 ++++++------ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c index a2ac3149d4d..69ffb69fcb9 100644 --- a/gdb/spu-tdep.c +++ b/gdb/spu-tdep.c @@ -1767,14 +1767,15 @@ gdb_print_insn_spu (bfd_vma memaddr, struct disassemble_info *info) a target address. The overlay section is mapped iff the target integer at this location equals MAPPED_VAL. */ -static const struct objfile_data *spu_overlay_data; - struct spu_overlay_table { CORE_ADDR mapped_ptr; CORE_ADDR mapped_val; }; +static objfile_key> spu_overlay_data; + /* Retrieve the overlay table for OBJFILE. If not already cached, read the _ovly_table data structure from the target and initialize the spu_overlay_table data structure from it. */ @@ -1791,7 +1792,7 @@ spu_get_overlay_table (struct objfile *objfile) gdb_byte *ovly_table; int i; - tbl = (struct spu_overlay_table *) objfile_data (objfile, spu_overlay_data); + tbl = spu_overlay_data.get (objfile); if (tbl) return tbl; @@ -1843,7 +1844,7 @@ spu_get_overlay_table (struct objfile *objfile) } xfree (ovly_table); - set_objfile_data (objfile, spu_overlay_data, tbl); + spu_overlay_data.set (objfile, tbl); return tbl; } @@ -1901,7 +1902,7 @@ spu_overlay_new_objfile (struct objfile *objfile) struct obj_section *osect; /* If we've already touched this file, do nothing. */ - if (!objfile || objfile_data (objfile, spu_overlay_data) != NULL) + if (!objfile || spu_overlay_data.get (objfile) != NULL) return; /* Consider only SPU objfiles. */ @@ -2765,7 +2766,6 @@ _initialize_spu_tdep (void) /* Add ourselves to objfile event chain. */ gdb::observers::new_objfile.attach (spu_overlay_new_objfile); - spu_overlay_data = register_objfile_data (); /* Install spu stop-on-load handler. */ gdb::observers::new_objfile.attach (spu_catch_start); -- 2.20.1