From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id n6OsL5/5hmAZagAAWB0awg (envelope-from ) for ; Mon, 26 Apr 2021 13:34:23 -0400 Received: by simark.ca (Postfix, from userid 112) id B3AEB1F11E; Mon, 26 Apr 2021 13:34:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 15E871EE14 for ; Mon, 26 Apr 2021 13:34:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BDD9B394FC26; Mon, 26 Apr 2021 17:34:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BDD9B394FC26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619458462; bh=q4fSv43aEXrtR3H1wzPCQJw4ABQ4G5DTuXqvVaCYrIU=; h=Subject:In-Reply-To:Date:References:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=h1DMH8Pm1L/mIWbI8tTNWQCjSHxlSI2G1DonK8iUuTEKDE9mULHVkBM5sa31uucSr qwqZKAyfxavKgB9Afzni553nF5+HyaAILgOswiQww7StvehCSzMq3hzmVjZbLVr8na KJgWNoLVFaJRWWyhgNUw3DA/QRqbj8FSYbetea9w= Received: from resqmta-ch2-12v.sys.comcast.net (resqmta-ch2-12v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:44]) by sourceware.org (Postfix) with ESMTPS id 2353138930D0 for ; Mon, 26 Apr 2021 17:34:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2353138930D0 Received: from resomta-ch2-18v.sys.comcast.net ([69.252.207.114]) by resqmta-ch2-12v.sys.comcast.net with ESMTP id b0ltlh8HHp8dBb57jl3NN4; Mon, 26 Apr 2021 17:34:19 +0000 Received: from pkoning.akdesign.com ([73.60.223.101]) by resomta-ch2-18v.sys.comcast.net with ESMTPSA id b57Zlf94obYxWb57hlrKKG; Mon, 26 Apr 2021 17:34:19 +0000 X-Xfinity-VAAS: gggruggvucftvghtrhhoucdtuddrgeduledrvddukedgudduiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucevohhmtggrshhtqdftvghsihdpqfgfvfdppffquffrtefokffrnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpefrrghulhcumfhonhhinhhguceophgruhhlkhhonhhinhhgsegtohhmtggrshhtrdhnvghtqeenucggtffrrghtthgvrhhnpedvtdevjeeuhefhiedvteffjeeuffehkefgudeutdevffefkeeijeelfeevuefhgeenucfkphepjeefrdeitddrvddvfedruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehpkhhonhhinhhgrdgrkhguvghsihhgnhdrtghomhdpihhnvghtpeejfedriedtrddvvdefrddutddupdhmrghilhhfrhhomhepphgruhhlkhhonhhinhhgsegtohhmtggrshhtrdhnvghtpdhrtghpthhtohepshhimhhonhdrmhgrrhgthhhisehpohhlhihmthhlrdgtrgdprhgtphhtthhopehguggsqdhprghttghhvghssehsohhurhgtvgifrghrvgdrohhrgh X-Xfinity-VMeta: sc=-100.00;st=legit Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: Proposal: format GDB Python files with black In-Reply-To: Date: Mon, 26 Apr 2021 13:34:06 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Simon Marchi X-Mailer: Apple Mail (2.3445.104.17) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Paul Koning via Gdb-patches Reply-To: Paul Koning Cc: "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > On Apr 26, 2021, at 11:55 AM, Simon Marchi via Gdb-patches = wrote: >=20 > Hi all, >=20 > A few people I talked to about this and I have good experience with = the > tool black to auto-format Python code. It is simple to use, fast and > reliable (if it detects that it changed the meaning of the program by > mistake, internal-errors out). I don't think I need to spell out the > advantage of using such a tool, but just in case: it removes all the > overhead of thinking about formatting when writing or reviewing code. In the case of Python, formatting is a core part of writing the code. = Apart from that, I don't see much need for this, what with Emacs editing = mechanisms. I looked at the sample you mentioned. It's reasonable enough except for = the bizarre way of formatting a long parenthesized condition in an if = statement (near the start of FrameDecorator.py). So while I can't see = any reason to use this, it seems ok as a tool that others might use if = they like to do so. I would object to having this mandatory. paul