From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12146 invoked by alias); 21 Apr 2011 08:12:14 -0000 Received: (qmail 12111 invoked by uid 22791); 21 Apr 2011 08:12:05 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Apr 2011 08:11:49 +0000 Received: by vws4 with SMTP id 4so1562022vws.0 for ; Thu, 21 Apr 2011 01:11:49 -0700 (PDT) Received: by 10.52.74.99 with SMTP id s3mr163402vdv.108.1303373509076; Thu, 21 Apr 2011 01:11:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.61.6 with HTTP; Thu, 21 Apr 2011 01:11:29 -0700 (PDT) In-Reply-To: References: From: Kevin Pouget Date: Thu, 21 Apr 2011 08:12:00 -0000 Message-ID: Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00381.txt.bz2 > You should usually do full regression tests for a patch. =A0That is, run > before and after, and compare. > > You can run just a single directory like: > > =A0make check RUNTESTFLAGS=3D--directory=3Dgdb.base right, that's okay. > Kevin> =A0 =A0ALL_BREAKPOINTS (b) > Kevin> - =A0 =A0others +=3D breakpoint_has_pc (b, pspace, pc, section); > Kevin> + =A0 =A0others +=3D breakpoint_has_pc (b, pspace, pc, section) > Kevin> + =A0 =A0 =A0&& b->number >=3D 0; > > You need parens around the RHS here and more indentation on the second > line. fixed Thanks, Kevin (still waiting to receive the copyright papers mailed by the FSF) -- diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 2352191..be383f2 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b, return 0; } -/* Print a message describing any breakpoints set at PC. This +/* Print a message describing any user-breakpoints set at PC. This concerns with logical breakpoints, so we match program spaces, not address spaces. */ @@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch, struct breakpoint *b; ALL_BREAKPOINTS (b) - others +=3D breakpoint_has_pc (b, pspace, pc, section); + others +=3D (breakpoint_has_pc (b, pspace, pc, section) + && b->number >=3D 0); if (others > 0) { if (others =3D=3D 1) @@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch, else /* if (others =3D=3D ???) */ printf_filtered (_("Note: breakpoints ")); ALL_BREAKPOINTS (b) - if (breakpoint_has_pc (b, pspace, pc, section)) + if (breakpoint_has_pc (b, pspace, pc, section) && b->number >=3D 0) { others--; printf_filtered ("%d", b->number); --