From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22607 invoked by alias); 12 Jun 2011 14:02:02 -0000 Received: (qmail 22599 invoked by uid 22791); 12 Jun 2011 14:02:01 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_40,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Jun 2011 14:01:47 +0000 Received: by vws4 with SMTP id 4so4099160vws.0 for ; Sun, 12 Jun 2011 07:01:47 -0700 (PDT) Received: by 10.52.115.163 with SMTP id jp3mr1116189vdb.187.1307887307132; Sun, 12 Jun 2011 07:01:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.156.138 with HTTP; Sun, 12 Jun 2011 07:01:07 -0700 (PDT) From: Hui Zhu Date: Sun, 12 Jun 2011 14:02:00 -0000 Message-ID: Subject: [RFA] tracepoint remote.c:remote_trace_set_readonly_regions give up some regions if it is number is too big To: gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00151.txt.bz2 Hi, My GDB got crash with a ELF file when I use tracepoint with it. I found that it have 12898 sections. So in remote_trace_set_readonly_regions: sprintf (target_buf + strlen (target_buf), ":%s,%s", tmp1, tmp2); It will over write other val, it make GDB crash. So I add a check before it to fix it: if (strlen (target_buf) + strlen(tmp1) + strlen(tmp2) + 3 > target_buf_size) { warning (_("Give up some read only regions.")); break; } Please help me review it. And this issue affect 7.3 too. Does it can check in to 7.3? Thanks, Hui 2011-06-12 Hui Zhu * remote.c (remote_trace_set_readonly_regions): Add a check for target_buf_size. --- remote.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/remote.c +++ b/remote.c @@ -9996,6 +9996,11 @@ remote_trace_set_readonly_regions (void) size = bfd_get_section_size (s); sprintf_vma (tmp1, vma); sprintf_vma (tmp2, vma + size); + if (strlen (target_buf) + strlen(tmp1) + strlen(tmp2) + 3 > target_buf_size) + { + warning (_("Give up some read only regions.")); + break; + } sprintf (target_buf + strlen (target_buf), ":%s,%s", tmp1, tmp2); }