Re: [PATCH] arm reversible : <phase_2_complete>

oza Pawandeep
2011-12-04T08:26:26Z

Hi Yao and Tom,

please have a look at sample changlog below.
let me know whether this much detailed explanation is sufficient ?

2011-12-03 Oza Pawandeep <oza.pawandeep@gmail.com>

* arm-linux-tdep.c: arm_linux_init_abi modified to include
arm reversible debugging feature.
registered arm_process_record to gdb_arch
syscall pointer initialization.

* arm-tdep.c: arm-reversible-debugging implementation.
newly added functions are as follows.

> arm_process_record: handles basic initialization and record
summarisation, decodes basic insn ids, on which it hands over
controls to decode_insn.
> deallocate_reg_mem : clean up function
> decode_insn: Decodes arm/thumb insn and calls appropriate
decoding routine to record the change.
> thumb_record_branch: branch insn reording (thumb)
> thumb_record_ldm_stm_swi: load, store and sycall insn
recoding (thumb)
> thumb_record_misc: misc insn recording (thumb)
> thumb_record_ld_st_stack: store and stack insn recording (thumb)
> thumb_record_ld_st_imm_offset: load, store with immediate offset
insn recording (thumb)
> thumb_record_ld_st_reg_offset: load, store with register offset
recording (thumb)
> thumb_record_add_sub_cmp_mov: addition, subtractation, compare
and move insn recording (thumb)
> thumb_record_shift_add_sub: shift, add and sub insn recording
(thumb)
> arm_record_coproc_data_proc: coprocessor and data processing
recording (partially implemented) (arm)
> arm_record_coproc: coprocessor insn recording
(partially implemented) (arm)
> arm_record_b_bl: branch insn recording (arm)
> arm_record_ld_st_multiple: load and store multiple insn recording
(arm)
> arm_record_ld_st_reg_offset: load and store reg offset recording
(arm)
> arm_record_ld_st_imm_offset: load and store immediate offset
recording (arm)
> arm_record_data_proc_imm: data processing insn recording (arm)
> arm_record_data_proc_misc_ld_str: data processing, misc, load and
store insn recording (arm)
> arm_record_extension_space:arm extension space insn recording
(arm)
> arm_record_strx: str(X) type insn recording (arm)
> sbo_sbz: checks for mendatory sbo and sbz fields in insn,

added new data structures:
> insn_decode_record_t: local record structure which contains insn's
record, which includes both reg and memory.

REG_ALLOC and MEM_ALLOC macros takes care of actual memory allocation
in local record which is finally processed by arm_rocess_record.

* arm-tdep.h: arm-reversible data structures

> modified gdbarch_tdep: added member (function pointer) arm_swi_record
which is supposed to be recording system calls
> arm_process_record externed.

Regards,
Oza.
On Sun, Dec 4, 2011 at 7:16 AM, Yao Qi <yao@codesourcery.com> wrote:
> On 12/04/2011 03:01 AM, oza Pawandeep wrote:
>> diff -urN arm_orig/ChangeLog arm_new/ChangeLog
>> --- arm_orig/ChangeLog        2011-12-03 18:05:04.000000000 +0530
>> +++ arm_new/ChangeLog 2011-12-03 19:48:56.000000000 +0530
>> @@ -1,3 +1,9 @@
>> +2011-12-03  Oza Pawandeep   <oza.pawandeep@gmail.com>
>> +
>> +     * arm-linux-tdep.c: Added arm-reversible and process record
>> +     * arm-tdep.c: arm-reversible-debugging implementation
>> +     * arm-tdep.h: arm-reversible data structures
>> +
>
> ChangeLog like this is not accurate to reflect your changes.  "Add
> reverse debugging and process record for ARM" is sort of summary of your
> patch, but in ChangeLog, we usually need more details on function level.
>
> Please read other ChangeLog entries in ChangeLog, and see how it is
> written.  Or, you can read this
>
> http://www.gnu.org/prep/standards/standards.html#Change-Logs
>
> --
> Yao (齐尧)