Re: [PATCH] arm reversible : <phase_2_complete>

Petr Hluzín
2011-11-05T17:36:09Z

On 3 November 2011 18:40, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Oza" == oza Pawandeep <oza.pawandeep@gmail.com> writes:
> I read the whole thread and I think at this point there are still some
> unaddressed comments.  If I am incorrect, could you point me to the most
> up-to-date version of the patch?  Then I will review it.  Otherwise I
> will wait for your next mail.  Thanks.

The most recent version of Oza's patch is at [1], my review is at [2].
Oza fixed all issues. (I do not check whitespace, though.) Oza removed
the assertions as you asked, however I believe they should have stayed
(as I explained in mail few minutes ago and in [3]).

However Oza improved ARM extension space insn support which introduced
some bugs - I think, I have no feedback from Oza whether I
misunderstood the code.

[1] http://sourceware.org/ml/gdb-patches/2011-10/msg00613.html
[2] http://sourceware.org/ml/gdb-patches/2011-10/msg00617.html
[3] http://sourceware.org/ml/gdb-patches/2011-10/msg00449.html

--
Petr Hluzin