From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17835 invoked by alias); 21 Apr 2011 09:34:42 -0000 Received: (qmail 17735 invoked by uid 22791); 21 Apr 2011 09:34:40 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Apr 2011 09:34:27 +0000 Received: by vxk20 with SMTP id 20so1513155vxk.0 for ; Thu, 21 Apr 2011 02:34:26 -0700 (PDT) Received: by 10.52.74.99 with SMTP id s3mr266693vdv.108.1303378466391; Thu, 21 Apr 2011 02:34:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.61.6 with HTTP; Thu, 21 Apr 2011 02:34:06 -0700 (PDT) In-Reply-To: References: <201104210949.18831.pedro@codesourcery.com> From: Kevin Pouget Date: Thu, 21 Apr 2011 09:34:00 -0000 Message-ID: Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs To: Pedro Alves , Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00387.txt.bz2 wait, sorry, I didn't send the updated version of the patch 2011-04-20 Kevin Pouget * breakpoint.c (describe_other_breakpoints): Do not write 'duplicate' note if the breakpoint is internal. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 2352191..eeec497 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b, return 0; } -/* Print a message describing any breakpoints set at PC. This +/* Print a message describing any user-breakpoints set at PC. This concerns with logical breakpoints, so we match program spaces, not address spaces. */ @@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch, struct breakpoint *b; ALL_BREAKPOINTS (b) - others +=3D breakpoint_has_pc (b, pspace, pc, section); + others +=3D (breakpoint_has_pc (b, pspace, pc, section) + && b->number > 0); if (others > 0) { if (others =3D=3D 1) @@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch, else /* if (others =3D=3D ???) */ printf_filtered (_("Note: breakpoints ")); ALL_BREAKPOINTS (b) - if (breakpoint_has_pc (b, pspace, pc, section)) + if (breakpoint_has_pc (b, pspace, pc, section) && b->number > 0) { others--; printf_filtered ("%d", b->number); On Thu, Apr 21, 2011 at 5:24 AM, Kevin Pouget wrot= e: > On Thu, Apr 21, 2011 at 4:49 AM, Pedro Alves wro= te: >> On Thursday 21 April 2011 09:11:29, Kevin Pouget wrote: >>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 && b->number >=3D 0); >> >> Can you make those b->number > 0? =A0 `0' is used for >> momentary breakpoints, which aren't user visible either. >> >> (as principle, please re-paste the changelog when posting >> an updated patch, so we don't have go fish which patch >> goes with which changelog. =A0It's practicaly 0 work to re-paste >> it, but it's not 0 work to look for it.) > > sure, that's two points I was hesitating about; here is the new version: > > 2011-04-20 =A0Kevin Pouget > =A0 =A0 =A0 * breakpoint.c (describe_other_breakpoints): Do not write 'du= plicate' > =A0 =A0 =A0 note if the breakpoint is internal.