From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81342-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31266 invoked by alias); 27 May 2011 18:37:44 -0000
Received: (qmail 31255 invoked by uid 22791); 27 May 2011 18:37:44 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_RG
X-Spam-Check-By: sourceware.org
Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 18:37:30 +0000
Received: by fxm18 with SMTP id 18so1821269fxm.0        for <gdb-patches@sourceware.org>; Fri, 27 May 2011 11:37:29 -0700 (PDT)
Received: by 10.223.33.80 with SMTP id g16mr2716682fad.125.1306521449083; Fri, 27 May 2011 11:37:29 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.74.139 with HTTP; Fri, 27 May 2011 11:37:09 -0700 (PDT)
In-Reply-To: <m3boyovxws.fsf@fleche.redhat.com>
References: <1306440200-25087-1-git-send-email-vapier__8251.52545371584$1306440225$gmane$org@gentoo.org> <m3boyovxws.fsf@fleche.redhat.com>
From: Mike Frysinger <vapier@gentoo.org>
Date: Fri, 27 May 2011 18:37:00 -0000
Message-ID: <BANLkTimpt9ok8_0sJ_+h6a3f8wwyfKK5eg@mail.gmail.com>
Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot
To: Tom Tromey <tromey@redhat.com>
Cc: toolchain-devel@blackfin.uclinux.org, gdb-patches@sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00653.txt.bz2

On Fri, May 27, 2011 at 13:46, Tom Tromey wrote:
> Mike> + =C2=A0strcat (arg_buf, gdb_sysroot);
>
> It seems like this will give wrong results if the sysroot needs quoting.
> But, this problem could affect other arguments here.
> Offhand it seems like it would be better if this code directly built
> sim_argv rather than building a string and converting it, but I don't
> know if any odd issue is lurking.

i thought of that, but since as you say other parts have the same
issue, and i couldnt find a helper func that would sanely take care of
things, i didnt bother
-mike