From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25805 invoked by alias); 21 Apr 2011 09:25:06 -0000 Received: (qmail 25790 invoked by uid 22791); 21 Apr 2011 09:25:05 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Apr 2011 09:24:49 +0000 Received: by vws4 with SMTP id 4so1591721vws.0 for ; Thu, 21 Apr 2011 02:24:49 -0700 (PDT) Received: by 10.220.98.79 with SMTP id p15mr2574720vcn.23.1303377889055; Thu, 21 Apr 2011 02:24:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.61.6 with HTTP; Thu, 21 Apr 2011 02:24:29 -0700 (PDT) In-Reply-To: <201104210949.18831.pedro@codesourcery.com> References: <201104210949.18831.pedro@codesourcery.com> From: Kevin Pouget Date: Thu, 21 Apr 2011 09:25:00 -0000 Message-ID: Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs To: Pedro Alves , Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00385.txt.bz2 On Thu, Apr 21, 2011 at 4:49 AM, Pedro Alves wrote: > On Thursday 21 April 2011 09:11:29, Kevin Pouget wrote: >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 && b->number >=3D 0); > > Can you make those b->number > 0? =A0 `0' is used for > momentary breakpoints, which aren't user visible either. > > (as principle, please re-paste the changelog when posting > an updated patch, so we don't have go fish which patch > goes with which changelog. =A0It's practicaly 0 work to re-paste > it, but it's not 0 work to look for it.) sure, that's two points I was hesitating about; here is the new version: 2011-04-20 Kevin Pouget * breakpoint.c (describe_other_breakpoints): Do not write 'duplicate' note if the breakpoint is internal. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 2352191..ea2f334 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b, return 0; } -/* Print a message describing any breakpoints set at PC. This +/* Print a message describing any user-breakpoints set at PC. This concerns with logical breakpoints, so we match program spaces, not address spaces. */ @@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch, struct breakpoint *b; ALL_BREAKPOINTS (b) - others +=3D breakpoint_has_pc (b, pspace, pc, section); + others +=3D (breakpoint_has_pc (b, pspace, pc, section) + && b->number > 0); if (others > 0) { if (others =3D=3D 1) @@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch, else /* if (others =3D=3D ???) */ printf_filtered (_("Note: breakpoints ")); ALL_BREAKPOINTS (b) - if (breakpoint_has_pc (b, pspace, pc, section)) + if (breakpoint_has_pc (b, pspace, pc, section) && b->number >=3D 0) { others--; printf_filtered ("%d", b->number); --=20 1.7.4.4