From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18829 invoked by alias); 26 May 2011 22:32:49 -0000 Received: (qmail 18816 invoked by uid 22791); 26 May 2011 22:32:48 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-bw0-f41.google.com (HELO mail-bw0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 22:32:31 +0000 Received: by bwz17 with SMTP id 17so1028848bwz.0 for ; Thu, 26 May 2011 15:32:30 -0700 (PDT) Received: by 10.204.170.193 with SMTP id e1mr1004892bkz.136.1306449150500; Thu, 26 May 2011 15:32:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.65.65 with HTTP; Thu, 26 May 2011 15:24:56 -0700 (PDT) In-Reply-To: <4DDEB387.3000509@redhat.com> References: <1306440200-25087-1-git-send-email-vapier@gentoo.org> <4DDEB387.3000509@redhat.com> From: Mike Frysinger Date: Thu, 26 May 2011 22:32:00 -0000 Message-ID: Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot To: Marek Polacek Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00624.txt.bz2 On Thu, May 26, 2011 at 16:09, Marek Polacek wrote: > On 05/26/2011 10:03 PM, Mike Frysinger wrote: >> + =A0/* Pass along gdb's concept of the sysroot. =A0*/ >> + =A0strcat (arg_buf, " --sysroot=3D"); >> + =A0strcat (arg_buf, gdb_sysroot); > > BTW, couldn't be those strcat()s replaced by, e.g., cheaper mempcpy()? the whole func probably could be converted, but i was keeping existing style -mike