From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32043 invoked by alias); 20 Apr 2011 13:44:20 -0000 Received: (qmail 32023 invoked by uid 22791); 20 Apr 2011 13:44:19 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Apr 2011 13:44:05 +0000 Received: by vws4 with SMTP id 4so779175vws.0 for ; Wed, 20 Apr 2011 06:44:05 -0700 (PDT) Received: by 10.220.187.4 with SMTP id cu4mr2220642vcb.58.1303307044033; Wed, 20 Apr 2011 06:44:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.61.6 with HTTP; Wed, 20 Apr 2011 06:43:44 -0700 (PDT) From: Kevin Pouget Date: Wed, 20 Apr 2011 13:44:00 -0000 Message-ID: Subject: [PATCH] Remove same-pc breakpoint notification for internal BPs To: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00353.txt.bz2 Hello, I'd like to suggest a patch which removes the message > (gdb) break function > Note: breakpoint -1 also set at pc 0x3cbd80e2a0. > Breakpoint 1 at 0x3cbd80e2a0 when the user sets a breakpoint at the same PC as a _internal_ breakpoints. Internal bps are meant to be hidden from the user, so this patch goes this way (it might happen more often now that it's easy to create internal BPs from the Python interface, and that's what I'm doing) Cordially, Kevin (How can I run the testsuite only for gdb.base, for instance? nothing should fail here, because the testsuite only matches "Note: breakpoint \[0-9\]+ also set...", but I would have preferred actually testing it!) -- diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 2352191..2208a80 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b, return 0; } -/* Print a message describing any breakpoints set at PC. This +/* Print a message describing any user-breakpoints set at PC. This concerns with logical breakpoints, so we match program spaces, not address spaces. */ @@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch, struct breakpoint *b; ALL_BREAKPOINTS (b) - others += breakpoint_has_pc (b, pspace, pc, section); + others += breakpoint_has_pc (b, pspace, pc, section) + && b->number >= 0; if (others > 0) { if (others == 1) @@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch, else /* if (others == ???) */ printf_filtered (_("Note: breakpoints ")); ALL_BREAKPOINTS (b) - if (breakpoint_has_pc (b, pspace, pc, section)) + if (breakpoint_has_pc (b, pspace, pc, section) && b->number >= 0) { others--; printf_filtered ("%d", b->number);