From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6412 invoked by alias); 6 May 2011 15:33:40 -0000 Received: (qmail 6369 invoked by uid 22791); 6 May 2011 15:33:39 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 May 2011 15:33:25 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id p46FXNek024164 for ; Fri, 6 May 2011 08:33:23 -0700 Received: from ywg8 (ywg8.prod.google.com [10.192.7.8]) by wpaz29.hot.corp.google.com with ESMTP id p46FX78e001231 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 6 May 2011 08:33:22 -0700 Received: by ywg8 with SMTP id 8so1316169ywg.6 for ; Fri, 06 May 2011 08:33:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.91.206.3 with SMTP id i3mr1872954agq.153.1304696001635; Fri, 06 May 2011 08:33:21 -0700 (PDT) Received: by 10.90.72.6 with HTTP; Fri, 6 May 2011 08:33:21 -0700 (PDT) In-Reply-To: <20110506151212.GA19356@adacore.com> References: <20110506002720.DE3BF2461B1@ruffy.mtv.corp.google.com> <20110506151212.GA19356@adacore.com> Date: Fri, 06 May 2011 15:33:00 -0000 Message-ID: Subject: Re: [RFC] --with-iconv-path From: Doug Evans To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00191.txt.bz2 On Fri, May 6, 2011 at 8:12 AM, Joel Brobecker wrot= e: >> We have one environment where the iconv binary comes from a >> non-standard location. =A0This patch lets one tell gdb where to find it. > > Does it mean that the libiconv libraries are at one location, and > that the binary is at a different location? Looking at your patch, > it looks like you might have a situation where the name of the iconv > binary itself is different... There is no libiconv library, there's just iconv_{open,close,} in glibc and the iconv binary. >> 2011-05-05 =A0Doug Evans =A0 >> >> =A0 =A0 =A0 * configure.ac: New configure option --with-iconv-path. >> =A0 =A0 =A0 * configure: Regenerate. >> =A0 =A0 =A0 * config.in: Regenerate. >> =A0 =A0 =A0 * charset.c (find_charset_names): Use ICONV_PATH if defined. > > "path" had me confused, and made me think that you were going > to pass the name of the directory where iconv is located. But > the patch seems to be contradicting that. > > If we don't need to specify the name of the iconv directory, > then perhaps we could just focus on the directory name itself. > We could even make that directory name relatocatable, the same > way we make some of the paths relocatable as well. > > Normally, we have sets of switches that look like this: > > =A0 =A0 =A0 =A0--with-xxx=3DPATH > =A0 =A0 =A0 =A0--with-xxx-lib=3DPATH > =A0 =A0 =A0 =A0--with-xxx-include=3DPATH > =A0 =A0 =A0 =A0etc > > We already have --with-libiconv-prefix. =A0So, how about naming it > --with-libiconv-bin ? > > If we think that it would be convenient to specify the iconv exe > as well, how about --with-libiconv-exe or --with-libiconv-program? --with-libiconv-{bin,exe} "works for me" For reference sake, the binary lives in the expected location given --with-libiconv-prefix (i.e., bin/iconv), but how do I effect the necessary change without breaking anything. If folks are happy with adding $WITH_LIBICONV_PREFIX/bin to the front of the search path instead (so no new configure option), I can do that. Seems reasonable, but I guess it *could* break someone's installation somew= here. OTOH, if people are passing --with-libiconv-prefix they may have iconvlist() in which case the iconv binary isn't used, so we're safe.