From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6294 invoked by alias); 30 May 2011 10:53:16 -0000 Received: (qmail 6281 invoked by uid 22791); 30 May 2011 10:53:14 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_EV,TW_VP X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 May 2011 10:53:00 +0000 Received: by vxk20 with SMTP id 20so3417549vxk.0 for ; Mon, 30 May 2011 03:52:59 -0700 (PDT) Received: by 10.220.48.71 with SMTP id q7mr1860318vcf.8.1306752779143; Mon, 30 May 2011 03:52:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.199.1 with HTTP; Mon, 30 May 2011 03:52:39 -0700 (PDT) In-Reply-To: References: From: Kevin Pouget Date: Mon, 30 May 2011 10:53:00 -0000 Message-ID: Subject: Re: [PATCH] Handle multiple breakpoint hits in Python interface To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016e64616c435cbe304a47c17c3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00679.txt.bz2 --0016e64616c435cbe304a47c17c3 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1419 On Mon, May 30, 2011 at 3:48 AM, Eli Zaretskii wrote: >> From: Kevin Pouget >> Date: Mon, 30 May 2011 03:37:06 -0400 >> Cc: gdb-patches@sourceware.org >> >> + This function is maintained for backward compatibility and is now deprecated >> + in favor of @code{gdb.BreakpointEvent.breakpoints()}. > > Thanks, but please remove the "()" part, because it doesn't belong to > the name of the method. fixed. thanks, Kevin 2011-04-30 Kevin Pouget Handle multiple breakpoint hits in Python interface: * gdb.texinfo (Events In Python): New function documentation: gdb.BreakpointEvent.breakpoints. Indicate that gdb.BreakpointEvent.breakpoint is now deprecated. 2011-04-30 Kevin Pouget Handle multiple breakpoint hits in Python interface: * python/py-bpevent.c (create_breakpoint_event_object): Rename C/Python variable to breakpoints. * python/py-stopevent.c (emit_stop_event): Return a Python tuple of bps instead of single breakpoint. Fix some space typos. * python/py-stopevent.c (create_breakpoint_event_object): Rename variable to breakpoints. 2011-04-30 Kevin Pouget Handle multiple breakpoint hits in Python interface: * gdb.python/py-events.exp: Set a duplicate breakpoint and check its presence. * gdb.python/py-events.py (breakpoint_stop_handler): Browse all the breakpoint hits. --0016e64616c435cbe304a47c17c3 Content-Type: text/plain; charset=US-ASCII; name="multiple-bps.txt" Content-Disposition: attachment; filename="multiple-bps.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gobnwlj40 Content-length: 8471 ZGlmZiAtLWdpdCBhL2dkYi9kb2MvZ2RiLnRleGluZm8gYi9nZGIvZG9jL2dk Yi50ZXhpbmZvCmluZGV4IDU4NGE1MjAuLjE4YmQ2NmEgMTAwNjQ0Ci0tLSBh L2dkYi9kb2MvZ2RiLnRleGluZm8KKysrIGIvZ2RiL2RvYy9nZGIudGV4aW5m bwpAQCAtMjIxNTcsMTMgKzIyMTU3LDE5IEBAIHRoZSBAdmFsdWV7R0RCTn0g Y29tbWFuZCBwcm9tcHQuCiAKIEFsc28gZW1pdHMgIEBjb2Rle2dkYi5CcmVh a3BvaW50RXZlbnR9IHdoaWNoIGV4dGVuZHMgQGNvZGV7Z2RiLlN0b3BFdmVu dH0uCiAKLUBjb2Rle2dkYi5CcmVha3BvaW50RXZlbnR9IGV2ZW50IGluZGlj YXRlcyB0aGF0IGEgYnJlYWtwb2ludCBoYXMgYmVlbiBoaXQsIGFuZAotaGFz IHRoZSBmb2xsb3dpbmcgYXR0cmlidXRlczoKK0Bjb2Rle2dkYi5CcmVha3Bv aW50RXZlbnR9IGV2ZW50IGluZGljYXRlcyB0aGF0IG9uZSBvciBzZXZlcmFs IGJyZWFrcG9pbnRzIGhhdmUKK2JlZW4gaGl0LCBhbmQgaGFzIHRoZSBmb2xs b3dpbmcgYXR0cmlidXRlczoKIAogQHRhYmxlIEBjb2RlCi1AZGVmaXZhciBC cmVha3BvaW50RXZlbnQgYnJlYWtwb2ludAotQSByZWZlcmVuY2UgdG8gdGhl IGJyZWFrcG9pbnQgdGhhdCB3YXMgaGl0IG9mIHR5cGUgQGNvZGV7Z2RiLkJy ZWFrcG9pbnR9LgorQGRlZml2YXIgQnJlYWtwb2ludEV2ZW50IGJyZWFrcG9p bnRzCitBIHNlcXVlbmNlIGNvbnRhaW5pbmcgcmVmZXJlbmNlcyB0byBhbGwg dGhlIGJyZWFrcG9pbnRzICh0eXBlIAorQGNvZGV7Z2RiLkJyZWFrcG9pbnR9 KSB0aGF0IHdlcmUgaGl0LgogQHhyZWZ7QnJlYWtwb2ludHMgSW4gUHl0aG9u fSwgZm9yIGRldGFpbHMgb2YgdGhlIEBjb2Rle2dkYi5CcmVha3BvaW50fSBv YmplY3QuCitAZGVmaXZhciBCcmVha3BvaW50RXZlbnQgYnJlYWtwb2ludAor QSByZWZlcmVuY2UgdG8gdGhlIGZpcnN0IGJyZWFrcG9pbnQgdGhhdCB3YXMg aGl0IG9mIHR5cGUgQGNvZGV7Z2RiLkJyZWFrcG9pbnR9LgorVGhpcyBmdW5j dGlvbiBpcyBtYWludGFpbmVkIGZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5 IGFuZCBpcyBub3cgZGVwcmVjYXRlZCAKK2luIGZhdm9yIG9mIHRoZSBAY29k ZXtnZGIuQnJlYWtwb2ludEV2ZW50LmJyZWFrcG9pbnRzfSBmdW5jdGlvbi4K KwogQGVuZCBkZWZpdmFyCiBAZW5kIHRhYmxlCiAKZGlmZiAtLWdpdCBhL2dk Yi9weXRob24vcHktYnBldmVudC5jIGIvZ2RiL3B5dGhvbi9weS1icGV2ZW50 LmMKaW5kZXggYzdmNzk2NS4uZjM3YjI0OCAxMDA2NDQKLS0tIGEvZ2RiL3B5 dGhvbi9weS1icGV2ZW50LmMKKysrIGIvZ2RiL3B5dGhvbi9weS1icGV2ZW50 LmMKQEAgLTI0LDcgKzI0LDcgQEAgc3RhdGljIFB5VHlwZU9iamVjdCBicmVh a3BvaW50X2V2ZW50X29iamVjdF90eXBlOwogLyogQ3JlYXRlIGFuZCBpbml0 aWFsaXplIGEgQnJlYWtwb2ludEV2ZW50IG9iamVjdC4gICovCiAKIFB5T2Jq ZWN0ICoKLWNyZWF0ZV9icmVha3BvaW50X2V2ZW50X29iamVjdCAoUHlPYmpl Y3QgKmJyZWFrcG9pbnQpCitjcmVhdGVfYnJlYWtwb2ludF9ldmVudF9vYmpl Y3QgKFB5T2JqZWN0ICpicmVha3BvaW50X2xpc3QsIFB5T2JqZWN0ICpmaXJz dF9icCkKIHsKICAgUHlPYmplY3QgKmJyZWFrcG9pbnRfZXZlbnRfb2JqID0K ICAgICAgIGNyZWF0ZV9zdG9wX2V2ZW50X29iamVjdCAoJmJyZWFrcG9pbnRf ZXZlbnRfb2JqZWN0X3R5cGUpOwpAQCAtMzQsNyArMzQsMTEgQEAgY3JlYXRl X2JyZWFrcG9pbnRfZXZlbnRfb2JqZWN0IChQeU9iamVjdCAqYnJlYWtwb2lu dCkKIAogICBpZiAoZXZweV9hZGRfYXR0cmlidXRlIChicmVha3BvaW50X2V2 ZW50X29iaiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgImJyZWFrcG9p bnQiLAotICAgICAgICAgICAgICAgICAgICAgICAgICBicmVha3BvaW50KSA8 IDApCisgICAgICAgICAgICAgICAgICAgICAgICAgIGZpcnN0X2JwKSA8IDAp CisgICAgZ290byBmYWlsOworICBpZiAoZXZweV9hZGRfYXR0cmlidXRlIChi cmVha3BvaW50X2V2ZW50X29iaiwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgImJyZWFrcG9pbnRzIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg YnJlYWtwb2ludF9saXN0KSA8IDApCiAgICAgZ290byBmYWlsOwogCiAgIHJl dHVybiBicmVha3BvaW50X2V2ZW50X29iajsKZGlmZiAtLWdpdCBhL2dkYi9w eXRob24vcHktc3RvcGV2ZW50LmMgYi9nZGIvcHl0aG9uL3B5LXN0b3BldmVu dC5jCmluZGV4IDEyMmZlNmIuLjE1ZmZhNzQgMTAwNjQ0Ci0tLSBhL2dkYi9w eXRob24vcHktc3RvcGV2ZW50LmMKKysrIGIvZ2RiL3B5dGhvbi9weS1zdG9w ZXZlbnQuYwpAQCAtNDUsMTggKzQ1LDM2IEBAIGludAogZW1pdF9zdG9wX2V2 ZW50IChzdHJ1Y3QgYnBzdGF0cyAqYnMsIGVudW0gdGFyZ2V0X3NpZ25hbCBz dG9wX3NpZ25hbCkKIHsKICAgUHlPYmplY3QgKnN0b3BfZXZlbnRfb2JqID0g TlVMTDsgLyogQXBwZWFzZSBHQ0Mgd2FybmluZy4gICovCisgIFB5T2JqZWN0 ICpsaXN0ID0gTlVMTDsKKyAgUHlPYmplY3QgKmZpcnN0X2JwID0gTlVMTDsK KyAgc3RydWN0IGJwc3RhdHMgKmN1cnJlbnRfYnM7CiAKICAgaWYgKGV2cmVn cHlfbm9fbGlzdGVuZXJzX3AgKGdkYl9weV9ldmVudHMuc3RvcCkpCiAgICAg cmV0dXJuIDA7CiAKLSAgaWYgKGJzICYmIGJzLT5icmVha3BvaW50X2F0Ci0g ICAgICAmJiBicy0+YnJlYWtwb2ludF9hdC0+cHlfYnBfb2JqZWN0KQorICAv KiBBZGQgYW55IGJyZWFrcG9pbnQgc2V0IGF0IHRoaXMgbG9jYXRpb24gdG8g dGhlIGxpc3QuICAqLworICBmb3IgKGN1cnJlbnRfYnMgPSBiczsgY3VycmVu dF9icyAhPSBOVUxMOyBjdXJyZW50X2JzID0gY3VycmVudF9icy0+bmV4dCkK ICAgICB7Ci0gICAgICBzdG9wX2V2ZW50X29iaiA9IGNyZWF0ZV9icmVha3Bv aW50X2V2ZW50X29iamVjdCAoKFB5T2JqZWN0ICopIGJzCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LT5icmVha3BvaW50X2F0Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgLT5weV9icF9vYmplY3QpOwor ICAgICAgaWYgKGN1cnJlbnRfYnMtPmJyZWFrcG9pbnRfYXQKKyAgICAgICAg ICAmJiBjdXJyZW50X2JzLT5icmVha3BvaW50X2F0LT5weV9icF9vYmplY3Qp CisgICAgICAgIHsKKyAgICAgICAgICBpZiAobGlzdCA9PSBOVUxMKQorICAg ICAgICAgICAgeworICAgICAgICAgICAgICBsaXN0ID0gUHlMaXN0X05ldyAo MCk7CisgICAgICAgICAgICAgIGlmICghbGlzdCkKKyAgICAgICAgICAgICAg ICBnb3RvIGZhaWw7CisgICAgICAgICAgICB9CisgICAgICAgICAgaWYgKFB5 TGlzdF9BcHBlbmQgKGxpc3QsIChQeU9iamVjdCAqKSBjdXJyZW50X2JzLT5i cmVha3BvaW50X2F0LT5weV9icF9vYmplY3QpKSAKKyAgICAgICAgICAgIGdv dG8gZmFpbDsKKyAgICAgICAgICBpZiAoZmlyc3RfYnAgPT0gTlVMTCkKKyAg ICAgICAgICAgIGZpcnN0X2JwID0gKFB5T2JqZWN0ICopIGN1cnJlbnRfYnMt PmJyZWFrcG9pbnRfYXQtPnB5X2JwX29iamVjdDsKKyAgICAgICAgfQorICAg IH0KKyAgaWYgKGxpc3QgIT0gTlVMTCkKKyAgICB7CisgICAgICBzdG9wX2V2 ZW50X29iaiA9IGNyZWF0ZV9icmVha3BvaW50X2V2ZW50X29iamVjdCAobGlz dCwgZmlyc3RfYnApOwogICAgICAgaWYgKCFzdG9wX2V2ZW50X29iaikKLQln b3RvIGZhaWw7CisgICAgICAgIGdvdG8gZmFpbDsKICAgICB9CiAKICAgLyog Q2hlY2sgaWYgdGhlIHNpZ25hbCBpcyAiU2lnbmFsIDAiIG9yICJUcmFjZS9i cmVha3BvaW50IHRyYXAiLiAgKi8KQEAgLTc1LDEzICs5MywxNCBAQCBlbWl0 X3N0b3BfZXZlbnQgKHN0cnVjdCBicHN0YXRzICpicywgZW51bSB0YXJnZXRf c2lnbmFsIHN0b3Bfc2lnbmFsKQogICAgIHsKICAgICAgIHN0b3BfZXZlbnRf b2JqID0gY3JlYXRlX3N0b3BfZXZlbnRfb2JqZWN0ICgmc3RvcF9ldmVudF9v YmplY3RfdHlwZSk7CiAgICAgICBpZiAoIXN0b3BfZXZlbnRfb2JqKQotCWdv dG8gZmFpbDsKKyAgICAgICAgZ290byBmYWlsOwogICAgIH0KIAogICByZXR1 cm4gZXZweV9lbWl0X2V2ZW50IChzdG9wX2V2ZW50X29iaiwgZ2RiX3B5X2V2 ZW50cy5zdG9wKTsKIAotICBmYWlsOgotICAgcmV0dXJuIC0xOworIGZhaWw6 CisgIFB5X1hERUNSRUYobGlzdCk7CisgIHJldHVybiAtMTsKIH0KIAogR0RC UFlfTkVXX0VWRU5UX1RZUEUgKHN0b3AsCmRpZmYgLS1naXQgYS9nZGIvcHl0 aG9uL3B5LXN0b3BldmVudC5oIGIvZ2RiL3B5dGhvbi9weS1zdG9wZXZlbnQu aAppbmRleCA1MmYzNTExLi44NWFjNGQzIDEwMDY0NAotLS0gYS9nZGIvcHl0 aG9uL3B5LXN0b3BldmVudC5oCisrKyBiL2dkYi9weXRob24vcHktc3RvcGV2 ZW50LmgKQEAgLTI4LDcgKzI4LDggQEAgZXh0ZXJuIHZvaWQgc3RvcF9ldnB5 X2RlYWxsb2MgKFB5T2JqZWN0ICpzZWxmKTsKIGV4dGVybiBpbnQgZW1pdF9z dG9wX2V2ZW50IChzdHJ1Y3QgYnBzdGF0cyAqYnMsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZW51bSB0YXJnZXRfc2lnbmFsIHN0b3Bfc2lnbmFs KTsKIAotZXh0ZXJuIFB5T2JqZWN0ICpjcmVhdGVfYnJlYWtwb2ludF9ldmVu dF9vYmplY3QgKFB5T2JqZWN0ICpicmVha3BvaW50KTsKK2V4dGVybiBQeU9i amVjdCAqY3JlYXRlX2JyZWFrcG9pbnRfZXZlbnRfb2JqZWN0IChQeU9iamVj dCAqYnJlYWtwb2ludF9saXN0LAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFB5T2JqZWN0ICpmaXJzdF9icCk7 CiAKIGV4dGVybiBQeU9iamVjdCAqY3JlYXRlX3NpZ25hbF9ldmVudF9vYmpl Y3QgKGVudW0gdGFyZ2V0X3NpZ25hbCBzdG9wX3NpZ25hbCk7CiAKZGlmZiAt LWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMuZXhw IGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5leHAKaW5k ZXggZTVkNmRhZi4uOGVmZjE2NSAxMDA2NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0 ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0 ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5leHAKQEAgLTQ1LDEyICs0NSwxNSBA QCBpZiAhW3J1bnRvX21haW4gXSB0aGVuIHsKIGdkYl90ZXN0ICJUZXN0X0V2 ZW50cyIgIkV2ZW50IHRlc3RlcnMgcmVnaXN0ZXJlZC4iCiAKIGdkYl9icmVh a3BvaW50ICJmaXJzdCIKK2dkYl9icmVha3BvaW50ICJmaXJzdCIKIAogIyBU ZXN0IGNvbnRpbnVlIGV2ZW50IGFuZCBicmVha3BvaW50IHN0b3AgZXZlbnQK IGdkYl90ZXN0ICJjb250aW51ZSIgIi4qZXZlbnQgdHlwZTogY29udGludWUu KgogLipldmVudCB0eXBlOiBzdG9wLioKIC4qc3RvcCByZWFzb246IGJyZWFr cG9pbnQuKgorLipmaXJzdCBicmVha3BvaW50IG51bWJlcjogMi4qCiAuKmJy ZWFrcG9pbnQgbnVtYmVyOiAyLioKKy4qYnJlYWtwb2ludCBudW1iZXI6IDMu KgogYWxsIHRocmVhZHMgc3RvcHBlZCIKIAogI3Rlc3QgZXhpdGVkIGV2ZW50 LgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2 ZW50cy5weSBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMu cHkKaW5kZXggOWYwNWI5Zi4uMTBhZWE0ZiAxMDA2NDQKLS0tIGEvZ2RiL3Rl c3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5weQorKysgYi9nZGIvdGVz dHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLnB5CkBAIC0zMSw3ICszMSw5 IEBAIGRlZiBicmVha3BvaW50X3N0b3BfaGFuZGxlciAoZXZlbnQpOgogICAg ICAgICBwcmludCAiZXZlbnQgdHlwZTogc3RvcCIKICAgICBpZiAoaXNpbnN0 YW5jZSAoZXZlbnQsIGdkYi5CcmVha3BvaW50RXZlbnQpKToKICAgICAgICAg cHJpbnQgInN0b3AgcmVhc29uOiBicmVha3BvaW50IgotICAgICAgICBwcmlu dCAiYnJlYWtwb2ludCBudW1iZXI6ICVzIiAlIChldmVudC5icmVha3BvaW50 Lm51bWJlcikKKyAgICAgICAgcHJpbnQgImZpcnN0IGJyZWFrcG9pbnQgbnVt YmVyOiAlcyIgJSAoZXZlbnQuYnJlYWtwb2ludC5udW1iZXIpCisgICAgICAg IGZvciBicCBpbiBldmVudC5icmVha3BvaW50czoKKyAgICAgICAgCXByaW50 ICJicmVha3BvaW50IG51bWJlcjogJXMiICUgKGJwLm51bWJlcikKICAgICAg ICAgaWYgKCBldmVudC5pbmZlcmlvcl90aHJlYWQgaXMgbm90IE5vbmUpIDoK ICAgICAgICAgICAgIHByaW50ICJ0aHJlYWQgbnVtOiAlcyIgJSAoZXZlbnQu aW5mZXJpb3JfdGhyZWFkLm51bSk7CiAgICAgICAgIGVsc2U6Cg== --0016e64616c435cbe304a47c17c3--