From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23211 invoked by alias); 28 Jun 2011 19:56:10 -0000 Received: (qmail 23203 invoked by uid 22791); 28 Jun 2011 19:56:09 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Jun 2011 19:55:56 +0000 Received: by qwa26 with SMTP id 26so396476qwa.0 for ; Tue, 28 Jun 2011 12:55:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.98.206 with SMTP id r14mr1878912qcn.18.1309290955407; Tue, 28 Jun 2011 12:55:55 -0700 (PDT) Received: by 10.229.214.83 with HTTP; Tue, 28 Jun 2011 12:55:55 -0700 (PDT) In-Reply-To: References: <20100920135856.GA27953@intel.com> Date: Tue, 28 Jun 2011 19:56:00 -0000 Message-ID: Subject: Re: PATCH: PR testsuite/12040: GDB Fortran tests use g77 instead of gfortran From: "H.J. Lu" To: Tom Tromey Cc: GDB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00421.txt.bz2 On Tue, Jun 28, 2011 at 12:35 PM, Tom Tromey wrote: >>>>>> "HJ" =3D=3D H J Lu writes: > > HJ> This isn't a proper fix since it depends on we load lib/ada.exp before > HJ> any Fortran tests. =A0I think ada.exp is the wrong place to provide > HJ> GDB functions. =A0It should be placed in something like gdb-support.e= xp and > HJ> ada.exp/fortran.exp can just load it. > > I'm sorry that it took so long for me to review this patch. > > HJ> =A0 =A0 PR testsuite/12040 > HJ> =A0 =A0 * lib/ada.exp (gdb_find_gfortran): New. > HJ> =A0 =A0 (gdb_default_target_compile): Use it. > > I would like something like this to go in, but I don't think this will > have the desired effect, since ada.exp is not always loaded. > > Instead I think these procs must be moved elsewhere so they are always > used. > > I sent a patch to dejagnu to allow f90 today; so perhaps the result > could be based on that. =A0I can do the work if you like, just let me > know. Please do. Thanks. --=20 H.J.