From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31872 invoked by alias); 30 May 2011 07:37:45 -0000 Received: (qmail 31612 invoked by uid 22791); 30 May 2011 07:37:43 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_20,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_EV,TW_VP X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 May 2011 07:37:27 +0000 Received: by vws4 with SMTP id 4so3324456vws.0 for ; Mon, 30 May 2011 00:37:26 -0700 (PDT) Received: by 10.220.42.7 with SMTP id q7mr1797906vce.43.1306741046199; Mon, 30 May 2011 00:37:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.199.1 with HTTP; Mon, 30 May 2011 00:37:06 -0700 (PDT) In-Reply-To: References: From: Kevin Pouget Date: Mon, 30 May 2011 07:37:00 -0000 Message-ID: Subject: Re: [PATCH] Handle multiple breakpoint hits in Python interface To: Tom Tromey , Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016e647661adf46da04a4795b07 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00674.txt.bz2 --0016e647661adf46da04a4795b07 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1954 Hello, here is the patch which includes the documentation modification asked by El= i: > In that case, I suggest to say it is deprecated and kept for backward > compatibility, and advise which alternative should be used instead. + This function is maintained for backward compatibility and is now depreca= ted + in favor of @code{gdb.BreakpointEvent.breakpoints()}. Thanks, Kevin -- 2011-04-30 Kevin Pouget Handle multiple breakpoint hits in Python interface: * gdb.texinfo (Events In Python): Indicate that multiple breakpoint may have been hit and rename the variable to breakpoints. 2011-04-30 Kevin Pouget Handle multiple breakpoint hits in Python interface: * python/py-bpevent.c (create_breakpoint_event_object): Rename C/Python variable to breakpoints. * python/py-stopevent.c (emit_stop_event): Return a Python tuple of bps instead of single breakpoint. Fix some space typos. * python/py-stopevent.c (create_breakpoint_event_object): Rename variable to breakpoints. 2011-04-30 Kevin Pouget Handle multiple breakpoint hits in Python interface: * gdb.python/py-events.exp: Set a duplicate breakpoint and check its presence. * gdb.python/py-events.py (breakpoint_stop_handler): Browse all the breakpoint hits. On Fri, May 27, 2011 at 4:09 PM, Tom Tromey wrote: > > >>>>> "Kevin" =3D=3D Kevin Pouget writes: > > Kevin> I put back the breakpoint attribute in addition to the "breakpoint= s" > Kevin> sequence and added in the documentation that it was "legacy suppor= t", > Kevin> is it okay for you? > > Yes. > > Many of your patches seem ready to me. =A0A couple still may need doc > review. =A0IIRC, your paperwork isn't done yet, so at this point we must > wait for that. =A0I don't recall when you sent things in, if it has been a > while you might consider pinging the FSF copyright clerk. > > Tom --0016e647661adf46da04a4795b07 Content-Type: text/plain; charset=US-ASCII; name="multiple-bps.txt" Content-Disposition: attachment; filename="multiple-bps.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gobgwk4g1 Content-length: 8471 ZGlmZiAtLWdpdCBhL2dkYi9kb2MvZ2RiLnRleGluZm8gYi9nZGIvZG9jL2dk Yi50ZXhpbmZvCmluZGV4IDU4NGE1MjAuLjE1ZWMwODggMTAwNjQ0Ci0tLSBh L2dkYi9kb2MvZ2RiLnRleGluZm8KKysrIGIvZ2RiL2RvYy9nZGIudGV4aW5m bwpAQCAtMjIxNTcsMTMgKzIyMTU3LDE5IEBAIHRoZSBAdmFsdWV7R0RCTn0g Y29tbWFuZCBwcm9tcHQuCiAKIEFsc28gZW1pdHMgIEBjb2Rle2dkYi5CcmVh a3BvaW50RXZlbnR9IHdoaWNoIGV4dGVuZHMgQGNvZGV7Z2RiLlN0b3BFdmVu dH0uCiAKLUBjb2Rle2dkYi5CcmVha3BvaW50RXZlbnR9IGV2ZW50IGluZGlj YXRlcyB0aGF0IGEgYnJlYWtwb2ludCBoYXMgYmVlbiBoaXQsIGFuZAotaGFz IHRoZSBmb2xsb3dpbmcgYXR0cmlidXRlczoKK0Bjb2Rle2dkYi5CcmVha3Bv aW50RXZlbnR9IGV2ZW50IGluZGljYXRlcyB0aGF0IG9uZSBvciBzZXZlcmFs IGJyZWFrcG9pbnRzIGhhdmUKK2JlZW4gaGl0LCBhbmQgaGFzIHRoZSBmb2xs b3dpbmcgYXR0cmlidXRlczoKIAogQHRhYmxlIEBjb2RlCi1AZGVmaXZhciBC cmVha3BvaW50RXZlbnQgYnJlYWtwb2ludAotQSByZWZlcmVuY2UgdG8gdGhl IGJyZWFrcG9pbnQgdGhhdCB3YXMgaGl0IG9mIHR5cGUgQGNvZGV7Z2RiLkJy ZWFrcG9pbnR9LgorQGRlZml2YXIgQnJlYWtwb2ludEV2ZW50IGJyZWFrcG9p bnRzCitBIHNlcXVlbmNlIGNvbnRhaW5pbmcgcmVmZXJlbmNlcyB0byBhbGwg dGhlIGJyZWFrcG9pbnRzICh0eXBlIAorQGNvZGV7Z2RiLkJyZWFrcG9pbnR9 KSB0aGF0IHdlcmUgaGl0LgogQHhyZWZ7QnJlYWtwb2ludHMgSW4gUHl0aG9u fSwgZm9yIGRldGFpbHMgb2YgdGhlIEBjb2Rle2dkYi5CcmVha3BvaW50fSBv YmplY3QuCitAZGVmaXZhciBCcmVha3BvaW50RXZlbnQgYnJlYWtwb2ludAor QSByZWZlcmVuY2UgdG8gdGhlIGZpcnN0IGJyZWFrcG9pbnQgdGhhdCB3YXMg aGl0IG9mIHR5cGUgQGNvZGV7Z2RiLkJyZWFrcG9pbnR9LgorVGhpcyBmdW5j dGlvbiBpcyBtYWludGFpbmVkIGZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5 IGFuZCBpcyBub3cgZGVwcmVjYXRlZCAKK2luIGZhdm9yIG9mIHRoZSBAY29k ZXtnZGIuQnJlYWtwb2ludEV2ZW50LmJyZWFrcG9pbnRzKCl9IGZ1bmN0aW9u LgorCiBAZW5kIGRlZml2YXIKIEBlbmQgdGFibGUKIApkaWZmIC0tZ2l0IGEv Z2RiL3B5dGhvbi9weS1icGV2ZW50LmMgYi9nZGIvcHl0aG9uL3B5LWJwZXZl bnQuYwppbmRleCBjN2Y3OTY1Li5mMzdiMjQ4IDEwMDY0NAotLS0gYS9nZGIv cHl0aG9uL3B5LWJwZXZlbnQuYworKysgYi9nZGIvcHl0aG9uL3B5LWJwZXZl bnQuYwpAQCAtMjQsNyArMjQsNyBAQCBzdGF0aWMgUHlUeXBlT2JqZWN0IGJy ZWFrcG9pbnRfZXZlbnRfb2JqZWN0X3R5cGU7CiAvKiBDcmVhdGUgYW5kIGlu aXRpYWxpemUgYSBCcmVha3BvaW50RXZlbnQgb2JqZWN0LiAgKi8KIAogUHlP YmplY3QgKgotY3JlYXRlX2JyZWFrcG9pbnRfZXZlbnRfb2JqZWN0IChQeU9i amVjdCAqYnJlYWtwb2ludCkKK2NyZWF0ZV9icmVha3BvaW50X2V2ZW50X29i amVjdCAoUHlPYmplY3QgKmJyZWFrcG9pbnRfbGlzdCwgUHlPYmplY3QgKmZp cnN0X2JwKQogewogICBQeU9iamVjdCAqYnJlYWtwb2ludF9ldmVudF9vYmog PQogICAgICAgY3JlYXRlX3N0b3BfZXZlbnRfb2JqZWN0ICgmYnJlYWtwb2lu dF9ldmVudF9vYmplY3RfdHlwZSk7CkBAIC0zNCw3ICszNCwxMSBAQCBjcmVh dGVfYnJlYWtwb2ludF9ldmVudF9vYmplY3QgKFB5T2JqZWN0ICpicmVha3Bv aW50KQogCiAgIGlmIChldnB5X2FkZF9hdHRyaWJ1dGUgKGJyZWFrcG9pbnRf ZXZlbnRfb2JqLAogICAgICAgICAgICAgICAgICAgICAgICAgICAiYnJlYWtw b2ludCIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrcG9pbnQp IDwgMCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgZmlyc3RfYnApIDwg MCkKKyAgICBnb3RvIGZhaWw7CisgIGlmIChldnB5X2FkZF9hdHRyaWJ1dGUg KGJyZWFrcG9pbnRfZXZlbnRfb2JqLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAiYnJlYWtwb2ludHMiLAorICAgICAgICAgICAgICAgICAgICAgICAg ICBicmVha3BvaW50X2xpc3QpIDwgMCkKICAgICBnb3RvIGZhaWw7CiAKICAg cmV0dXJuIGJyZWFrcG9pbnRfZXZlbnRfb2JqOwpkaWZmIC0tZ2l0IGEvZ2Ri L3B5dGhvbi9weS1zdG9wZXZlbnQuYyBiL2dkYi9weXRob24vcHktc3RvcGV2 ZW50LmMKaW5kZXggMTIyZmU2Yi4uMTVmZmE3NCAxMDA2NDQKLS0tIGEvZ2Ri L3B5dGhvbi9weS1zdG9wZXZlbnQuYworKysgYi9nZGIvcHl0aG9uL3B5LXN0 b3BldmVudC5jCkBAIC00NSwxOCArNDUsMzYgQEAgaW50CiBlbWl0X3N0b3Bf ZXZlbnQgKHN0cnVjdCBicHN0YXRzICpicywgZW51bSB0YXJnZXRfc2lnbmFs IHN0b3Bfc2lnbmFsKQogewogICBQeU9iamVjdCAqc3RvcF9ldmVudF9vYmog PSBOVUxMOyAvKiBBcHBlYXNlIEdDQyB3YXJuaW5nLiAgKi8KKyAgUHlPYmpl Y3QgKmxpc3QgPSBOVUxMOworICBQeU9iamVjdCAqZmlyc3RfYnAgPSBOVUxM OworICBzdHJ1Y3QgYnBzdGF0cyAqY3VycmVudF9iczsKIAogICBpZiAoZXZy ZWdweV9ub19saXN0ZW5lcnNfcCAoZ2RiX3B5X2V2ZW50cy5zdG9wKSkKICAg ICByZXR1cm4gMDsKIAotICBpZiAoYnMgJiYgYnMtPmJyZWFrcG9pbnRfYXQK LSAgICAgICYmIGJzLT5icmVha3BvaW50X2F0LT5weV9icF9vYmplY3QpCisg IC8qIEFkZCBhbnkgYnJlYWtwb2ludCBzZXQgYXQgdGhpcyBsb2NhdGlvbiB0 byB0aGUgbGlzdC4gICovCisgIGZvciAoY3VycmVudF9icyA9IGJzOyBjdXJy ZW50X2JzICE9IE5VTEw7IGN1cnJlbnRfYnMgPSBjdXJyZW50X2JzLT5uZXh0 KQogICAgIHsKLSAgICAgIHN0b3BfZXZlbnRfb2JqID0gY3JlYXRlX2JyZWFr cG9pbnRfZXZlbnRfb2JqZWN0ICgoUHlPYmplY3QgKikgYnMKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAtPmJyZWFrcG9pbnRfYXQKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtPnB5X2JwX29iamVjdCk7 CisgICAgICBpZiAoY3VycmVudF9icy0+YnJlYWtwb2ludF9hdAorICAgICAg ICAgICYmIGN1cnJlbnRfYnMtPmJyZWFrcG9pbnRfYXQtPnB5X2JwX29iamVj dCkKKyAgICAgICAgeworICAgICAgICAgIGlmIChsaXN0ID09IE5VTEwpCisg ICAgICAgICAgICB7CisgICAgICAgICAgICAgIGxpc3QgPSBQeUxpc3RfTmV3 ICgwKTsKKyAgICAgICAgICAgICAgaWYgKCFsaXN0KQorICAgICAgICAgICAg ICAgIGdvdG8gZmFpbDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICBpZiAo UHlMaXN0X0FwcGVuZCAobGlzdCwgKFB5T2JqZWN0ICopIGN1cnJlbnRfYnMt PmJyZWFrcG9pbnRfYXQtPnB5X2JwX29iamVjdCkpIAorICAgICAgICAgICAg Z290byBmYWlsOworICAgICAgICAgIGlmIChmaXJzdF9icCA9PSBOVUxMKQor ICAgICAgICAgICAgZmlyc3RfYnAgPSAoUHlPYmplY3QgKikgY3VycmVudF9i cy0+YnJlYWtwb2ludF9hdC0+cHlfYnBfb2JqZWN0OworICAgICAgICB9Cisg ICAgfQorICBpZiAobGlzdCAhPSBOVUxMKQorICAgIHsKKyAgICAgIHN0b3Bf ZXZlbnRfb2JqID0gY3JlYXRlX2JyZWFrcG9pbnRfZXZlbnRfb2JqZWN0IChs aXN0LCBmaXJzdF9icCk7CiAgICAgICBpZiAoIXN0b3BfZXZlbnRfb2JqKQot CWdvdG8gZmFpbDsKKyAgICAgICAgZ290byBmYWlsOwogICAgIH0KIAogICAv KiBDaGVjayBpZiB0aGUgc2lnbmFsIGlzICJTaWduYWwgMCIgb3IgIlRyYWNl L2JyZWFrcG9pbnQgdHJhcCIuICAqLwpAQCAtNzUsMTMgKzkzLDE0IEBAIGVt aXRfc3RvcF9ldmVudCAoc3RydWN0IGJwc3RhdHMgKmJzLCBlbnVtIHRhcmdl dF9zaWduYWwgc3RvcF9zaWduYWwpCiAgICAgewogICAgICAgc3RvcF9ldmVu dF9vYmogPSBjcmVhdGVfc3RvcF9ldmVudF9vYmplY3QgKCZzdG9wX2V2ZW50 X29iamVjdF90eXBlKTsKICAgICAgIGlmICghc3RvcF9ldmVudF9vYmopCi0J Z290byBmYWlsOworICAgICAgICBnb3RvIGZhaWw7CiAgICAgfQogCiAgIHJl dHVybiBldnB5X2VtaXRfZXZlbnQgKHN0b3BfZXZlbnRfb2JqLCBnZGJfcHlf ZXZlbnRzLnN0b3ApOwogCi0gIGZhaWw6Ci0gICByZXR1cm4gLTE7CisgZmFp bDoKKyAgUHlfWERFQ1JFRihsaXN0KTsKKyAgcmV0dXJuIC0xOwogfQogCiBH REJQWV9ORVdfRVZFTlRfVFlQRSAoc3RvcCwKZGlmZiAtLWdpdCBhL2dkYi9w eXRob24vcHktc3RvcGV2ZW50LmggYi9nZGIvcHl0aG9uL3B5LXN0b3BldmVu dC5oCmluZGV4IDUyZjM1MTEuLjg1YWM0ZDMgMTAwNjQ0Ci0tLSBhL2dkYi9w eXRob24vcHktc3RvcGV2ZW50LmgKKysrIGIvZ2RiL3B5dGhvbi9weS1zdG9w ZXZlbnQuaApAQCAtMjgsNyArMjgsOCBAQCBleHRlcm4gdm9pZCBzdG9wX2V2 cHlfZGVhbGxvYyAoUHlPYmplY3QgKnNlbGYpOwogZXh0ZXJuIGludCBlbWl0 X3N0b3BfZXZlbnQgKHN0cnVjdCBicHN0YXRzICpicywKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBlbnVtIHRhcmdldF9zaWduYWwgc3RvcF9zaWdu YWwpOwogCi1leHRlcm4gUHlPYmplY3QgKmNyZWF0ZV9icmVha3BvaW50X2V2 ZW50X29iamVjdCAoUHlPYmplY3QgKmJyZWFrcG9pbnQpOworZXh0ZXJuIFB5 T2JqZWN0ICpjcmVhdGVfYnJlYWtwb2ludF9ldmVudF9vYmplY3QgKFB5T2Jq ZWN0ICpicmVha3BvaW50X2xpc3QsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgUHlPYmplY3QgKmZpcnN0X2Jw KTsKIAogZXh0ZXJuIFB5T2JqZWN0ICpjcmVhdGVfc2lnbmFsX2V2ZW50X29i amVjdCAoZW51bSB0YXJnZXRfc2lnbmFsIHN0b3Bfc2lnbmFsKTsKIApkaWZm IC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5l eHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmV4cApp bmRleCBlNWQ2ZGFmLi44ZWZmMTY1IDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1 aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmV4cAorKysgYi9nZGIvdGVzdHN1 aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmV4cApAQCAtNDUsMTIgKzQ1LDE1 IEBAIGlmICFbcnVudG9fbWFpbiBdIHRoZW4gewogZ2RiX3Rlc3QgIlRlc3Rf RXZlbnRzIiAiRXZlbnQgdGVzdGVycyByZWdpc3RlcmVkLiIKIAogZ2RiX2Jy ZWFrcG9pbnQgImZpcnN0IgorZ2RiX2JyZWFrcG9pbnQgImZpcnN0IgogCiAj IFRlc3QgY29udGludWUgZXZlbnQgYW5kIGJyZWFrcG9pbnQgc3RvcCBldmVu dAogZ2RiX3Rlc3QgImNvbnRpbnVlIiAiLipldmVudCB0eXBlOiBjb250aW51 ZS4qCiAuKmV2ZW50IHR5cGU6IHN0b3AuKgogLipzdG9wIHJlYXNvbjogYnJl YWtwb2ludC4qCisuKmZpcnN0IGJyZWFrcG9pbnQgbnVtYmVyOiAyLioKIC4q YnJlYWtwb2ludCBudW1iZXI6IDIuKgorLipicmVha3BvaW50IG51bWJlcjog My4qCiBhbGwgdGhyZWFkcyBzdG9wcGVkIgogCiAjdGVzdCBleGl0ZWQgZXZl bnQuCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHkt ZXZlbnRzLnB5IGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50 cy5weQppbmRleCA5ZjA1YjlmLi4xMGFlYTRmIDEwMDY0NAotLS0gYS9nZGIv dGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLnB5CisrKyBiL2dkYi90 ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMucHkKQEAgLTMxLDcgKzMx LDkgQEAgZGVmIGJyZWFrcG9pbnRfc3RvcF9oYW5kbGVyIChldmVudCk6CiAg ICAgICAgIHByaW50ICJldmVudCB0eXBlOiBzdG9wIgogICAgIGlmIChpc2lu c3RhbmNlIChldmVudCwgZ2RiLkJyZWFrcG9pbnRFdmVudCkpOgogICAgICAg ICBwcmludCAic3RvcCByZWFzb246IGJyZWFrcG9pbnQiCi0gICAgICAgIHBy aW50ICJicmVha3BvaW50IG51bWJlcjogJXMiICUgKGV2ZW50LmJyZWFrcG9p bnQubnVtYmVyKQorICAgICAgICBwcmludCAiZmlyc3QgYnJlYWtwb2ludCBu dW1iZXI6ICVzIiAlIChldmVudC5icmVha3BvaW50Lm51bWJlcikKKyAgICAg ICAgZm9yIGJwIGluIGV2ZW50LmJyZWFrcG9pbnRzOgorICAgICAgICAJcHJp bnQgImJyZWFrcG9pbnQgbnVtYmVyOiAlcyIgJSAoYnAubnVtYmVyKQogICAg ICAgICBpZiAoIGV2ZW50LmluZmVyaW9yX3RocmVhZCBpcyBub3QgTm9uZSkg OgogICAgICAgICAgICAgcHJpbnQgInRocmVhZCBudW06ICVzIiAlIChldmVu dC5pbmZlcmlvcl90aHJlYWQubnVtKTsKICAgICAgICAgZWxzZToK --0016e647661adf46da04a4795b07--