From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28322 invoked by alias); 23 May 2011 11:01:08 -0000 Received: (qmail 28314 invoked by uid 22791); 23 May 2011 11:01:07 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 11:00:53 +0000 Received: by vws4 with SMTP id 4so5117480vws.0 for ; Mon, 23 May 2011 04:00:53 -0700 (PDT) Received: by 10.220.122.96 with SMTP id k32mr694302vcr.68.1306148453091; Mon, 23 May 2011 04:00:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.188.139 with HTTP; Mon, 23 May 2011 04:00:33 -0700 (PDT) In-Reply-To: References: From: Kevin Pouget Date: Mon, 23 May 2011 11:01:00 -0000 Message-ID: Subject: Re: [PATCH] Handle multiple breakpoint hits in Python interface To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00520.txt.bz2 hello, > ...this. What is that phrase in parens for? Can it be removed? do you mean the phrase or the parens? The reason why I added this comment is that, to my eyes, BreakpointEvent.breakpoint don't make sense anymore because it is incomplete and inaccurate, but it's kept in order not to break the backward compatibility. Maybe 'deprecated' would be a better wording ? cordially, Kevin On Mon, May 23, 2011 at 6:51 AM, Eli Zaretskii wrote: >> From: Kevin Pouget >> Date: Mon, 23 May 2011 05:38:54 -0400 >> Cc: gdb-patches@sourceware.org >> >> 2011-04-22 =A0Kevin Pouget =A0 >> >> =A0 =A0 =A0 Handle multiple breakpoint hits in Python interface: >> =A0 =A0 =A0 * gdb.texinfo (Events In Python): Indicate that multiple bre= akpoint >> =A0 =A0 =A0 may have been hit and rename the variable to breakpoints. > > This part is OK, except... > >> +@defivar BreakpointEvent breakpoint >> +A reference to the first breakpoint that was hit of type @code{gdb.Brea= kpoint}. >> +(Legacy support.) > =A0 ^^^^^^^^^^^^^^^^^ > ...this. =A0What is that phrase in parens for? =A0Can it be removed? > > Thanks. >