From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30453 invoked by alias); 3 Feb 2012 22:39:40 -0000 Received: (qmail 30430 invoked by uid 22791); 3 Feb 2012 22:39:38 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailrelay011.isp.belgacom.be (HELO mailrelay011.isp.belgacom.be) (195.238.6.178) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Feb 2012 22:39:24 +0000 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgIFAEJhLE9R9py4/2dsb2JhbABDhQuFTaRPgQaBbQUBAQQBCAEBGRUeAQEGIAYCAwUCAQMaAgUhAgIUAQQaBh4GARoCAQIDAYdrA6ZrkX0TgRyEOYVvASoGASEECQQPAwMBAwGCb4N0M2MEjUkBmjc Received: from 184.156-246-81.adsl-dyn.isp.belgacom.be (HELO soleil) ([81.246.156.184]) by relay.skynet.be with SMTP; 03 Feb 2012 23:39:22 +0100 Message-ID: From: "Philippe Waroquiers" To: "Stan Shebs" , References: <1327265676.23561.25.camel@soleil> <4F1D5335.3090705@redhat.com> <1327350423.2215.6.camel@soleil> <1328220784.7612.5.camel@soleil> <4F2C4350.6030000@earthlink.net> Subject: Re: (ping) Re: RFA: remote.c : allow long monitor cmds + allow user to C-c Date: Fri, 03 Feb 2012 22:39:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=response Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00054.txt.bz2 > Looks reasonable to me, let's put it in. I don't suppose there's any > easy way to make a testsuite test for it? Thanks for the feedback, will commit. Effectively, no easy way to have a testsuite test for that, as a remote command taking a long time is needed for that. A possible approach would be to write a test checking if a valgrind >= 3.7.0 is available (as Valgrind has a 'v.wait xxxx' milliseconds monitor command). Not clear to me just this is worth the effort. However, the added bonus would be to have in gdb one (or more) tests checking the connection with the Valgrind gdbserver. Currently, only the Valgrind test suite has tests testing the connection between its gdbserver and gdb. Philippe