From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39386 invoked by alias); 9 Oct 2019 16:01:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39378 invoked by uid 89); 9 Oct 2019 16:01:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1826 X-HELO: mga06.intel.com Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2019 16:01:51 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2019 09:01:48 -0700 Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 09 Oct 2019 09:01:47 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.36]) by IRSMSX152.ger.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0439.000; Wed, 9 Oct 2019 17:01:47 +0100 From: "Aktemur, Tankut Baris" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 18/23] Add multi-target tests Date: Wed, 09 Oct 2019 16:01:00 -0000 Message-ID: References: <20190906232807.6191-1-palves@redhat.com> <20190906232807.6191-19-palves@redhat.com> In-Reply-To: <20190906232807.6191-19-palves@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00250.txt.bz2 KiBPbiBTZXB0ZW1iZXIgNywgMjAxOSAxOjI4IEFNLCBQZWRybyBBbHZlcyB3 cm90ZToNCj4gDQo+IFRoaXMgYWRkcyBhIHRlc3RjYXNlIGV4ZXJjaXNpbmcg bXVsdGktdGFyZ2V0IGZlYXR1cmVzLiAgSXQgc3Bhd25zIDYNCj4gaW5mZXJp b3JzLCBsaWtlIHRoaXM6DQo+IA0KPiAgaW5mZXJpb3IgMSAtPiBuYXRpdmUN Cj4gIGluZmVyaW9yIDIgLT4gZXh0ZW5kZWQtcmVtb3RlIDENCj4gIGluZmVy aW9yIDMgLT4gY29yZQ0KPiAgaW5mZXJpb3IgNCAtPiBuYXRpdmUNCj4gIGlu ZmVyaW9yIDUgLT4gZXh0ZW5kZWQtcmVtb3RlIDINCj4gIGluZmVyaW9yIDYg LT4gY29yZQ0KPiANCj4gYW5kIHRoZW4gdGVzdHMgdmFyaW91cyBkZXRhaWxz LCBpbmNsdWRpbmc6DQo+IA0KPiAgLSBydW5uaW5nIHRvIGJyZWFrcG9pbnRz DQo+IA0KPiAgLSBpbnRlcnJ1cHRpbmcgd2l0aCBDdHJsLUMgYW5kICJpbnRl cnJ1cHQgLWEiDQo+IA0KPiAgLSAibmV4dCIgYm91bmNpbmcgYmV0d2VlbiB0 d28gYnJlYWtwb2ludHMgaW4gdHdvIHRocmVhZHMgcnVubmluZyBpbg0KPiAg ICBkaWZmZXJlbnQgdGFyZ2V0cy4NCj4gDQo+ICAtIHNpbmNlIHdlIGhhdmUg Y29yZXMgYW5kIGxpdmUgaW5mZXJpb3JzIG1peGVkIGluIHRoZSBzYW1lIHNl c3Npb24sDQo+ICAgIHRoaXMgbWFrZXMgc3VyZSB0aGF0IGdkYiBkb2Vzbid0 IHRyeSB0byByZW1vdmUgYSBjb3JlIGR1bXAncw0KPiAgICB0aHJlYWRzLg0K PiANCj4gIC0gYWxsLXN0b3AgYW5kIG5vbi1zdG9wIG1vZGVzLg0KPiANCj4g VGhpcyB0ZXN0Y2FzZSBjYXVnaHQgYSBfbG90XyBvZiBidWdzIGluIGRldmVs b3BtZW50Lg0KPiANCj4gZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2Ri Lm11bHRpL211bHRpLXRhcmdldC5jIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIubXVs dGkvbXVsdGktdGFyZ2V0LmMNCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4g aW5kZXggMDAwMDAwMDAwMC4uODU2MjI2ZTZiOQ0KPiAtLS0gL2Rldi9udWxs DQo+ICsrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLm11bHRpL211bHRpLXRhcmdl dC5jDQo+IEBAIC0wLDAgKzEsMTAwIEBADQo+ICsvKiBUaGlzIHRlc3RjYXNl IGlzIHBhcnQgb2YgR0RCLCB0aGUgR05VIGRlYnVnZ2VyLg0KPiArDQo+ICsg ICBDb3B5cmlnaHQgMjAxNy0yMDE5IEZyZWUgU29mdHdhcmUgRm91bmRhdGlv biwgSW5jLg0KPiArDQoNClRoZSB5ZWFyIHNob3VsZCBiZSBqdXN0IDIwMTku IFJpZ2h0Pw0KDQo+IGRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5t dWx0aS9tdWx0aS10YXJnZXQuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIubXVs dGkvbXVsdGktdGFyZ2V0LmV4cA0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0K PiBpbmRleCAwMDAwMDAwMDAwLi4zYjcxZTc0NDZiDQo+IC0tLSAvZGV2L251 bGwNCj4gKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIubXVsdGkvbXVsdGktdGFy Z2V0LmV4cA0KPiBAQCAtMCwwICsxLDM2MSBAQA0KPiArIyBDb3B5cmlnaHQg MjAxNy0yMDE5IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLg0KPiAr DQoNClNhbWUgaGVyZS4NCg0KUmVnYXJkcywNCi1CYXJpcw0KDQoNCkludGVs IERldXRzY2hsYW5kIEdtYkgKUmVnaXN0ZXJlZCBBZGRyZXNzOiBBbSBDYW1w ZW9uIDEwLTEyLCA4NTU3OSBOZXViaWJlcmcsIEdlcm1hbnkKVGVsOiArNDkg ODkgOTkgODg1My0wLCB3d3cuaW50ZWwuZGUKTWFuYWdpbmcgRGlyZWN0b3Jz OiBDaHJpc3RpbiBFaXNlbnNjaG1pZCwgR2FyeSBLZXJzaGF3CkNoYWlycGVy c29uIG9mIHRoZSBTdXBlcnZpc29yeSBCb2FyZDogTmljb2xlIExhdQpSZWdp c3RlcmVkIE9mZmljZTogTXVuaWNoCkNvbW1lcmNpYWwgUmVnaXN0ZXI6IEFt dHNnZXJpY2h0IE11ZW5jaGVuIEhSQiAxODY5MjgK >From gdb-patches-return-159419-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 09 17:41:37 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 48081 invoked by alias); 9 Oct 2019 17:41:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 48072 invoked by uid 89); 9 Oct 2019 17:41:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=mistakes, road X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.91) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2019 17:41:35 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 879F83059A for ; Wed, 9 Oct 2019 12:41:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IFxtiIz0PPUvSIFxtivRWj; Wed, 09 Oct 2019 12:41:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k1KmZhSVIU8AIYOSEwI/xi/XdtQd+6zy21Oo5SLL4QU=; b=Xx/DSZ7beeTqnhAO6gt5TjYC6M gzQpF7sqLmo1/X6KeSstrpcNs7wVQBx9PtRuhsrTG96xeWihDLWe8uiX7YdWZthMgkA3ukw3lVwON MhLM1gxEZD+NHIA8gCxWZ434z; Received: from 174-29-53-230.hlrn.qwest.net ([174.29.53.230]:57894 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iIFxt-002GCU-0I; Wed, 09 Oct 2019 11:41:33 -0600 From: Tom Tromey To: Weimin Pan Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 2/2] gdb: CTF support References: <1570220592-5541-1-git-send-email-weimin.pan@oracle.com> <1570220592-5541-2-git-send-email-weimin.pan@oracle.com> Date: Wed, 09 Oct 2019 17:41:00 -0000 In-Reply-To: <1570220592-5541-2-git-send-email-weimin.pan@oracle.com> (Weimin Pan's message of "Fri, 4 Oct 2019 16:23:12 -0400") Message-ID: <87ftk1erzn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00251.txt.bz2 Content-length: 1377 >>>>> Weimin Pan writes: > This patch adds the CTF (Compact Ansi-C Type Format) support in gdb. This went in by mistake, but since it was on the road to going in anyway, I guess we'll just live with that. We all make mistakes, but at the same time, please do try to be careful. > diff --git a/Makefile.def b/Makefile.def > index 6f5e881..311feb9 100644 [...] I didn't look, did the top-level changes go in to gcc? The top-level configury code is canonically maintained there. > +static const struct objfile_data *ctf_file_key; It's preferable to use the type-safe registry approach in new code. > +typedef struct ctf_context > +{ > + ctf_file_t *fp; > + struct objfile *of; > + struct buildsym_compunit *builder; > +} ctf_context_t; gdb doesn't generally use typedefs like this, especially now that it's in C++. > +/* Get text segment base for OBJFILE, TSIZE contains the segment size. */ > + > +static CORE_ADDR > +get_objfile_text_range (struct objfile *of, int *tsize) > +{ > + CORE_ADDR text_base; > + bfd *abfd = of->obfd; > + const asection *codes; > + > + codes = bfd_get_section_by_name (abfd, ".text"); Instead of this function, it's more usual in gdb to use: CORE_ADDR baseaddr = ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)); Maybe this function is even wrong in some situation, I'm not sure. Tom