From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79039 invoked by alias); 1 Oct 2019 10:19:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79030 invoked by uid 89); 1 Oct 2019 10:19:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=Board, Managing, Destroy, gary X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2019 10:19:23 +0000 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2019 03:19:20 -0700 Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga004.fm.intel.com with ESMTP; 01 Oct 2019 03:19:19 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.36]) by IRSMSX151.ger.corp.intel.com ([169.254.4.234]) with mapi id 14.03.0439.000; Tue, 1 Oct 2019 11:19:19 +0100 From: "Aktemur, Tankut Baris" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 07/23] Delete unnecessary code from kill_command Date: Tue, 01 Oct 2019 10:19:00 -0000 Message-ID: References: <20190906232807.6191-1-palves@redhat.com> <20190906232807.6191-8-palves@redhat.com> In-Reply-To: <20190906232807.6191-8-palves@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00002.txt.bz2 SGksDQoNCiogT24gU2VwdGVtYmVyIDcsIDIwMTkgMToyOCBBTSwgUGVkcm8g QWx2ZXMgd3JvdGU6DQo+DQo+IGRpZmYgLS1naXQgYS9nZGIvaW5mY21kLmMg Yi9nZGIvaW5mY21kLmMNCj4gaW5kZXggZDdhN2U2ZjkzMy4uYTEyZGJhMjNh YSAxMDA2NDQNCj4gLS0tIGEvZ2RiL2luZmNtZC5jDQo+ICsrKyBiL2dkYi9p bmZjbWQuYw0KPiBAQCAtMjUwMywyMCArMjUwMyw2IEBAIGtpbGxfY29tbWFu ZCAoY29uc3QgY2hhciAqYXJnLCBpbnQgZnJvbV90dHkpDQo+ICAgICAgcHJp bnRmX3VuZmlsdGVyZWQgKF8oIltJbmZlcmlvciAlZCAoJXMpIGtpbGxlZF1c biIpLA0KPiAgCQkgICAgICAgaW5mbnVtLCBwaWRfc3RyLmNfc3RyICgpKTsN Cj4gDQo+IC0gIC8qIElmIHdlIHN0aWxsIGhhdmUgb3RoZXIgaW5mZXJpb3Jz IHRvIGRlYnVnLCB0aGVuIGRvbid0IG1lc3Mgd2l0aA0KPiAtICAgICB3aXRo IHRoZWlyIHRocmVhZHMuICAqLw0KPiAtICBpZiAoIWhhdmVfaW5mZXJpb3Jz ICgpKQ0KPiAtICAgIHsNCj4gLSAgICAgIGluaXRfdGhyZWFkX2xpc3QgKCk7 CQkvKiBEZXN0cm95IHRocmVhZCBpbmZvLiAgKi8NCg0KUmVtb3ZpbmcgJ2lu aXRfdGhyZWFkX2xpc3QnIHNraXBzIHJlLWluaXRpYWxpemF0aW9uIG9mIHRo ZQ0KJ2hpZ2hlc3RfdGhyZWFkX251bScgZ2xvYmFsIGJhY2sgdG8gemVyby4g IEluIHR1cm4sIHRoaXMgY2F1c2VzIHRoZQ0KZm9sbG93aW5nIGZhaWx1cmU6 DQoNCiAgRkFJTDogZ2RiLmFyY2gvaTM4Ni1tcHgtc2ltcGxlX3NlZ3YuZXhw OiBwcmludCBub3Bhc3Mgc3RvcDogZGlzcGxheQ0KDQpiZWNhdXNlIHRoZSBv dXRwdXQgYmVjb21lcw0KDQogIFRocmVhZCAxICJpMzg2LW1weC1zaW1wbGUi IHJlY2VpdmVkIHNpZ25hbCBTSUdTRUdWDQoNCmluc3RlYWQgb2YNCg0KICBQ cm9ncmFtIHJlY2VpdmVkIHNpZ25hbCBTSUdTRUdWDQoNClJlZ2FyZHMsDQot QmFyaXMNCg0KDQpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJlZ2lzdGVyZWQg QWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1YmliZXJnLCBH ZXJtYW55ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3LmludGVsLmRlCk1h bmFnaW5nIERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2htaWQsIEdhcnkg S2Vyc2hhdwpDaGFpcnBlcnNvbiBvZiB0aGUgU3VwZXJ2aXNvcnkgQm9hcmQ6 IE5pY29sZSBMYXUKUmVnaXN0ZXJlZCBPZmZpY2U6IE11bmljaApDb21tZXJj aWFsIFJlZ2lzdGVyOiBBbXRzZ2VyaWNodCBNdWVuY2hlbiBIUkIgMTg2OTI4 Cg== >From gdb-patches-return-159171-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Oct 01 11:42:33 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 59139 invoked by alias); 1 Oct 2019 11:42:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 59129 invoked by uid 89); 1 Oct 2019 11:42:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=continued, ch, H*m:andrew X-HELO: mail-wr1-f42.google.com Received: from mail-wr1-f42.google.com (HELO mail-wr1-f42.google.com) (209.85.221.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2019 11:42:31 +0000 Received: by mail-wr1-f42.google.com with SMTP id n14so15070063wrw.9 for ; Tue, 01 Oct 2019 04:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CJZCfps3DLHtv8fIRXZtmOZJBgTdbNoUDdbli846uVk=; b=XKArRCVDb6sNX8UZv5vXxlmr+4PCdnyKdL8ZLIHthwmPvoSPjYMNZRf9NlRYF6OAz1 CRwBmu9nOXRtJ7llRMrgcXHlg/S9KSdSqdy7O+TdQ4DyTPD87JXxQdgsqTBYYC3t+KK3 xF9gHQmuBg9YsyLYizSnwScXkLI/frwcyvsSvQt6amm7+CP1cd1eiyjVF/SUwZv7B9g/ ZA0XpCgU8Q6Ieas0fsgv9cNs/ZHD/6ghd34wNoQZ7cmWazDSGFW6JmhUgDHknBpw1VYP e2aSwm69qYu5enNLC+gQHqR1k/UjIOYDri9bENL9zqMTxUt5sXNZWHvz5p3wiOjaccPq Nh3w== Return-Path: Received: from localhost (host86-128-12-122.range86-128.btcentralplus.com. [86.128.12.122]) by smtp.gmail.com with ESMTPSA id a10sm17345054wrm.52.2019.10.01.04.42.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Oct 2019 04:42:28 -0700 (PDT) From: Andrew Burgess To: gdb-patches Cc: Simon Marchi , Tom Tromey , markus.t.metzger@intel.com, Andrew Burgess Subject: [PATCHv5 0/3] Remove some uses of VEC Date: Tue, 01 Oct 2019 11:42:00 -0000 Message-Id: In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00003.txt.bz2 Content-length: 1387 Thank you to Markus for the continued feedback. This revision addresses the points raised against v4. - Removed helper functions, I'm convinved that the std::vector pointer should not be null at the places we dereference it. - Streamlined the removal of the vec.h header, originally I moved the include in the first patch, and removed it in the second patch. Now I leave it alone in the first patch, and delete it in the second. - I've NOT addressed the long line feedback, one line was 80+ long, while the other was 79. I'd prefer to keep both of these split over two lines. - Patch #3 is unchanged. Thanks, Andrew -- Andrew Burgess (3): gdb: Remove a VEC from gdbsupport/btrace-common.h gdb: Change a VEC to std::vector in btrace.{c,h} gdb: Remove a use of VEC from dwarf2read.{c,h} gdb/ChangeLog | 47 ++++++++++++++++++++ gdb/btrace.c | 98 +++++++++++++++++++----------------------- gdb/btrace.h | 5 +-- gdb/dwarf2read.c | 17 ++++---- gdb/dwarf2read.h | 3 -- gdb/gdbserver/ChangeLog | 5 +++ gdb/gdbserver/linux-low.c | 8 +--- gdb/gdbsupport/btrace-common.c | 18 ++++---- gdb/gdbsupport/btrace-common.h | 19 ++++---- gdb/nat/linux-btrace.c | 16 +++---- 10 files changed, 135 insertions(+), 101 deletions(-) -- 2.14.5