From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27711 invoked by alias); 14 Dec 2001 18:44:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27670 invoked from network); 14 Dec 2001 18:44:30 -0000 Received: from unknown (HELO mail-out1.apple.com) (17.254.0.52) by sources.redhat.com with SMTP; 14 Dec 2001 18:44:30 -0000 Received: from mailgate1.apple.com (A17-128-100-225.apple.com [17.128.100.225]) by mail-out1.apple.com (8.11.3/8.11.3) with ESMTP id fBEIiTu27073 for ; Fri, 14 Dec 2001 10:44:30 -0800 (PST) Received: from scv1.apple.com (scv1.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.2.1) with ESMTP id for ; Fri, 14 Dec 2001 10:44:13 -0800 Received: from [64.220.144.98] (vpn-scv-x3-12.apple.com [17.219.194.12]) by scv1.apple.com (8.11.3/8.11.3) with ESMTP id fBEIiSk04179 for ; Fri, 14 Dec 2001 10:44:29 -0800 (PST) User-Agent: Microsoft-Entourage/10.0.0.1309 Date: Fri, 14 Dec 2001 10:44:00 -0000 Subject: Re: gdb-patches Digest 9 Dec 2001 19:14:34 -0000 Issue 896 From: Jim Ingham To: Message-ID: In-Reply-To: <1007925274.29498.ezmlm@sources.redhat.com> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-SW-Source: 2001-12/txt/msg00383.txt.bz2 Andrew, This works fine for me. Looks better too. I always thought it was kind of odd that when you were emitting a table, you still sent the tags for each item, rather than just emitting the table as a list of rows, each row being just a simple list of entries. Then the client of the MI could use the header to identify the elements of each row. We could still pass in the column name into ui_out_field_x, and use it to sanity check the table as we were building it, but just not emit the tag when we are emitting the element. This would be a lot more efficient for big tables. We use a table for the shared library info on X, and it can get very big - one developer had 600 shared libraries/plugins in his app! However, PB uses the current form of the table, so I am not in a big hurry to fix this. Just something to think about. Jim > Hello, > > Hopefully (?) the attached addresses the problem JimI found with the > ui-out table code. It keeps track of the table.entry_level and uses > that to decide what to do. > > That should restrict it to updating header fields for table row entries > and not all fields. > > It doesn't cause any regressions. I need to think of a way of testing > it. Perhaphs I'll just hack my local breakpoint.c a bit. > > Andrew > -- ++=++=++=++=++=++=++=++=++=++=++=++=++=++=++=++=++=++=++= Jim Ingham jingham@apple.com Developer Tools - gdb