Re: Bug with lists in tables in ui-out.c

Jim Ingham
2001-12-03T21:49:28Z

On 11/29/01 12:20 AM, "Eli Zaretskii" <eliz@is.elta.co.il> wrote:

>
> On Wed, 28 Nov 2001, Jim Ingham wrote:
>
>> Turns out if you have an element of a table that is a list or tuple, then
>> the current ui-out table code chokes. verify_field_alignment doesn't know
>> that each of the elements of the sublist are not separate table elements, so
>> it throws an error at the first one it sees. The following patch fixes this
>> bug.
>
> Jim, could you please skim over the documentation of UI_OUT functions
> in gdbint.texinfo and see if anything there needs to be updated due to
> this patch? For example, perhaps the warnings you put in comments
> should be repeated there.
>
> Thanks.
>

Eli,

I think the only thing that needs to be added is:

Index: gdbint.texinfo
===================================================================
RCS file: /cvs/Darwin/Commands/GNU/cygnus/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.12
diff -c -w -r1.12 gdbint.texinfo
*** gdbint.texinfo 2001/11/27 17:34:09 1.12
--- gdbint.texinfo 2001/12/03 21:46:39
***************
*** 860,867 ****
even when you are listing just one object but you still want the header.

@cindex nesting level in @code{ui_out} functions
! Tables can not be nested. Tuples and lists can be nested up to a
! maximum of five levels.

The overall structure of the table output code is something like this:

--- 860,867 ----
even when you are listing just one object but you still want the header.

@cindex nesting level in @code{ui_out} functions
! Tables can not be nested, nor can a tuple or list element be a table.
! Tuples and lists can be nested up to a maximum of five levels.

The overall structure of the table output code is something like this:

The other warnings are for writers of ui_out functions, not for their users,
and as such are not really appropriate in the gdbint doc, I think. With the
suggested patch, no behaviors change, things will now just work as expected.

Jim
--
+==+==+==+==+==+==+==+==+==+==+==+==+==+==+==+==+==+==+==
Jim Ingham jingham@apple.com
Developer Tools - gdb