From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5493 invoked by alias); 3 Dec 2001 21:49:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5472 invoked from network); 3 Dec 2001 21:49:28 -0000 Received: from unknown (HELO mail-out1.apple.com) (17.254.0.52) by sources.redhat.com with SMTP; 3 Dec 2001 21:49:28 -0000 Received: from mailgate1.apple.com (A17-128-100-225.apple.com [17.128.100.225]) by mail-out1.apple.com (8.11.3/8.11.3) with ESMTP id fB3LnSu00227 for ; Mon, 3 Dec 2001 13:49:28 -0800 (PST) Received: from scv3.apple.com (scv3.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.2.1) with ESMTP id ; Mon, 3 Dec 2001 13:49:07 -0800 Received: from [17.202.40.220] (inghji.apple.com [17.202.40.220]) by scv3.apple.com (8.11.3/8.11.3) with ESMTP id fB3LnMD12569; Mon, 3 Dec 2001 13:49:22 -0800 (PST) User-Agent: Microsoft-Entourage/10.0.0.1309 Date: Mon, 03 Dec 2001 13:49:00 -0000 Subject: Re: Bug with lists in tables in ui-out.c From: Jim Ingham To: Eli Zaretskii CC: GDB Patches Message-ID: In-Reply-To: Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-SW-Source: 2001-12/txt/msg00066.txt.bz2 On 11/29/01 12:20 AM, "Eli Zaretskii" wrote: > > On Wed, 28 Nov 2001, Jim Ingham wrote: > >> Turns out if you have an element of a table that is a list or tuple, then >> the current ui-out table code chokes. verify_field_alignment doesn't know >> that each of the elements of the sublist are not separate table elements, so >> it throws an error at the first one it sees. The following patch fixes this >> bug. > > Jim, could you please skim over the documentation of UI_OUT functions > in gdbint.texinfo and see if anything there needs to be updated due to > this patch? For example, perhaps the warnings you put in comments > should be repeated there. > > Thanks. > Eli, I think the only thing that needs to be added is: Index: gdbint.texinfo =================================================================== RCS file: /cvs/Darwin/Commands/GNU/cygnus/src/gdb/doc/gdbint.texinfo,v retrieving revision 1.12 diff -c -w -r1.12 gdbint.texinfo *** gdbint.texinfo 2001/11/27 17:34:09 1.12 --- gdbint.texinfo 2001/12/03 21:46:39 *************** *** 860,867 **** even when you are listing just one object but you still want the header. @cindex nesting level in @code{ui_out} functions ! Tables can not be nested. Tuples and lists can be nested up to a ! maximum of five levels. The overall structure of the table output code is something like this: --- 860,867 ---- even when you are listing just one object but you still want the header. @cindex nesting level in @code{ui_out} functions ! Tables can not be nested, nor can a tuple or list element be a table. ! Tuples and lists can be nested up to a maximum of five levels. The overall structure of the table output code is something like this: The other warnings are for writers of ui_out functions, not for their users, and as such are not really appropriate in the gdbint doc, I think. With the suggested patch, no behaviors change, things will now just work as expected. Jim -- +==+==+==+==+==+==+==+==+==+==+==+==+==+==+==+==+==+==+== Jim Ingham jingham@apple.com Developer Tools - gdb