Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jonas Maebe <jonas.maebe@elis.ugent.be>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [patch] Fix Darwin/x86 compilation
Date: Wed, 10 Jun 2009 20:54:00 -0000	[thread overview]
Message-ID: <B829599A-1D0B-403D-B998-5D8BFC7077D6@elis.ugent.be> (raw)

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hello,

Current gdb head does not compile for Darwin due to the changes in  
this commit:

commit 60d99cc097f1fb9932bb8f52c24e4efc00a6b742
Author: Pedro Alves <pedro@codesourcery.com>
Date:   Thu May 21 15:48:41 2009 +0000

The attached patch fixes compilation for Darwin.


Jonas

2009-06-10  Jonas Maebe  <jonas.maebe@elis.ugent.be>

	Fix Darwin compilation error caused by signature change of darwin_wait.

	* darwin-nat.c (darwin_stop_inferior): Pass 0 as options to
	darwin_wait (blocking wait).
	(darwin_kill_inferior): Likewise


[-- Attachment #2: fix-darwin_wait-compilation.patch --]
[-- Type: application/octet-stream, Size: 810 bytes --]

diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index 8c20bd9..3246881 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -688,7 +688,7 @@ darwin_stop_inferior (struct target_ops *ops, darwin_inferior *inf)
   if (res != 0)
     warning (_("cannot kill: %s\n"), safe_strerror (errno));
 
-  ptid = darwin_wait (ops, inferior_ptid, &wstatus);
+  ptid = darwin_wait (ops, inferior_ptid, &wstatus, 0);
   gdb_assert (wstatus.kind = TARGET_WAITKIND_STOPPED);
 }
 
@@ -720,7 +720,7 @@ darwin_kill_inferior (struct target_ops *ops)
   kret = task_resume (darwin_inf->task);
   MACH_CHECK_ERROR (kret);
 
-  ptid = darwin_wait (ops, inferior_ptid, &wstatus);
+  ptid = darwin_wait (ops, inferior_ptid, &wstatus, 0);
 
   /* This double wait seems required...  */
   res = waitpid (darwin_inf->pid, &status, 0);

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]



             reply	other threads:[~2009-06-10 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 20:54 Jonas Maebe [this message]
2009-06-10 21:08 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B829599A-1D0B-403D-B998-5D8BFC7077D6@elis.ugent.be \
    --to=jonas.maebe@elis.ugent.be \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox