From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8962 invoked by alias); 26 Sep 2007 14:12:34 -0000 Received: (qmail 8948 invoked by uid 22791); 26 Sep 2007 14:12:34 -0000 X-Spam-Check-By: sourceware.org Received: from cypress.ugent.be (HELO cypress.ugent.be) (157.193.71.48) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 26 Sep 2007 14:12:28 +0000 Received: from bonobo.ugent.be (HELO localhost) ([157.193.71.53]) by cypress.ugent.be with ESMTP; 26 Sep 2007 16:12:25 +0200 Received: from cypress.ugent.be ([157.193.71.48]) by localhost (bonobo.UGent.be [157.193.43.11]) (amavisd-new, port 10024) with ESMTP id 00873-02-5; Wed, 26 Sep 2007 16:12:25 +0200 (CEST) Received: from mail.elis.ugent.be ([157.193.206.48]) by cypress.ugent.be with ESMTP; 26 Sep 2007 16:12:25 +0200 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CABYF+kadwc4w/2dsb2JhbAA Received: from localhost (localhost [127.0.0.1]) by mail.elis.UGent.be (Postfix) with ESMTP id 997FD2BAC04; Wed, 26 Sep 2007 16:12:24 +0200 (CEST) Received: from [157.193.206.33] (bigmac.elis.UGent.be [157.193.206.33]) by mail.elis.UGent.be (Postfix) with ESMTP id 9324D2BABFD; Wed, 26 Sep 2007 16:12:24 +0200 (CEST) In-Reply-To: References: <002f01c80038$5881a880$0984f980$@u-strasbg.fr> <36AA51D7-8F6A-41D6-82F2-5E837D169AB9@freepascal.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Cc: muller@ics.u-strasbg.fr, gdb-patches@sourceware.org Content-Transfer-Encoding: 7bit From: Jonas Maebe Subject: Re: [PATCH] Fix PR pascal/2283 Date: Wed, 26 Sep 2007 14:12:00 -0000 To: Eli Zaretskii X-Mailer: Apple Mail (2.752.2) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00368.txt.bz2 On 26 Sep 2007, at 16:07, Eli Zaretskii wrote: >> Cc: "Pierre Muller" , >> gdb-patches@sourceware.org >> From: Jonas Maebe >> Date: Wed, 26 Sep 2007 16:03:13 +0200 >> >> In fact, I have no idea why that code (in both the Pascal and >> Modula-2 cases) even checks the current language, as those routines >> are obviously language-specific. > > Exactly! If this code is Pascal-specific, you shouldn't be checking > the language at all. In that case, the Modula-2 version shouldn't either. But I'm far too unfamiliar with the gdb source base to be able to assess whether it is in fact correct and safe to remove those checks. Jonas