From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9803 invoked by alias); 22 Jan 2020 14:26:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9794 invoked by uid 89); 22 Jan 2020 14:26:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy= X-HELO: EUR05-AM6-obe.outbound.protection.outlook.com Received: from mail-am6eur05on2056.outbound.protection.outlook.com (HELO EUR05-AM6-obe.outbound.protection.outlook.com) (40.107.22.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Jan 2020 14:26:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LkDAuqhm7TgOVJKH/OwxpuXJ96+jKBhVtQtuY5N6PV0=; b=HiuQ36U0TJSx3NnLNNnVpt3ADRaWHJGMoa8jocTZwzO6+UdQUrwjBXrEL9F0h5mX87YrI45MrsD130nAuYg6Ugbw6Dq6z5HOAFXUWq68W1iFLPAYYnoQO1VlP1ve5CH6/rC1OVZo2tyVin/hxYbcWQe8TwhY6NoEzo9B4/ukKpk= Received: from VI1PR08CA0183.eurprd08.prod.outlook.com (2603:10a6:800:d2::13) by AM7PR08MB5480.eurprd08.prod.outlook.com (2603:10a6:20b:de::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.19; Wed, 22 Jan 2020 14:26:52 +0000 Received: from VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::204) by VI1PR08CA0183.outlook.office365.com (2603:10a6:800:d2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.20 via Frontend Transport; Wed, 22 Jan 2020 14:26:52 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT019.mail.protection.outlook.com (10.152.18.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.18 via Frontend Transport; Wed, 22 Jan 2020 14:26:52 +0000 Received: ("Tessian outbound ca1df68f3668:v40"); Wed, 22 Jan 2020 14:26:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e8a08e26d2406ae8 X-CR-MTA-TID: 64aa7808 Received: from 6addd91e4c96.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A8A2C058-1F3F-4CFF-822A-129852D0DF78.1; Wed, 22 Jan 2020 14:26:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6addd91e4c96.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 22 Jan 2020 14:26:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Odn1+uEkFgdFwzwEzFWaYmgG8ml3rGjHJeb00WULEKYujipNEgJjCa0/rqHus9oJaUT2Pv4oTXyAsCsJa2gykWhU7ui+M1QXmfWi4+iRwydpE1S8K8WQuNVOrWJ+eD9s263Dtc/E/aWxkPnif4niFMJqY/6b3sk8tMvgmlusF8XiEEiaIYzQ8t+2j4tm2G8WtGGdbW8zSiMTRT7HNsGtl0jnrTM/XsTz9sxozuQVNeHq7XN8ylXKBGR4T6HocwstBeGhqXYdorZxFjQ13/XP0WSu/Rq1CVkc+kjMMVFyTo8w+/9qIEydDXzrGSrm8NDj1q93EIdergy6RL/jHwvbZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LkDAuqhm7TgOVJKH/OwxpuXJ96+jKBhVtQtuY5N6PV0=; b=CqQVqltNjvw+Zh4KoN4A4PPKM+IiHbTHd0/RuRJ5rEIaKc78GuxG7d1XW0iduJXyeif7wlDUsLpeLp5fZ1Z5Tg16K9qhGMa2stRpmoxG8+H+VkV0O+grPAd0OOgVJCE+zGUnX8MShsY9moJ811keGWlz2ilYeS50JFf3KPxeSMkEdkSIGYtMnuOnacD7d77NFyzpzMF17hchHc5TzvlAEMCMj3SyCwEHAC+C/Ch/9u7L5N0kkIHwFsfEXk1DggTsEG4AoEevK8tNcHRalIfrycDYrrLGRb6+73gizh+JHJHAsg9IgQJfsFZv/ykckNTgX9bueIot1LPEDB3zSR+PEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LkDAuqhm7TgOVJKH/OwxpuXJ96+jKBhVtQtuY5N6PV0=; b=HiuQ36U0TJSx3NnLNNnVpt3ADRaWHJGMoa8jocTZwzO6+UdQUrwjBXrEL9F0h5mX87YrI45MrsD130nAuYg6Ugbw6Dq6z5HOAFXUWq68W1iFLPAYYnoQO1VlP1ve5CH6/rC1OVZo2tyVin/hxYbcWQe8TwhY6NoEzo9B4/ukKpk= Received: from AM0PR08MB5330.eurprd08.prod.outlook.com (52.132.212.151) by AM0PR08MB5233.eurprd08.prod.outlook.com (10.255.31.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.19; Wed, 22 Jan 2020 14:26:44 +0000 Received: from AM0PR08MB5330.eurprd08.prod.outlook.com ([fe80::89cf:a33e:c415:d30]) by AM0PR08MB5330.eurprd08.prod.outlook.com ([fe80::89cf:a33e:c415:d30%6]) with mapi id 15.20.2644.028; Wed, 22 Jan 2020 14:26:44 +0000 From: Alan Hayward To: Luis Machado CC: "gdb-patches\\@sourceware.org" , nd Subject: Re: [PING] [PATCH] Harden gdb.base/step-over-syscall.exp Date: Wed, 22 Jan 2020 14:45:00 -0000 Message-ID: References: <20200115203645.26360-1-luis.machado@linaro.org> In-Reply-To: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10001)(10009020)(4636009)(396003)(366004)(39860400002)(376002)(346002)(136003)(189003)(199004)(6916009)(316002)(6512007)(8936002)(91956017)(54906003)(6486002)(76116006)(66446008)(66476007)(66946007)(33656002)(66556008)(64756008)(4326008)(26005)(186003)(55236004)(53546011)(8676002)(6506007)(478600001)(966005)(2616005)(71200400001)(36756003)(81166006)(2906002)(86362001)(81156014)(5660300002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB5233;H:AM0PR08MB5330.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: n1KUD8HarV2/mXs3ExeT33CiuUyZ6TSkJ74WnO3HRMcxPP4ZY4gizP5iJfUoYEIJAHjtef3GocjQVHDY4IB8FLczAG2z0mOnBlX0O9WZ/1TFMrVKq97eQVDhUqe609FZz75/6Wx29VK4QXAnMRn16gH46ZUmsMFAz39ype4cMtdLRiJ+uO4LXy8HmED/qGwdCHAyp97JoA18pFYI/7gXMNd6363raQ6qR4hvr90uze8WeWQ1J8hKjJNcilMuDFWPfWudX+NQ6E9nTDz5+E69f97uJHV+tGBn59GiCecStz0bvBI7GNlHMg1fTFOSOj6G8TDN7HYdNXRtVz/z4NvWO5PeidhDDBs0cJEEUR2rXzzlVTMJ19ounXMDEL/vklDL5UMJUR2Wq0wM4B74GKWLWJ2y/xRyWPf6vuP7X7dtSp8R35xJhgGmrD7dpxqyhxN/B1ZVOQsW4UrMKv9K1AV+F4j+2z9/8b6w63IDb06LFGWLxl9gWuh38PGBHL8Ynird/Yb1/ZZmLs0BgfjJXyehmwMFn9seAo/pbkEFMg/yXGk= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <94C28550E547EF4B81F57BD2ED648DF5@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: bd7a0a31-7952-4f94-bc5e-08d79f471b0b X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00674.txt.bz2 DQoNCj4gT24gMjIgSmFuIDIwMjAsIGF0IDEzOjMwLCBMdWlzIE1hY2hhZG8g PGx1aXMubWFjaGFkb0BsaW5hcm8ub3JnPiB3cm90ZToNCj4gDQo+IHBpbmc/ DQo+IA0KPiBodHRwczovL3NvdXJjZXdhcmUub3JnL21sL2dkYi1wYXRjaGVz LzIwMjAtMDEvbXNnMDA0MzIuaHRtbA0KPiANCj4gT24gMS8xNS8yMCA1OjM2 IFBNLCBMdWlzIE1hY2hhZG8gd3JvdGU6DQo+PiBUaGVyZSBhcmUgYSBjb3Vw bGUgcHJvYmxlbXMgd2l0aCB0aGlzIHRlc3QuDQo+PiBGaXJzdA0KPj4gLS0N Cj4+IGdkYi5iYXNlL3N0ZXAtb3Zlci1zeXNjYWxsLmV4cCByZWNvcmRzIHRo ZSBhZGRyZXNzIG9mIGEgc3lzY2FsbCBpbnN0cnVjdGlvbg0KPj4gd2l0aGlu IGZvcmsvdmZvcmsvY2xvbmUgZnVuY3Rpb25zIGFuZCBhbHNvIHRoZSBhZGRy ZXNzIG9mIHRoZSBpbnN0cnVjdGlvbg0KPj4gYWZ0ZXIgdGhhdCBzeXNjYWxs IGluc3RydWN0aW9uLg0KPj4gSXQgdXNlcyB0aGVzZSBjb3VwbGVzIGFkZHJl c3NlcyB0byBtYWtlIHN1cmUgd2Ugc3RlcHBlZCBvdmVyIGEgc3lzY2FsbA0K Pj4gaW5zdHJ1Y3Rpb24gKGZvcmsvdmZvcmsvY2xvbmUgZXZlbnRzKSBjb3Jy ZWN0bHkuDQo+PiBUaGUgd2F5IHRoZSB0ZXN0IGZldGNoZXMgdGhlIGFkZHJl c3NlcyBvZiB0aGUgaW5zdHJ1Y3Rpb25zIGlzIGJ5IHN0ZXBpLWluZw0KPj4g aXRzIHdheSB0aHJvdWdoIHRoZSBmb3JrL3Zmb3JrL2Nsb25lIGZ1bmN0aW9u cyB1bnRpbCBpdCBmaW5kcyBhIG1hdGNoIGZvcg0KPj4gYSBzeXNjYWxsLiBU aGVuIGl0IHN0ZXBpJ3Mgb25jZSBhZ2FpbiB0byBnZXQgdGhlIGFkZHJlc3Mg b2YgdGhlIG5leHQNCj4+IGluc3RydWN0aW9uLg0KPj4gVGhpcyBhc3N1bWVz IHRoYXQgc3RlcGktaW5nIG92ZXIgYSBzeXNjYWxsIGlzIHdvcmtpbmcgY29y cmVjdGx5IGFuZCBsYW5kaW5nDQo+PiBpbiB0aGUgcmlnaHQgUEMuIFRoaXMg aXMgbm90IHRoZSBjYXNlIGZvciBBQXJjaDY0L0xpbnV4LCB3aGVyZSB3ZSdy ZQ0KPj4gbGFuZGluZyBhIGNvdXBsZSBpbnN0cnVjdGlvbnMgYWZ0ZXIgdGhl IHN5c2NhbGwgaW4gc29tZSBjYXNlcy4NCj4+IFRoZSBmb2xsb3dpbmcgcGF0 Y2ggbGV0cyB0aGUgdGVzdCBleGVjdXRlIGFzIGJlZm9yZSwgYnV0IGFkZHMg YSBuZXcgaW5zdHJ1Y3Rpb24NCj4+IGFkZHJlc3MgY2hlY2sgdXNpbmcgdGhl IHggY29tbWFuZCBhcyBvcHBvc2VkIHRvIHN0ZXBpLg0KPj4gSSBkaWRuJ3Qg d2FudCB0byBjaGFuZ2UgaG93IHRoZSB0ZXN0IHdvcmtzIHNpbmNlIHdlIG1h eSBhbHNvIGJlDQo+PiBpbnRlcmVzdGVkIGluIGNoZWNraW5nIGlmIHN0ZXBp LWluZyBvdmVyIHRoZSBzeXNjYWxsIHVuZGVyIGRpZmZlcmVudA0KPj4gY29u ZGl0aW9ucyAoZGlzcGxhY2VkIHN0ZXBwaW5nIG9uL29mZikgeWllbGRzIHRo ZSBzYW1lIHJlc3VsdHMuIEkgZG9uJ3QNCj4+IGZlZWwgc3Ryb25nbHkgYWJv dXQgdGhpcywgc28gaSdtIE9LIHdpdGggY2hhbmdpbmcgaG93IHdlIGNvbXBh cmUgUEMncyBmb3INCj4+IHRoZSBlbnRpcmUgdGVzdCBpZiBmb2xrcyBkZWNp ZGUgaXQgaXMgcmVhc29uYWJsZS4NCg0KSeKAmW0gaGFwcHkgd2l0aCBsZWF2 aW5nIGl0IHRoaXMgd2F5IHRvby4NCg0KPj4gU2Vjb25kDQo+PiAtLQ0KPj4g RkFJTDogZ2RiLmJhc2Uvc3RlcC1vdmVyLXN5c2NhbGwuZXhwOiB2Zm9yazog ZGlzcGxhY2VkPW9mZjogY29udGludWUgdG8gdmZvcmsgKDNyZCB0aW1lKSAo dGhlIHByb2dyYW0gZXhpdGVkKQ0KPj4gRkFJTDogZ2RiLmJhc2Uvc3RlcC1v dmVyLXN5c2NhbGwuZXhwOiB2Zm9yazogZGlzcGxhY2VkPW9mZjogY29udGlu dWUgdG8gc3lzY2FsbCBpbnNuIHZmb3JrICh0aGUgcHJvZ3JhbSBpcyBubyBs b25nZXIgcnVubmluZykNCj4+IEZBSUw6IGdkYi5iYXNlL3N0ZXAtb3Zlci1z eXNjYWxsLmV4cDogdmZvcms6IGRpc3BsYWNlZD1vZmY6IHNpbmdsZSBzdGVw IG92ZXIgdmZvcmsgKHRoZSBwcm9ncmFtIGlzIG5vIGxvbmdlciBydW5uaW5n KQ0KPj4gRGVwZW5kaW5nIG9uIHRoZSBnbGliYyB2ZXJzaW9uIHdlIG1heSBo YXZlIGRpZmZlcmVudCBjb2RlIGdlbmVyYXRlZCBmb3IgdGhlDQo+PiBmb3Jr L3Zmb3JrL2Nsb25lIGZ1bmN0aW9ucy4NCj4+IEkgcmFuIGludG8gdGhlIHNp dHVhdGlvbiB3aGVyZSB2Zm9yayBmb3IgbmV3ZXIgZ2xpYmMncyBvbiBBQXJj aDY0L0xpbnV4IGlzDQo+PiB2ZXJ5IHNob3J0LCBzbyAiYnJlYWsgdmZvcmsi IHdpbGwgcHV0IGEgYnJlYWtwb2ludCByaWdodCBhdCB0aGUgc3lzY2FsbA0K Pj4gaW5zdHJ1Y3Rpb24sIHdoaWNoIGlzIHNvbWV0aGluZyB0aGUgdGVzdGNh c2UgaXNuJ3QgZXhwZWN0aW5nIChhIG9mZi1ieS0xDQo+PiBvZiBzb3J0cyku DQo+PiBUaGUgcGF0Y2ggYWRkcyBleHRyYSBjb2RlIHRvIGhhbmRsZSB0aGlz IGNhc2UuIElmIHRoZSB0ZXN0IGRldGVjdHMgd2UncmUNCj4+IGFscmVhZHkg c2l0dGluZyBhdCBhIHN5c2NhbGwgaW5zdHJ1Y3Rpb24sIGl0IHJlY29yZHMg dGhlIGFkZHJlc3MgYW5kIG1vdmVzDQo+PiBvbiB0byByZWNvcmQgdGhlIGFk ZHJlc3MgYWZ0ZXIgdGhhdCBwYXJ0aWN1bGFyIGluc3RydWN0aW9uLg0KPj4g QW5vdGhlciBtZWFzdXJlIGlzIHRvICJicmVhayAqJHN5c2NhbGwiIGluc3Rl YWQgb2YgImJyZWFrICRzeXNjYWxsIi4gVGhhdA0KPj4gZ3VhcmFudGVlcyB3 ZSdyZSBzdG9wcGluZyBhdCB0aGUgZmlyc3QgaW5zdHJ1Y3Rpb24gb2YgdGhl IHN5c2NhbGwgZnVuY3Rpb24sDQo+PiBpZiBpdCBldmVyIGhhcHBlbnMgdGhh dCB0aGUgc3lzY2FsbCBpbnN0cnVjdGlvbiBpcyB0aGUgZmlyc3QgaW5zdHJ1 Y3Rpb24gb2YNCj4+IHRob3NlIGZ1bmN0aW9ucy4NCj4+IFdpdGggdGhlc2Ug Y2hhbmdlcyBpIGNhbiBmaXggc29tZSBmYWlsdXJlcyBmb3IgYWFyY2g2NC1s aW51eC1nbnUgYW5kIGFsc28NCj4+IGV4cG9zZSB0aGUgcHJvYmxlbXMgaSd2 ZSByZXBvcnRlZCBoZXJlOg0KPj4gaHR0cHM6Ly9zb3VyY2V3YXJlLm9yZy9t bC9nZGItcGF0Y2hlcy8yMDE5LTEyL21zZzAxMDcxLmh0bWwNCj4+IFRoZXNl IHRlc3RzIG5vdyBmYWlsIGZvciBhYXJjaDY0LWxpbnV4LWdudSAocGF0Y2gg Zm9yIHRoaXMgaXMgZ29pbmcgdGhyb3VnaA0KPj4gcmV2aWV3cyk6DQo+PiBG QUlMOiBnZGIuYmFzZS9zdGVwLW92ZXItc3lzY2FsbC5leHA6IHZmb3JrOiBk aXNwbGFjZWQ9b2ZmOiBwYyBhZnRlciBzdGVwaSBtYXRjaGVzIGluc24gYWRk ciBhZnRlciBzeXNjYWxsDQo+PiBGQUlMOiBnZGIuYmFzZS9zdGVwLW92ZXIt c3lzY2FsbC5leHA6IHZmb3JrOiBkaXNwbGFjZWQ9b246IHBjIGFmdGVyIHN0 ZXBpIG1hdGNoZXMgaW5zbiBhZGRyIGFmdGVyIHN5c2NhbGwNCj4+IEkndmUg cXVldWVkIGEgdGVzdCBydW4gb24gdGhlIGJ1aWxkYm90IHRvIG1ha2Ugc3Vy ZSB0aGluZ3MgYXJlIHNhbmUgZm9yIG90aGVyDQo+PiBhcmNoaXRlY3R1cmVz LCBhbmQgaSd2ZSB0ZXN0ZWQgaXQgb24gYWFyY2g2NC1saW51eC1nbnUuDQo+ PiBnZGIvdGVzdHN1aXRlL0NoYW5nZUxvZzoNCj4+IDIwMjAtMDEtMTUgIEx1 aXMgTWFjaGFkbyAgPGx1aXMubWFjaGFkb0BsaW5hcm8ub3JnPg0KPj4gCSog Z2RiLmJhc2Uvc3RlcC1vdmVyLXN5c2NhbGwuZXhwIChzZXR1cCk6IENoZWNr IGlmIHdlJ3JlIGFscmVhZHkNCj4+IAlzaXR0aW5nIGF0IGEgc3lzY2FsbCBp bnN0cnVjdGlvbiB3aGVuIHdlIGhpdCB0aGUgc3lzY2FsbCBmdW5jdGlvbidz DQo+PiAJYnJlYWtwb2ludC4NCj4+IAlDaGVjayBQQyBhZ2FpbnN0IG9uZSBv YnRhaW5lZCB3aXRoIHRoZSB4IGNvbW1hbmQuDQo+PiAJKHN0ZXBfb3Zlcl9z eXNjYWxsKTogRG9uJ3QgY29udGludWUgdG8gdGhlIHN5c2NhbGwgaW5zdHJ1 Y3Rpb24gaWYNCj4+IAl3ZSdyZSBhbHJlYWR5IHRoZXJlLg0KPj4gLS0tDQo+ PiAgZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9zdGVwLW92ZXItc3lzY2FsbC5l eHAgfCA5MSArKysrKysrKysrKysrKy0tLS0tLQ0KPj4gIDEgZmlsZSBjaGFu Z2VkLCA2NiBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkNCj4+IGRp ZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL3N0ZXAtb3Zlci1z eXNjYWxsLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2Uvc3RlcC1vdmVy LXN5c2NhbGwuZXhwDQo+PiBpbmRleCBiMzczYzE2OWMwLi40ZDk0ODhiMWQ0 IDEwMDY0NA0KPj4gLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9zdGVw LW92ZXItc3lzY2FsbC5leHANCj4+ICsrKyBiL2dkYi90ZXN0c3VpdGUvZ2Ri LmJhc2Uvc3RlcC1vdmVyLXN5c2NhbGwuZXhwDQo+PiBAQCAtNDYsNyArNDYs OCBAQCBwcm9jX3dpdGhfcHJlZml4IGNoZWNrX3BjX2FmdGVyX2Nyb3NzX3N5 c2NhbGwgeyBzeXNjYWxsIHN5c2NhbGxfaW5zbl9uZXh0X2FkZHIgfQ0KPj4g ICAgcHJvYyBzZXR1cCB7IHN5c2NhbGwgfSB7DQo+PiAgICAgIGdsb2JhbCBn ZGJfcHJvbXB0IHN5c2NhbGxfaW5zbg0KPj4gLQ0KPj4gKyAgICBnbG9iYWwg aGV4DQo+PiArICAgIHNldCBuZXh0X2luc25fYWRkciAwDQo+PiAgICAgIHNl dCB0ZXN0ZmlsZSAic3RlcC1vdmVyLSRzeXNjYWxsIg0KPj4gICAgICAgIGNs ZWFuX3Jlc3RhcnQgJHRlc3RmaWxlDQo+PiBAQCAtNjIsNyArNjMsNyBAQCBw cm9jIHNldHVwIHsgc3lzY2FsbCB9IHsNCj4+ICAgICAgZ2RiX3Rlc3Rfbm9f b3V0cHV0ICJzZXQgZGlzcGxhY2VkLXN0ZXBwaW5nIG9mZiIgXA0KPj4gIAki c2V0IGRpc3BsYWNlZC1zdGVwcGluZyBvZmYgZHVyaW5nIHRlc3Qgc2V0dXAi DQo+PiAgLSAgICBnZGJfdGVzdCAiYnJlYWsgJHN5c2NhbGwiICJCcmVha3Bv aW50IFxbMC05XF0qIGF0IC4qIg0KPj4gKyAgICBnZGJfdGVzdCAiYnJlYWsg XCokc3lzY2FsbCIgIkJyZWFrcG9pbnQgXFswLTlcXSogYXQgLioiDQo+PiAg ICAgICAgZ2RiX3Rlc3QgImNvbnRpbnVlIiAiQ29udGludWluZ1xcLi4qQnJl YWtwb2ludCBcWzAtOVxdKywgKC4qIGluIHxfX2xpYmNffCkkc3lzY2FsbCBc XChcXCkuKiIgXA0KPj4gIAkiY29udGludWUgdG8gJHN5c2NhbGwgKDFzdCB0 aW1lKSINCj4+IEBAIC03NSwzNyArNzYsNzIgQEAgcHJvYyBzZXR1cCB7IHN5 c2NhbGwgfSB7DQo+PiAgICAgICMgSGl0IHRoZSBicmVha3BvaW50IG9uICRz eXNjYWxsIGZvciB0aGUgc2Vjb25kIHRpbWUuICBJbiB0aGlzIHRpbWUsDQo+ PiAgICAgICMgdGhlIGFkZHJlc3Mgb2Ygc3lzY2FsbCBpbnNuIGFuZCBuZXh0 IGluc24gb2Ygc3lzY2FsbCBhcmUgcmVjb3JkZWQuDQo+PiAgLSAgICBnZGJf dGVzdCAiZGlzcGxheS9pIFwkcGMiICIuKiINCj4+IC0NCj4+IC0gICAgIyBT aW5nbGUgc3RlcCB1bnRpbCB3ZSBzZWUgYSBzeXNjYWxsIGluc24gb3Igd2Ug cmVhY2ggdGhlDQo+PiAtICAgICMgdXBwZXIgYm91bmQgb2YgbG9vcCBpdGVy YXRpb25zLg0KPj4gLSAgICBzZXQgbXNnICJmaW5kIHN5c2NhbGwgaW5zbiBp biAkc3lzY2FsbCINCj4+IC0gICAgc2V0IHN0ZXBzIDANCj4+IC0gICAgc2V0 IG1heF9zdGVwcyAxMDAwDQo+PiAtICAgIGdkYl90ZXN0X211bHRpcGxlICJz dGVwaSIgJG1zZyB7DQo+PiAtCS1yZSAiLiokc3lzY2FsbF9pbnNuLiokZ2Ri X3Byb21wdCAkIiB7DQo+PiAtCSAgICBwYXNzICRtc2cNCj4+ICsgICAgIyBD aGVjayBpZiB0aGUgZmlyc3QgaW5zdHJ1Y3Rpb24gd2Ugc3RvcHBlZCBhdCBp cyB0aGUgc3lzY2FsbCBvbmUuDQo+PiArICAgIHNldCBzeXNjYWxsX2luc25f YWRkciAwDQo+PiArICAgIHNldCB0ZXN0ICJmZXRjaCBmaXJzdCBzdG9wIHBj Ig0KPj4gKyAgICBnZGJfdGVzdF9tdWx0aXBsZSAiZGlzcGxheS9pIFwkcGMi ICR0ZXN0IHsNCg0KSSBkb27igJl0IGxpa2UgdGhlIHVzZSBvZiBkaXNwbGF5 L2kgaGVyZSBiZWNhdXNlIGl0IHdpbGwgYmUgZGlzcGxheWluZyB0aGUgcGMg YWZ0ZXINCmV2ZXJ5IGNvbW1hbmQsIHNvIGNvdWxkIGJyZWFrIG90aGVyIHRl c3RzLiBBbHRlcm5hdGl2ZWx5LCB5b3UgY291bGQgc3RlcGkgdGhlbiB4L2kg JHBjLg0KSG93ZXZlciwgdGhlIHRlc3QgYWxyZWFkeSB3b3JrZWQgdGhpcyB3 YXksIHNvIEnigJltIG9rIHdpdGggaXQuDQoNCj4+ICsJLXJlICJkaXNwbGF5 L2kgLio6IHgvaSAuKj0+ICgkaGV4KSAuKjouKiRzeXNjYWxsX2luc24uKiRn ZGJfcHJvbXB0ICQiIHsNCj4+ICsJICAgIHNldCBzeXNjYWxsX2luc25fYWRk ciAkZXhwZWN0X291dCgxLHN0cmluZykNCj4+ICsJICAgIHBhc3MgJHRlc3QN Cj4+ICAJfQ0KPj4gLQktcmUgIngvaSAuKj0+LipcclxuJGdkYl9wcm9tcHQg JCIgew0KPj4gLQkgICAgaW5jciBzdGVwcw0KPj4gLQkgICAgaWYgeyRzdGVw cyA9PSAkbWF4X3N0ZXBzfSB7DQo+PiAtCQlmYWlsICRtc2cNCj4+IC0JICAg IH0gZWxzZSB7DQo+PiAtCQlzZW5kX2dkYiAic3RlcGlcbiINCj4+IC0JCWV4 cF9jb250aW51ZQ0KPj4gKwktcmUgImRpc3BsYXkvaS4qIiB7DQo+PiArCSAg ICBwYXNzICR0ZXN0DQo+PiArCX0NCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAg ICAjIElmIHdlIGFyZSBub3QgYXQgdGhlIHN5c2NhbGwgaW5zdHJ1Y3Rpb24g eWV0LCBrZWVwIGxvb2tpbmcgZm9yIGl0IHdpdGgNCj4+ICsgICAgIyBzdGVw aSBjb21tYW5kcy4NCj4+ICsgICAgaWYgeyRzeXNjYWxsX2luc25fYWRkciA9 PSAwfSB7DQo+PiArCSMgU2luZ2xlIHN0ZXAgdW50aWwgd2Ugc2VlIGEgc3lz Y2FsbCBpbnNuIG9yIHdlIHJlYWNoIHRoZQ0KPj4gKwkjIHVwcGVyIGJvdW5k IG9mIGxvb3AgaXRlcmF0aW9ucy4NCj4+ICsJc2V0IG1zZyAiZmluZCBzeXNj YWxsIGluc24gaW4gJHN5c2NhbGwiDQo+PiArCXNldCBzdGVwcyAwDQo+PiAr CXNldCBtYXhfc3RlcHMgMTAwMA0KPj4gKwlnZGJfdGVzdF9tdWx0aXBsZSAi c3RlcGkiICRtc2cgew0KPj4gKwkgICAgLXJlICIuKiRzeXNjYWxsX2luc24u KiRnZGJfcHJvbXB0ICQiIHsNCj4+ICsJCXBhc3MgJG1zZw0KPj4gKwkgICAg fQ0KPj4gKwkgICAgLXJlICJ4L2kgLio9Pi4qXHJcbiRnZGJfcHJvbXB0ICQi IHsNCj4+ICsJCWluY3Igc3RlcHMNCj4+ICsJCWlmIHskc3RlcHMgPT0gJG1h eF9zdGVwc30gew0KPj4gKwkJICAgIGZhaWwgJG1zZw0KPj4gKwkJfSBlbHNl IHsNCj4+ICsJCSAgICBzZW5kX2dkYiAic3RlcGlcbiINCj4+ICsJCSAgICBl eHBfY29udGludWUNCj4+ICsJCX0NCj4+ICAJICAgIH0NCj4+ICAJfQ0KPj4g Kw0KPj4gKwlpZiB7JHN0ZXBzID09ICRtYXhfc3RlcHN9IHsNCj4+ICsJICAg IHJldHVybiB7IC0xLCAtMSB9DQo+PiArCX0NCj4+ICsNCj4+ICsJc2V0IHN5 c2NhbGxfaW5zbl9hZGRyIFtnZXRfaGV4YWRlY2ltYWxfdmFsdWVvZiAiXCRw YyIgIjAiIFwNCj4+ICsJCQkJICAicGMgYmVmb3JlIHN0ZXBpIl0NCj4+ICAg ICAgfQ0KPj4gIC0gICAgaWYgeyRzdGVwcyA9PSAkbWF4X3N0ZXBzfSB7DQo+ PiAtCXJldHVybiB7IC0xLCAtMSB9DQo+PiArICAgICMgV2UgaGF2ZSBmb3Vu ZCB0aGUgc3lzY2FsbCBpbnN0cnVjdGlvbi4gIE5vdyByZWNvcmQgdGhlIG5l eHQgaW5zdHJ1Y3Rpb24uDQo+PiArICAgICMgVXNlIHRoZSBYIGNvbW1hbmQg aW5zdGVhZCBvZiBzdGVwaSBzaW5jZSB3ZSBjYW4ndCBndWFyYW50ZWUNCj4+ ICsgICAgIyBzdGVwaSBpcyB3b3JraW5nIHByb3Blcmx5Lg0KPj4gKyAgICBz ZXQgdGVzdCAicGMgYWZ0ZXIgc3lzY2FsbCBpbnN0cnVjdGlvbiINCj4+ICsg ICAgZ2RiX3Rlc3RfbXVsdGlwbGUgIngvMmkgXCRwYyIgJHRlc3Qgew0KPj4g KwktcmUgIngvMmkgLio9PiAkaGV4IC4qOi4qJHN5c2NhbGxfaW5zbi4qICgk aGV4KSAuKjouKiRnZGJfcHJvbXB0ICQiIHsNCj4+ICsJICAgIHNldCBuZXh0 X2luc25fYWRkciAkZXhwZWN0X291dCgyLHN0cmluZykNCj4+ICsJICAgIHBh c3MgJHRlc3QNCj4+ICsJfQ0KPj4gICAgICB9DQo+PiAgLSAgICBzZXQgc3lz Y2FsbF9pbnNuX2FkZHIgW2dldF9oZXhhZGVjaW1hbF92YWx1ZW9mICJcJHBj IiAiMCIgXA0KPj4gLQkJCSAgICAgICAicGMgYmVmb3JlIHN0ZXBpIl0NCj4+ ICAgICAgaWYge1tnZGJfdGVzdCAic3RlcGkiICJ4L2kgLio9Pi4qIiAic3Rl cGkgJHN5c2NhbGwgaW5zbiJdICE9IDB9IHsNCj4+ICAJcmV0dXJuIHsgLTEs IC0xIH0NCj4+ICAgICAgfQ0KPj4gKw0KPj4gKyAgICBzZXQgcGNfYWZ0ZXJf c3RlcGkgW2dldF9oZXhhZGVjaW1hbF92YWx1ZW9mICJcJHBjIiAiMCIgXA0K Pj4gKwkJCSAgICAicGMgYWZ0ZXIgc3RlcGkgd2l0aCB4IGNvbW1hbmQiXQ0K Pj4gKw0KPj4gKyAgICBpZiB7JG5leHRfaW5zbl9hZGRyICE9ICRwY19hZnRl cl9zdGVwaX0gew0KPj4gKyAgICAgIGZhaWwgInBjIGFmdGVyIHN0ZXBpIG1h dGNoZXMgaW5zbiBhZGRyIGFmdGVyIHN5c2NhbGwiDQo+PiArICAgIH0NCj4+ ICsNCj4+ICAgICAgcmV0dXJuIFtsaXN0ICRzeXNjYWxsX2luc25fYWRkciBb Z2V0X2hleGFkZWNpbWFsX3ZhbHVlb2YgIlwkcGMiIFwNCj4+ICAJCQkJCSAi MCIgInBjIGFmdGVyIHN0ZXBpIl1dDQoNCk1pbm9yIG5pdC4gSW4gdGhlIHJl dHVybiwgeW91IGNvdWxkIGp1c3QgdXNlICRuZXh0X2luc25fYWRkciBpbnN0 ZWFkIG9mDQpjYWxsaW5nIGdldF9oZXhhZGVjaW1hbF92YWx1ZW9mIGFnYWlu Lg0KDQo+PiAgfQ0KPj4gQEAgLTE1Niw4ICsxOTIsMTMgQEAgcHJvYyBzdGVw X292ZXJfc3lzY2FsbCB7IHN5c2NhbGwgfSB7DQo+PiAgCQl9DQo+PiAgCSAg ICB9DQo+PiAgLQkgICAgZ2RiX3Rlc3QgImNvbnRpbnVlIiAiQ29udGludWlu Z1xcLi4qQnJlYWtwb2ludCBcWzAtOVxdKywgLioiIFwNCj4+IC0JCSJjb250 aW51ZSB0byBzeXNjYWxsIGluc24gJHN5c2NhbGwiDQo+PiArCSAgICAjIENo ZWNrIGlmIHRoZSBzeXNjYWxsIGJyZWFrcG9pbnQgaXMgYXQgdGhlIHN5c2Nh bGwgaW5zdHJ1Y3Rpb24NCj4+ICsJICAgICMgYWRkcmVzcy4gIElmIHNvLCBu byBuZWVkIHRvIGNvbnRpbnVlLCBvdGhlcndpc2Ugd2Ugd2lsbCBydW4gdGhl DQo+PiArCSAgICAjIGluZmVyaW9yIHRvIGNvbXBsZXRpb24uDQo+PiArCSAg ICBpZiB7JHN5c2NhbGxfaW5zbl9hZGRyICE9IFtnZXRfaGV4YWRlY2ltYWxf dmFsdWVvZiAiXCRwYyIgIjAiXX0gew0KPj4gKwkJZ2RiX3Rlc3QgImNvbnRp bnVlIiAiQ29udGludWluZ1xcLi4qQnJlYWtwb2ludCBcWzAtOVxdKywgLioi IFwNCj4+ICsJCSAgICAiY29udGludWUgdG8gc3lzY2FsbCBpbnNuICRzeXNj YWxsIg0KPj4gKwkgICAgfQ0KPj4gICAgCSAgICBnZGJfdGVzdF9ub19vdXRw dXQgInNldCBkaXNwbGFjZWQtc3RlcHBpbmcgJGRpc3BsYWNlZCINCj4+ICAN Cg0K >From gdb-patches-return-163361-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jan 22 14:45:34 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 29396 invoked by alias); 22 Jan 2020 14:45:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29154 invoked by uid 89); 22 Jan 2020 14:45:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Jan 2020 14:45:21 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 051271E5F7; Wed, 22 Jan 2020 09:45:10 -0500 (EST) Subject: Re: [PATCH] Harden gdb.base/step-over-syscall.exp To: Luis Machado , gdb-patches@sourceware.org Cc: alan.hayward@arm.com References: <20200115203645.26360-1-luis.machado@linaro.org> From: Simon Marchi Message-ID: <66fc6535-755d-ffae-627b-fd8925294fb6@simark.ca> Date: Wed, 22 Jan 2020 15:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200115203645.26360-1-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00675.txt.bz2 Content-length: 5069 On 2020-01-15 3:36 p.m., Luis Machado wrote: > diff --git a/gdb/testsuite/gdb.base/step-over-syscall.exp b/gdb/testsuite/gdb.base/step-over-syscall.exp > index b373c169c0..4d9488b1d4 100644 > --- a/gdb/testsuite/gdb.base/step-over-syscall.exp > +++ b/gdb/testsuite/gdb.base/step-over-syscall.exp > @@ -46,7 +46,8 @@ proc_with_prefix check_pc_after_cross_syscall { syscall syscall_insn_next_addr } > > proc setup { syscall } { > global gdb_prompt syscall_insn > - > + global hex > + set next_insn_addr 0 I would suggest using -1 as the initial value, as 0 is (in theory) a valid address. > set testfile "step-over-$syscall" > > clean_restart $testfile > @@ -62,7 +63,7 @@ proc setup { syscall } { > gdb_test_no_output "set displaced-stepping off" \ > "set displaced-stepping off during test setup" > > - gdb_test "break $syscall" "Breakpoint \[0-9\]* at .*" > + gdb_test "break \*$syscall" "Breakpoint \[0-9\]* at .*" > > gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, (.* in |__libc_|)$syscall \\(\\).*" \ > "continue to $syscall (1st time)" > @@ -75,37 +76,72 @@ proc setup { syscall } { > # Hit the breakpoint on $syscall for the second time. In this time, > # the address of syscall insn and next insn of syscall are recorded. > > - gdb_test "display/i \$pc" ".*" > - > - # Single step until we see a syscall insn or we reach the > - # upper bound of loop iterations. > - set msg "find syscall insn in $syscall" > - set steps 0 > - set max_steps 1000 > - gdb_test_multiple "stepi" $msg { > - -re ".*$syscall_insn.*$gdb_prompt $" { > - pass $msg > + # Check if the first instruction we stopped at is the syscall one. > + set syscall_insn_addr 0 > + set test "fetch first stop pc" > + gdb_test_multiple "display/i \$pc" $test { > + -re "display/i .*: x/i .*=> ($hex) .*:.*$syscall_insn.*$gdb_prompt $" { > + set syscall_insn_addr $expect_out(1,string) > + pass $test > } > - -re "x/i .*=>.*\r\n$gdb_prompt $" { > - incr steps > - if {$steps == $max_steps} { > - fail $msg > - } else { > - send_gdb "stepi\n" > - exp_continue > + -re "display/i.*" { > + pass $test > + } This probably fails with "make check-read1". If the characters come in one by one, you'll get eventually get "display/i" in the buffer, which will match the second regexp. > + } > + > + # If we are not at the syscall instruction yet, keep looking for it with > + # stepi commands. > + if {$syscall_insn_addr == 0} { > + # Single step until we see a syscall insn or we reach the > + # upper bound of loop iterations. > + set msg "find syscall insn in $syscall" > + set steps 0 > + set max_steps 1000 > + gdb_test_multiple "stepi" $msg { > + -re ".*$syscall_insn.*$gdb_prompt $" { > + pass $msg > + } > + -re "x/i .*=>.*\r\n$gdb_prompt $" { > + incr steps > + if {$steps == $max_steps} { > + fail $msg > + } else { > + send_gdb "stepi\n" > + exp_continue > + } > } > } Maybe I'm worrying too much, but another way this could fail (or actually fail to catch a failure) is if the regexp misses that syscall instruction, but catches another syscall later, at some point during the 1000 stepi. Would it be good to verify that we are at the syscall we expect, by by checking the syscall number? That would require knowing the register name that holds the syscall number, and the expected syscall numbers for fork, vfork and exec, for each architecture. Those things don't change over time, and we already have an architecture-specific definition ($syscall_insn), so I don't think it would be problematic to hardcode them in the test too. > + > + if {$steps == $max_steps} { > + return { -1, -1 } > + } > + > + set syscall_insn_addr [get_hexadecimal_valueof "\$pc" "0" \ > + "pc before stepi"] > } > > - if {$steps == $max_steps} { > - return { -1, -1 } > + # We have found the syscall instruction. Now record the next instruction. > + # Use the X command instead of stepi since we can't guarantee > + # stepi is working properly. > + set test "pc after syscall instruction" > + gdb_test_multiple "x/2i \$pc" $test { > + -re "x/2i .*=> $hex .*:.*$syscall_insn.* ($hex) .*:.*$gdb_prompt $" { > + set next_insn_addr $expect_out(2,string) > + pass $test > + } For consistency, you might as well get the syscall instruction address from there too. > } > > - set syscall_insn_addr [get_hexadecimal_valueof "\$pc" "0" \ > - "pc before stepi"] > if {[gdb_test "stepi" "x/i .*=>.*" "stepi $syscall insn"] != 0} { > return { -1, -1 } > } > + > + set pc_after_stepi [get_hexadecimal_valueof "\$pc" "0" \ > + "pc after stepi with x command"] > + > + if {$next_insn_addr != $pc_after_stepi} { > + fail "pc after stepi matches insn addr after syscall" > + } Use gdb_assert, so that we get a PASS if it works. gdb_assert {$next_insn_addr == $pc_after_stepi} \ "pc after stepi matches insn addr after syscall" Simon