From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87648-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11531 invoked by alias); 1 Feb 2012 16:24:33 -0000
Received: (qmail 11517 invoked by uid 22791); 1 Feb 2012 16:24:30 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Feb 2012 16:24:16 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id DC2B529004E;	Wed,  1 Feb 2012 17:24:15 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id EeG4hTFvcU3b; Wed,  1 Feb 2012 17:24:15 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id CA95F29004D;	Wed,  1 Feb 2012 17:24:15 +0100 (CET)
Subject: Re: RFA: display an error message if libunwind-XX cannot be load
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <m37h06d0xa.fsf@fleche.redhat.com>
Date: Wed, 01 Feb 2012 16:24:00 -0000
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B647C1A7-E0E0-4797-A50D-9108D6D030B3@adacore.com>
References: <01BDAEC2-6805-4E7B-A0E6-5D728B0158DA@adacore.com> <m37h06d0xa.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00020.txt.bz2


On Feb 1, 2012, at 4:32 PM, Tom Tromey wrote:

>>>>>> "Tristan" =3D=3D Tristan Gingold <gingold@adacore.com> writes:
>=20
> Tristan> 	* libunwind-frame.c (libunwind_load): Display message if
> Tristan> 	dlopen failed.
>=20
> Tristan> +      fprintf_unfiltered (gdb_stderr, "\
> Tristan> +[GDB failed to load %s: %s]\n", LIBUNWIND_SO, dlerror ());
>=20
> This is missing _().
> This is ok with that change.

Thanks, committed.

> Do you want to print something for all the other failure cases in that
> function?

Not yet.  Missing symbols is far unlikely to happen, and there are more imp=
ortant issues to be fixed with libunwind...

Tristan.