From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119081 invoked by alias); 24 Jan 2018 12:29:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119071 invoked by uid 89); 24 Jan 2018 12:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=pasting, Hx-languages-length:2112, kindly X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30047.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Jan 2018 12:29:56 +0000 Received: from DB3PR08MB0106.eurprd08.prod.outlook.com (10.161.56.20) by DB3PR08MB0106.eurprd08.prod.outlook.com (10.161.56.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Wed, 24 Jan 2018 12:29:52 +0000 Received: from DB3PR08MB0106.eurprd08.prod.outlook.com ([fe80::958e:90c2:6108:af75]) by DB3PR08MB0106.eurprd08.prod.outlook.com ([fe80::958e:90c2:6108:af75%14]) with mapi id 15.20.0428.019; Wed, 24 Jan 2018 12:29:52 +0000 From: Alan Hayward To: Omair Javaid CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver Date: Wed, 24 Jan 2018 12:29:00 -0000 Message-ID: References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB3PR08MB0106;7:eJFuIUNfsJxBS+z2agmXCjCKcF50DwndhmA25ncNcwk51aJk7SVhcBbmxviCEtpkguKiCsx6WvEHQkNRfemCb9Y+MVT5nQlMZ8aV9Ew3Aq0aKGCvVkYNaNzoislP5II/HA1ZlF7DPZmRNF2POd36lbnKnY/37qXt37xdOkhnBen6bQLhvXi3D9LRESs8p4/YEt2rob/uYsss3hU2hu9qylnFubWRjLTxvZUNWy8uCN0HUzdPieRlpEIEpgm1hFIO x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 332910db-e20c-4fae-b397-08d563262b09 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:DB3PR08MB0106; x-ms-traffictypediagnostic: DB3PR08MB0106: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:DB3PR08MB0106;BCL:0;PCL:0;RULEID:;SRVR:DB3PR08MB0106; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(366004)(39860400002)(346002)(376002)(39380400002)(55674003)(199004)(189003)(33656002)(6506007)(66066001)(14454004)(8676002)(6246003)(6116002)(3846002)(54906003)(53936002)(106356001)(3660700001)(53546011)(4326008)(7736002)(2900100001)(59450400001)(82746002)(2906002)(102836004)(81166006)(316002)(68736007)(478600001)(25786009)(86362001)(6486002)(6436002)(8936002)(105586002)(99286004)(97736004)(305945005)(72206003)(81156014)(36756003)(5660300001)(3280700002)(5250100002)(229853002)(83716003)(76176011)(2950100002)(6512007)(6916009)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR08MB0106;H:DB3PR08MB0106.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: J3wN9ow9xbOIhjqgEh8xmn5Cpke3mqXX5G8CDh2bQD2FGPuj5KV9jh0A6UadRz6+Pc+0Qddbdmi6ObFSVvOonA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <068FA01A958C1F4796EEA48DC8BD613F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 332910db-e20c-4fae-b397-08d563262b09 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 12:29:52.3818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB0106 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00473.txt.bz2 DQo+IE9uIDI0IEphbiAyMDE4LCBhdCAxMDo1NywgT21haXIgSmF2YWlkIDxv bWFpci5qYXZhaWRAbGluYXJvLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBBbGFu LA0KPiANCj4gSSBhbSBmYWlsaW5nIHRvIGFwcGx5IHlvdXIgcGF0Y2ggc2Vy aWVzIHRvIHRoZSBsYXRlc3QgZ2RiIHNvdXJjZXMuIEFwcGFyZW50bHksIHlv dXIgcGF0Y2ggc2VyaWVzIG5lZWRzIGEgcmUtYmFzZSBvdmVyIG1vc3QgcmVj ZW50IGdkYiBzb3VyY2VzIGFzIHRoZXJlIGhhcyBub3QgYmVlbiBhIGNvbW1p dCBzaW5jZSB0aGVzZSBwYXRjaGVzIGhhdmUgYmVlbiBwb3N0ZWQuDQo+IA0K PiBHZW5lcmFsbHkgaXRzIGEgZ29vZCBpZGVhIHRvIGdlbmVyYXRlIHBhdGNo ZXMgdXNpbmcgZ2l0IGZvcm1hdC1wYXRjaCBhbmQgc2VuZCBwYXRjaGVzIHVz aW5nIGdpdCBzZW5kLWVtYWlsLiBQYXRjaGVzIG5lZWQgdG8gYmUgYmFzZWQg b2ZmIHRoZSBtb3N0IHJlY2VudCBnZGIgY29tbWl0IHRoYXQgaXMgYXZhaWxh YmxlIGF0IHRoZSB0aW1lIG9mIHNlbmRpbmcgdGhlbSBmb3IgcmV2aWV3LiBJ ZiB5b3UgdXNlIGdpdCBmb3JtYXQtcGF0Y2ggdG8gZ2VuZXJhdGUgcGF0Y2hl cyBmcm9tIHlvdXIgbG9jYWwgY29tbWl0cyBpdCB3b3VsZCBiZWNvbWUgdmVy eSBlYXN5IGZvciBhIHJldmlld2VyIHRvIGp1c3QgYXBwbHkgdGhvc2UgcGF0 Y2hlcyB1c2luZyAiZ2l0IGFwcGx5IiBpbiB0aGVpciBsb2NhbCBicmFuY2hl cy4NCj4gDQo+IEtpbmRseSBwb3N0IGEgcGF0Y2hzZXQgdGhhdCB3b3JrcyB3 aXRoIGEga25vd24gdmVyc2lvbiBvZiBnZGIgc291cmNlcyBpbiBvcmRlciBm b3IgeW91ciBwYXRjaGVzIHRvIGJlIHRlc3RlZC9yZXZpZXdlZCB1cHN0cmVh bS4NCj4gDQoNClRoYXTigJlzIG9kZC4NCk15IHBhdGNoZXMgd2VyZSBiYXNl ZCBvZmYgeWVzdGVyZGF54oCZcyBoZWFkIChkODIwZTE2NGU0YmFjY2FjZDhk NGU3ZTM3NjFlYzU0NzQwMmFlODI4KS4NCknigJl2ZSBqdXN0IHJlYmFzZWQg bXkgZ2l0IHRvIHRoZSBsYXRlc3QgaGVhZCwgYW5kIEkgZ290IG5vIGNvbmZs aWN0cyBvciBtZXJnZSB3YXJuaW5ncy4NCkxvb2tpbmcgYXQgdGhlIGRpZmYg ZnJvbSB0aGVuIHVudGlsIG5vdywgSSBjYW7igJl0IHNlZSBhbnkgZmlsZXMg dGhhdCBteSBwYXRjaCB0b3VjaGVzLg0KSGFwcHkgdG8gcmVwb3N0IG15IHJl YmFzZWQgcGF0Y2hlcyBpbiB0aGUgc2FtZSB3YXksIGJ1dCBJIHN1c3BlY3Qg dGhhdOKAmXMgbm90IHRoZSBpc3N1ZS4NCg0KSeKAmXZlIHByb2JhYmx5IGdv dCBzb21ldGhpbmcgbWlzc2luZy93cm9uZyBpbiB0aGUgdXBwZXIgcGFydHMg b2Ygb2YgdGhlIGVtYWlsLg0KDQpXZXJlIHlvdSBoYXZpbmcgdHJvdWJsZSB3 aXRoIGEgcGFydGljdWxhciBwYXRjaCBvciB3YXMgaXQgYWxsIG9mIHRoZW0/ DQpBbHNvLCBob3cgYXJlIHlvdSBnZXR0aW5nIHRoZSBwYXRjaCBlbWFpbCBm cm9tIHlvdXIgZW1haWwgY2xpZW50IHRvIGdpdD8NCg0KSeKAmW0gc2VuZGlu ZyBtYWlscyBieSBvcGVuaW5nIG15IG1haWwgY2xpZW50LCB3cml0aW5nIG15 IGNvbW1lbnRzLCB0aGVuIGNvcHkvcGFzdGluZyB0aGUgY29udGVudHMNCm9m IGEgZGlmZiBkb3dubG9hZGVkIGZyb20gYSBsb2NhbCByZXZpZXdib2FyZC4g VGhhdCBkaWZmIGxvb2tzIGlkZW50aWNhbCB0byBhIGdpdCBmb3JtYXQtcGF0 Y2ggb3IgZ2l0IGRpZmYuDQpJ4oCZdmUgdHJpZWQgYXBwbHlpbmcgdGhlIGZp cnN0IHBhdGNoIG9mIHRoZSBzZXJpZXMgdG8gdGhlIGxhdGVzdCBoZWFkIHVz aW5nIGJvdGggbXkgcGF0Y2ggZmlsZSBhbmQgY29udGVudHMNCm9mIHRoZSBl bWFpbCwgYW5kIGJvdGggd29yayBmb3IgbWUuDQoNCknigJl2ZSBqdXN0IHRl c3RlZCBnaXQgc2VuZC1tYWlsLCBhbmQgaXQgbG9va3MgbGlrZSBJIG5lZWQg dG8gZG8gc29tZSBtZXNzaW5nIGFyb3VuZCB0byBnZXQgdGhhdCB3b3JraW5n Lg0KSSBjYW4gbG9vayBhdCBnZXR0aW5nIHRoYXQgd29ya2luZy4NCg0KSW4g dGhlIG1lYW50aW1lLCBJ4oCZdmUgcHVzaGVkIHRoaXMgYnJhbmNoIHRvIGdk YiB3aXRoIGFsbCBteSBjb21taXRzOg0KcmVtb3Rlcy9vcmlnaW4vdXNlcnMv YWhheXdhcmQveG1sDQoNClRoYW5rcywNCkFsYW4u >From gdb-patches-return-145000-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jan 24 14:44:11 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 93421 invoked by alias); 24 Jan 2018 14:44:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 89126 invoked by uid 89); 24 Jan 2018 14:44:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.0 required=5.0 tests=AWL,BAYES_00,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=orignal, eml, H*c:alternative, Hx-languages-length:5374 X-HELO: mail-qt0-f181.google.com Received: from mail-qt0-f181.google.com (HELO mail-qt0-f181.google.com) (209.85.216.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Jan 2018 14:44:07 +0000 Received: by mail-qt0-f181.google.com with SMTP id s3so10806945qtb.10 for ; Wed, 24 Jan 2018 06:44:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PAz0+Ne1SrzOc6RqAto71Picxiji8N7xQHC4evbTX+s=; b=fOWOIcnunLTtsCo0HTj+PoOo2t7D0iL1wlLsThcXW3L4Zj+NebYDkoMfwqrd8nBlQk NYfMVieHfxO6NkbWGxG+C3BxfBkG9YRO0W3E9r6IMP90EbF2Y9jgu1tDy+SnBGVgzLKl Mh/Wj+RuXP+6anyGqIZ2opzU55BbBG8CL2fpVvE6/eBJycGQF1HVC0s3dS4lsDyxbG09 4ZwycWb99+6wDRILGsdkFadJPI5sjIqk5LPlB5V/x2NUW0oq9BoJOHCsnrv3b4/RNHLa lYaW8cbLuqWl3/bwJzfBOp03NjQObc5LeSFihGr3DlHb5K6+B6oY2AwHetkJMn4uQG2X mdoA== X-Gm-Message-State: AKwxyteKrn0r3uLpD7kIoqgh98O5rH4pQw15EKDap8rr5QMstUklTf+S UotBtkVeeKc7ZyFjSGaia8ABdmvKKJyldewt8PAUrtjJ X-Google-Smtp-Source: AH8x225TKfQUPfT2ZLA6y0HZydg+2WR165rLCRi3H9qaJMzrt8UWGj6/7HpqN2sFv4wNBo77Y4iqnkUBzx07ZsyObgE= X-Received: by 10.55.111.134 with SMTP id k128mr9937898qkc.175.1516805046074; Wed, 24 Jan 2018 06:44:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.33.46 with HTTP; Wed, 24 Jan 2018 06:43:35 -0800 (PST) In-Reply-To: References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> From: Omair Javaid Date: Wed, 24 Jan 2018 14:44:00 -0000 Message-ID: Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00474.txt.bz2 Content-length: 2793 On 24 January 2018 at 17:29, Alan Hayward wrote: > > > On 24 Jan 2018, at 10:57, Omair Javaid wrote: > > > > Hi Alan, > > > > I am failing to apply your patch series to the latest gdb sources. > Apparently, your patch series needs a re-base over most recent gdb sources > as there has not been a commit since these patches have been posted. > > > > Generally its a good idea to generate patches using git format-patch and > send patches using git send-email. Patches need to be based off the most > recent gdb commit that is available at the time of sending them for revie= w. > If you use git format-patch to generate patches from your local commits it > would become very easy for a reviewer to just apply those patches using > "git apply" in their local branches. > > > > Kindly post a patchset that works with a known version of gdb sources in > order for your patches to be tested/reviewed upstream. > > > > That=E2=80=99s odd. > My patches were based off yesterday=E2=80=99s head (d820e164e4baccacd8d4e= 7e3761ec > 547402ae828). > I=E2=80=99ve just rebased my git to the latest head, and I got no conflic= ts or > merge warnings. > Looking at the diff from then until now, I can=E2=80=99t see any files th= at my > patch touches. > Happy to repost my rebased patches in the same way, but I suspect that=E2= =80=99s > not the issue. > > I=E2=80=99ve probably got something missing/wrong in the upper parts of o= f the > email. > > Were you having trouble with a particular patch or was it all of them? > Also, how are you getting the patch email from your email client to git? > I downloaded eml files. Also tried with untouched orignal email text. First 2 patches are applicable using git am. Third patch and onwards fail. With git apply or patch command even first patch fails. > > I=E2=80=99m sending mails by opening my mail client, writing my comments,= then > copy/pasting the contents > of a diff downloaded from a local reviewboard. That diff looks identical > to a git format-patch or git diff. > I=E2=80=99ve tried applying the first patch of the series to the latest h= ead using > both my patch file and contents > of the email, and both work for me. > I am not sure what exactly could be wrong but it could be email client mangling patch email or wrapping text or converting tabs/spaces. I think you are using a windows based email client which is using CR+LF as end line character which is incompatible with unix LF. > > I=E2=80=99ve just tested git send-mail, and it looks like I need to do so= me > messing around to get that working. > I can look at getting that working. > > In the meantime, I=E2=80=99ve pushed this branch to gdb with all my commi= ts: > remotes/origin/users/ahayward/xml > > Thanks, > Alan.