Re: [PATCH v2 07/10] Increase gdbsever PBUFSIZ

Simon Marchi
2018-06-11T00:46:11Z

On 2018-06-06 11:16 AM, Alan Hayward wrote:
> PBUFSIZ is no longer big enough for SVE. Increase accordingly.
>
> 2018-06-06 Alan Hayward <alan.hayward@arm.com>
>
> gdbserver/
> * server.h (PBUFSIZ): Increase size
> ---
> gdb/gdbserver/server.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h
> index 9202df2948..8e197eef8f 100644
> --- a/gdb/gdbserver/server.h
> +++ b/gdb/gdbserver/server.h
> @@ -113,7 +113,7 @@ extern int in_queued_stop_replies (ptid_t ptid);
> /* Buffer sizes for transferring memory, registers, etc. Set to a constant
> value to accomodate multiple register formats. This value must be at least
> as large as the largest register set supported by gdbserver. */
> -#define PBUFSIZ 16384
> +#define PBUFSIZ 18432
>
> /* Definition for an unknown syscall, used basically in error-cases. */
> #define UNKNOWN_SYSCALL (-1)
>

LGTM, I trust your did your maths correctly :).

Simon