Re: [PATCH v2 04/10] Add regcache raw_compare method

Simon Marchi
2018-06-10T22:26:36Z

On 2018-06-08 11:16 AM, Alan Hayward wrote:
> diff --git a/gdb/common/common-regcache.h b/gdb/common/common-regcache.h
> index 29d9a81182ad1a5797b080e136b682fe59ecef37..fe3ece7ac52d60d07d718ad617f30be2f7133b5f 100644
> --- a/gdb/common/common-regcache.h
> +++ b/gdb/common/common-regcache.h
> @@ -75,6 +75,11 @@ struct reg_buffer_common
>
> /* Collect register REGNUM from REGCACHE and store its contents in BUF. */
> virtual void raw_collect (int regnum, void *buf) const = 0;
> +
> + /* Compare the contents of the register stored in the regcache (ignoring the
> + first OFFSET bytes) to the contents of BUF (without any offset). Returns
> + True if the same. */

True -> true (since it's written this way in C++, unlike Python for example).

LGTM with that fixed.

Simon