Re: [PATCH v2 03/10] Add reg_buffer_common

Simon Marchi
2018-06-07T20:42:29Z

On 2018-06-07 04:18 PM, Simon Marchi wrote:
> Hi Alan,
>
> Just some quick comments.
>
> I get this when building on x86-64 with --enable-targets=all:
>
> CXX aarch64-tdep.o
> In file included from /home/emaisin/src/binutils-gdb/gdb/nat/aarch64-sve-linux-ptrace.h:29:0,
> from /home/emaisin/src/binutils-gdb/gdb/aarch64-tdep.c:61:
> /home/emaisin/src/binutils-gdb/gdb/nat/aarch64-linux-sigcontext.h:19:22: error: field ‘head’ has incomplete type ‘_aarch64_ctx’
> struct _aarch64_ctx head;
> ^
> /home/emaisin/src/binutils-gdb/gdb/nat/aarch64-linux-sigcontext.h:19:9: note: forward declaration of ‘struct _aarch64_ctx’
> struct _aarch64_ctx head;
> ^
>
> First, we should not include "nat/aarch64-sve-linux-ptrace.h" (a file that only makes
> sense when building on AArch64) in aarch64-tdep.c, a file built on all architecture
> when including the support for AArch64 debugging. It looks like aarch64-tdep.c
> needs sve_vq_from_vl. Maybe that definition could be moved to arch/, which can be
> included in aarch64-tdep.c.
>
> Then, is the _aarch64_ctx structure guaranteed to be defined on older AArch64 kernels
> or should we include it too?

Sorry, I mixed things up, this feedback is about patch 2/10 actually. The other
comments apply to this patch (3/10).

Simon