Re: [PATCH v2 02/10] Add Aarch64 SVE Linux headers

Alan Hayward
2018-06-12T15:09:55Z

> On 12 Jun 2018, at 15:43, Pedro Alves <palves@redhat.com> wrote:
>
> On 06/12/2018 03:37 PM, Alan Hayward wrote:
>>
>>
>>> On 8 Jun 2018, at 16:23, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>>
>>> On 2018-06-08 10:37, Simon Marchi wrote:
>>>> The code looks good to me, thanks. I am still unsure about the
>>>> licensing side of it, let me ask the FSF people about it, I'll come
>>>> back to you when it's done. I hope it won't take too long!
>>>
>>> Hi Alan,
>>>
>>> After discussion with other maintainers, it was suggested to avoid involving the legal staff if we want to resolve this anytime soon.
>>>
>>> Since ARM already holds the copyright to these header files anyway (they were all written by ARM people), you may be able to submit that code as regular FSF-assigned code, without changing the status of the kernel copy. But nobody here is a lawyer, so nobody wants to say for sure :).
>>>
>>> Maybe it's ok after all if we don't include these headers (at least for now), and require that GDB for native AArch64 is built against the headers of a >= 4.15 kernel? They can always be included later, but it would avoid delaying the inclusion of the feature, since you want to have it before we branch 8.2.
>>>
>>
>> Sorry, I did miss this one (I think I sent my reply to the previous
>> one more or less the same time you sent this).
>>
>> If I commit this,
>
> What's "this" ?

Should have said “if I commit 4/10 without 2/10 it’s going to cause
buildbot to break"

>
> How about we add a configure check to check if the system headers support
> the needed SVE bits, and guard the native gdb SVE bits with
> HAVE_AARCH64_SVE or something like that?
>

Excellent idea. I can have a look at doing this - should be fairly quick to do.

In the meantime, lets keep the other discussion going.

Alan.