From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20425 invoked by alias); 5 Dec 2002 16:22:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20354 invoked from network); 5 Dec 2002 16:22:16 -0000 Received: from unknown (HELO dc-mx14.cluster1.charter.net) (209.225.8.24) by sources.redhat.com with SMTP; 5 Dec 2002 16:22:16 -0000 Received: from [66.189.46.2] (HELO platinum.local.) by dc-mx14.cluster1.charter.net (CommuniGate Pro SMTP 3.5.9) with ESMTP id 35381843; Thu, 05 Dec 2002 11:22:08 -0500 Date: Thu, 05 Dec 2002 08:22:00 -0000 Subject: Re: [RFC] Update to current automake/autoconf/libtool versions. Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v543) Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com To: Andrew Cagney From: Klee Dienes In-Reply-To: <3DEF7411.4050805@redhat.com> Message-Id: Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00142.txt.bz2 On Thursday, December 5, 2002, at 10:43 AM, Andrew Cagney wrote: > I don't understand this: > > - $(SHELL) $(YLWRAP) "$(YACC)" $(srcdir)/c-exp.y y.tab.c c-exp.tmp -- > $(YFLAGS) > + $(SHELL) $(YLWRAP) $(srcdir)/c-exp.y y.tab.c c-exp.tmp -- "$(YACC)" > $(YFLAGS) > > isn't it independant of the switch? It's a result of using the ylwrap from autoconf-1.7, which is needed since the rules for the binutils/ parsers are automatically generated by automake. > Same with this? > > - AC_DEFINE(HAVE_LONG_DOUBLE) > + AC_DEFINE([HAVE_LONG_DOUBLE], [], [Define if the `long double' type > works]) > > (or did the new autoconf change the interface causing a warning if the > three parameters were not present?). Not even a warning: it blows out autoheader with an error. The new AC_DEFINE interface deprecates the use of a template file, and instead requires all the information to be provided by the AC_DEFINE commands (it's particularly annoying since the warning about the existence of a template file is about 10 lines long, ALL CAPS, and can't be turned off with --warnings=none). I actually made a point of not fixing any warnings during the conversion that weren't symptoms of real errors. My reasoning is that once the flag day part of the conversion is done, we can fix the warnings in individual directories individually, but that for the initial conversion it was best to keep it as simple as possible.