From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96975 invoked by alias); 17 May 2019 12:47:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96966 invoked by uid 89); 17 May 2019 12:47:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-24.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=pgrp, doesn=e2, permanently?= X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr140053.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (40.107.14.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 May 2019 12:46:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N7JvGTNy6UoDdPwYiWOFfwwtHPnO9x1OrzNKlZDFPNU=; b=SUjx7LcLe+EGJ/DM+491voUTDihlCpTDNpjP1SZBpKgmVKY2kdCz7Y/1N6hURHWuoruygx1vvi3VC1QqhBIG7yQoovjM5C5Jb7qgsY6mTPXTwMNVm/3iovZWu9xgF6LBL9xvyR5QRGQVmjhJyvYIhoT3lMAB1R1QBqmAxKA34hs= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2341.eurprd08.prod.outlook.com (10.172.229.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.17; Fri, 17 May 2019 12:46:56 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40%2]) with mapi id 15.20.1900.010; Fri, 17 May 2019 12:46:56 +0000 From: Alan Hayward To: Andrew Burgess CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Supress SIGTTOU when handling errors Date: Fri, 17 May 2019 12:47:00 -0000 Message-ID: References: <20190516155150.71826-1-alan.hayward@arm.com> <20190516180640.GS2568@embecosm.com> In-Reply-To: <20190516180640.GS2568@embecosm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-oob-tlc-oobclassifiers: OLM:10000; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <771BBD1076BD4E45AE6996C75DAFC55D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00415.txt.bz2 DQoNCj4gT24gMTYgTWF5IDIwMTksIGF0IDE5OjA2LCBBbmRyZXcgQnVyZ2Vz cyA8YW5kcmV3LmJ1cmdlc3NAZW1iZWNvc20uY29tPiB3cm90ZToNCj4gDQo+ ICogQWxhbiBIYXl3YXJkIDxBbGFuLkhheXdhcmRAYXJtLmNvbT4gWzIwMTkt MDUtMTYgMTU6NTE6NTMgKzAwMDBdOg0KPiANCj4+IFtJJ3ZlIHNlZW4gdGhp cyBvbiBhbmQgb2ZmIG92ZXIgbWFueSBtb250aHMgb24gQUFyY2g2NCBhbmQg QXJtLCBhbmQgYW0NCj4+IGFzc3VtaW5nIGl0IGlzbid0IHRoZSBpbnRlbmRl ZCBiZWhhdmlvdXIuIE5vdCBzdXJlIGlmIHRoaXMgc2hvdWxkIGJlIGF0DQo+ PiB0Y2RyYWluIG9yIGl0IHNob3VsZCBiZSBkb25lIGF0IGEgaGlnaGVyIGxl dmVsIC0gZWcgaW4gdGhlIHRlcm1pbmFsDQo+PiBoYW5kbGluZyBjb2RlXQ0K Pj4gDQo+PiBDYWxscyB0byBlcnJvciAoKSBjYW4gY2F1c2UgU0lHVFRPVSB0 byBzZW5kIGdkYiB0byB0aGUgYmFja2dyb3VuZC4NCj4+IA0KPj4gRm9yIGV4 YW1wbGUsIG9uIGFuIEFybSBidWlsZDoNCj4+ICAoZ2RiKSBiIG1haW4NCj4+ ICBCcmVha3BvaW50IDEgYXQgMHgxMDc3NDogZmlsZSAvYnVpbGQvZ2RiL3Rl c3RzdWl0ZS8uLi8uLi8uLi9zcmMvYmludXRpbHMtZ2RiL2dkYi90ZXN0c3Vp dGUvZ2RiLmJhc2Uvd2F0Y2hwb2ludC5jLCBsaW5lIDE3NC4NCj4+ICAoZ2Ri KSByDQo+PiAgU3RhcnRpbmcgcHJvZ3JhbTogL2J1aWxkL2dkYi90ZXN0c3Vp dGUvb3V0cHV0cy9nZGIuYmFzZS93YXRjaHBvaW50L3dhdGNocG9pbnQNCj4+ IA0KPj4gIFsxXSsgIFN0b3BwZWQgICAgICAgICAgICAgICAgIC4uL2dkYiAu L291dHB1dHMvZ2RiLmJhc2Uvd2F0Y2hwb2ludC93YXRjaHBvaW50DQo+PiAg bG9jYWxob3N0JCBmZw0KPj4gIC4uL2dkYiAuL291dHB1dHMvZ2RiLmJhc2Uv d2F0Y2hwb2ludC93YXRjaHBvaW50DQo+PiAgQ2Fubm90IHBhcnNlIGV4cHJl c3Npb24gYC5MMTE5OSA0QHI0Jy4NCj4+ICB3YXJuaW5nOiBQcm9iZXMtYmFz ZWQgZHluYW1pYyBsaW5rZXIgaW50ZXJmYWNlIGZhaWxlZC4NCj4+ICBSZXZl cnRpbmcgdG8gb3JpZ2luYWwgaW50ZXJmYWNlLg0KPj4gDQo+PiBUaGUgU0lH VFRPVSBpcyByYWlzZWQgd2hpbHN0IGluc2lkZSBhIHN5c2NhbGwgZHVyaW5n IHRoZSBjYWxsIHRvIHRjZHJhaW4uDQo+PiBGaXggaXMgdG8gdXNlIHNjb3Bl ZF9pZ25vcmVfc2lndHRvdSB0byBlbnN1cmUgU0lHVFRPVSBpcyBibG9ja2Vk Lg0KPj4gDQo+PiBJbiBhZGRpdGlvbiBmaXggaW5jbHVkZSBjb21tZW50cyAt IGpvYl9jb250cm9sIGlzIG5vdCBpbmNsdWRlZCB2aWENCj4+IHRlcm1pbmFs LmgNCj4gDQo+IE1heWJlIHNvbWVvbmUgZWxzZSBrbm93cyB0aGlzIGJldHRl ciwgYnV0IHRoaXMgZmVlbHMgbGlrZSB0aGUgd3JvbmcNCj4gc29sdXRpb24g dG8gbWUuDQo+IA0KPiBBcyBJIHVuZGVyc3RhbmQgaXQgdGhlIHByb2JsZW0g eW91J3JlIHNlZWluZyBjb3VsZCBiZSByZXNvbHZlZCBieQ0KPiBtYWtpbmcg c3VyZSB0aGF0IHRoZSB0ZXJtaW5hbCBpcyBjb3JyZWN0bHkgY2xhaW1lZCBi eSBHREIgYXQgdGhlIHBvaW50DQo+IHRjZHJhaW4gaXMgY2FsbGVkLiAgVGhp cyB3b3VsZCByZXF1aXJlIGEgY2FsbCB0byBlaXRoZXINCj4gJ3RhcmdldF90 ZXJtaW5hbDo6b3VycyAoKScgb3IgJ3RhcmdldF90ZXJtaW5hbDo6b3Vyc19m b3Jfb3V0cHV0ICgp4oCZLg0KDQpUaGF0IG1ha2VzIHNlbnNlLiBXYXNu4oCZ dCBhd2FyZSBhYm91dCB0aGF0IGNvZGUgYmVmb3JlLiANCg0KPiANCj4gSSd2 ZSBtYWRlIHNldmVyYWwgYXR0ZW1wdHMgdG8gZml4IHRoaXMgaW4gdGhlIHBh c3QgKG5vbiBwb3N0ZWQNCj4gdGhvdWdoKSwgb25lIHByb2JsZW0gSSd2ZSBw cmV2aW91c2x5IHJ1biBpbnRvIHRoYXQgSSd2ZSBub3QgeWV0DQo+IHVuZGVy c3Rvb2QgaXMgdGhhdCBjYWxsaW5nIDo6b3Vyc19mb3Jfb3V0cHV0IGRvZXNu J3Qgc2VlbSB0byBiZSBlbm91Z2gNCj4gdG8gcHJldmVudCB0aGUgU0lHVFRP VSAoSSBhc3N1bWUgZnJvbSB0aGUgdGNkcmFpbikgYW5kIG9ubHkgY2FsbGlu Zw0KPiA6Om91cnMgaXMgZW5vdWdoLg0KDQoNClBsYXlpbmcgYWJvdXQgd2l0 aCB0aGUgcGF0Y2ggeW91IHBvc3RlZCwgSSBhbHNvIGZvdW5kIHRoYXQgOjpv dXJzIHByZXZlbnRzDQp0aGUgc2lnbmFsLCBidXQgOjpvdXJzX2Zvcl9vdXRw dXQgZG9lc27igJl0LiAgTG9va3MgbGlrZSBpdOKAmXMgZHVlIHRvIHRoZQ0K Zm9sbG93aW5nIHRjc2V0cGdycCBub3QgaGFwcGVuaW5nOg0KDQppbmZsb3cu YzpjaGlsZF90ZXJtaW5hbF9vdXJzXzEgKCkNCg0KaWYgKGpvYl9jb250cm9s ICYmIGRlc2lyZWRfc3RhdGUgPT0gdGFyZ2V0X3Rlcm1pbmFsX3N0YXRlOjpp c19vdXJzKQ0KICB7DQojaWZkZWYgSEFWRV9URVJNSU9TX0gNCiAgICByZXN1 bHQgPSB0Y3NldHBncnAgKDAsIG91cl90ZXJtaW5hbF9pbmZvLnByb2Nlc3Nf Z3JvdXApOw0KDQo+IFdoYXQgSSd2ZSBiZWVuIHRyeWluZyB0byBmaWd1cmUg b3V0IGlzIHdoYXQgdGhlIGludGVuZGVkIGRpZmZlcmVuY2UNCj4gYmV0d2Vl biA6Om91cnNfZm9yX291dHB1dCBhbmQgOjpvdXJzIGFjdHVhbGx5IGlzLCBp ZiB3ZSBjYW4ndCBhbHdheXMNCj4gd3JpdGUgb3V0cHV0IGFmdGVyIGNhbGxp bmcgOjpvdXJzX2Zvcl9vdXRwdXQuICBQYXJ0IG9mIG1lIHdvbmRlcnMgaWYN Cj4gd2Ugc2hvdWxkIGp1c3Qgc3dpdGNoIHRvIHVzaW5nIDo6b3VycyBpbiBh bGwgY2FzZXPigKYuDQoNCkFncmVlZCwgSeKAmW0gbm90IHN1cmUgb2YgdGhl IGludGVuZGVkIGRpZmZlcmVuY2VzIGhlcmUuDQoNCj4gDQo+IEFueXdheSwg SSB0aGluayBtb3N0IG9mIHRoZSBwcm9ibGVtcyB5b3UncmUgc2VlaW5nIHNo b3VsZCBiZSBmaXhlZCBieQ0KPiBjbGFpbWluZyB0aGUgdGVybWluYWwgZWl0 aGVyIHBlcm1hbmVudGx5IChjYWxsaW5nIDo6b3VycyBvcg0KPiA6Om91cnNf Zm9yX291dHB1dCkgb3IgdGVtcG9yYXJpbHkgdXNpbmcNCj4gdGFyZ2V0X3Rl cm1pbmFsOjpzY29wZWRfcmVzdG9yZV90ZXJtaW5hbF9zdGF0ZS4NCg0KVGhl IHByb2JsZW0gd2l0aCB0aGF0IGlzIGZpbmRpbmcgYWxsIHBvc3NpYmxlIGVy cm9yIGNhc2VzIGFuZCBlbnN1cmluZw0KdGhleSBhbGwgYWxsIGZpeGVkIHVw Lg0KDQpGb3IgZXhhbXBsZSwgbXkgZXJyb3Igd2FzIGNvbWluZyBmcm9tIHRo ZSB0cnkvY2F0Y2gvZXhjZXB0aW9uX3ByaW50DQppbiBzb2xpZC1zdnI0LmM6 c29saWJfZXZlbnRfcHJvYmVfYWN0aW9uICgpDQoNCj4gDQo+IExpa2UgSSBz YWlkLCBJJ20gbm90IGFuIGV4cGVydCBvbiB0aGlzIGNvZGUsIHNvIG1heWJl IEkndmUNCj4gbWlzdW5kZXJzdG9vZCB0aGUgcHJvYmxlbSB5b3UncmUgc29s dmluZy4NCj4gDQoNCldl4oCZcmUgZGVmaW5pdGVseSBsb29raW5nIGF0IHRo ZSBzYW1lIGlzc3VlLg0KDQpXb3JraW5nIGJhY2sgdXAgdGhlIGNhbGwgdHJh Y2UgZnJvbSB3aGVyZSBteSBjaGFuZ2Ugd2FzLCBhbGwgdGhlIGVycm9yDQpw cmludHMgZmlyc3QgZW5kIHVwIGluIGV4Y2VwdGlvbnMuYzo6cHJpbnRfZmx1 c2ggKCkgd2hpY2ggYWxyZWFkeSBoYXMNCmEgY2FsbCB0byA6Om91cnNfZm9y X291dHB1dC4NCg0KSeKAmXZlIHBvc3RlZCB0d28gcGF0Y2hlcyBiZWxvdy4g Qm90aCBvZiB0aGVtIGZpeCBhbGwgbXkgaXNzdWVzLCBpbmNsdWRpbmcNCnlv dXIgR0RCX0ZBS0VfRVJST1IgY2FzZS4NCg0KSWYgOjpvdXJzX2Zvcl9vdXRw dXQgYW5kIDo6b3VycyBhcmUgd29ya2luZyBhcyBpbnRlbmRlZCwgdGhlbiB0 aGUgZmlyc3QNCnBhdGNoIGlzIHByb2JhYmx5IHRoZSBjb3JyZWN0IGZpeC4N Cg0KQnV0LCBpZiA6Om91cnNfZm9yX291dHB1dCBhbmQgOjpvdXJzIGFyZSBu b3Qgd29ya2luZyBhcyBpbnRlbmRlZCwgdGhlbg0KcG9zc2libHkgbW9yZSBp bnZlc3RpZ2F0aW9uIGlzIHJlcXVpcmVkIHRvIGtub3cgd2h5IHBhdGNoIDIg d29ya3MuDQoNCkFsYW4uDQoNCg0KDQpQQVRDSCAxOg0KDQpnZGIvQ2hhbmdl TG9nOg0KDQoyMDE5LTA1LTE3ICBBbGFuIEhheXdhcmQgIDxhbGFuLmhheXdh cmRAYXJtLmNvbT4NCg0KICAgICAgICAqIGV4Y2VwdGlvbnMuYyAocHJpbnRf Zmx1c2gpOiBVc2UgdGFyZ2V0X3Rlcm1pbmFsOjpvdXJzLg0KDQpkaWZmIC0t Z2l0IGEvZ2RiL2V4Y2VwdGlvbnMuYyBiL2dkYi9leGNlcHRpb25zLmMNCmlu ZGV4IGViZGM3MWQ5OGQuLjQ3YmZiOTUxNTMgMTAwNjQ0DQotLS0gYS9nZGIv ZXhjZXB0aW9ucy5jDQorKysgYi9nZGIvZXhjZXB0aW9ucy5jDQpAQCAtNDYs NyArNDYsNyBAQCBwcmludF9mbHVzaCAodm9pZCkNCiAgIGlmIChjdXJyZW50 X3RvcF90YXJnZXQgKCkgIT0gTlVMTCAmJiB0YXJnZXRfc3VwcG9ydHNfdGVy bWluYWxfb3VycyAoKSkNCiAgICAgew0KICAgICAgIHRlcm1fc3RhdGUuZW1w bGFjZSAoKTsNCi0gICAgICB0YXJnZXRfdGVybWluYWw6Om91cnNfZm9yX291 dHB1dCAoKTsNCisgICAgICB0YXJnZXRfdGVybWluYWw6Om91cnMgKCk7DQog ICAgIH0NCg0KICAgLyogV2Ugd2FudCBhbGwgb3V0cHV0IHRvIGFwcGVhciBu b3csIGJlZm9yZSB3ZSBwcmludCB0aGUgZXJyb3IuICBXZQ0KDQoNCg0KDQpQ QVRDSCAyOg0KDQoNCiAgICBnZGIvQ2hhbmdlTG9nOg0KDQogICAgMjAxOS0w NS0xNyAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJkQGFybS5jb20+DQoN CiAgICAgICAgICAgICogaW5mbG93LmMgKGNoaWxkX3Rlcm1pbmFsX291cnNf MSk6IENhbGwgdGNzZXRwZ3JwIGZvcg0KICAgICAgICAgICAgaXNfb3Vyc19m b3Jfb3V0cHV0Lg0KDQpkaWZmIC0tZ2l0IGEvZ2RiL2luZmxvdy5jIGIvZ2Ri L2luZmxvdy5jDQppbmRleCAzMzliNTVjMGJjLi5iMzc2ZTI0ZTg2IDEwMDY0 NA0KLS0tIGEvZ2RiL2luZmxvdy5jDQorKysgYi9nZGIvaW5mbG93LmMNCkBA IC01MDksNyArNTA5LDkgQEAgY2hpbGRfdGVybWluYWxfb3Vyc18xICh0YXJn ZXRfdGVybWluYWxfc3RhdGUgZGVzaXJlZF9zdGF0ZSkNCiAgICAgICAvKiBJ ZiB3ZSBvbmx5IHdhbnQgb3V0cHV0LCB0aGVuIGxlYXZlIHRoZSBpbmZlcmlv cidzIHBncnAgaW4gdGhlDQogICAgICAgICBmb3JlZ3JvdW5kLCBzbyB0aGF0 IEN0cmwtQy9DdHJsLVogcmVhY2ggdGhlIGluZmVyaW9yDQogICAgICAgICBk aXJlY3RseS4gICovDQotICAgICAgaWYgKGpvYl9jb250cm9sICYmIGRlc2ly ZWRfc3RhdGUgPT0gdGFyZ2V0X3Rlcm1pbmFsX3N0YXRlOjppc19vdXJzKQ0K KyAgICAgIGlmIChqb2JfY29udHJvbA0KKyAgICAgICAgICYmIChkZXNpcmVk X3N0YXRlID09IHRhcmdldF90ZXJtaW5hbF9zdGF0ZTo6aXNfb3Vycw0KKyAg ICAgICAgICAgICB8fCBkZXNpcmVkX3N0YXRlID09IHRhcmdldF90ZXJtaW5h bF9zdGF0ZTo6aXNfb3Vyc19mb3Jfb3V0cHV0KSkNCiAgICAgICAgew0KICNp ZmRlZiBIQVZFX1RFUk1JT1NfSA0KDQoNCg== >From gdb-patches-return-156184-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri May 17 12:50:53 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 7804 invoked by alias); 17 May 2019 12:50:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 7796 invoked by uid 89); 17 May 2019 12:50:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=spend X-HELO: mail-wr1-f41.google.com Received: from mail-wr1-f41.google.com (HELO mail-wr1-f41.google.com) (209.85.221.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 May 2019 12:50:51 +0000 Received: by mail-wr1-f41.google.com with SMTP id c5so6971607wrs.11 for ; Fri, 17 May 2019 05:50:50 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id e2sm5718023wme.32.2019.05.17.05.50.48 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 05:50:48 -0700 (PDT) Subject: Re: Feedback about users/palves/cli-options To: Philippe Waroquiers , gdb-patches References: <1558033768.1454.5.camel@skynet.be> From: Pedro Alves Message-ID: Date: Fri, 17 May 2019 12:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1558033768.1454.5.camel@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-05/txt/msg00416.txt.bz2 Content-length: 5090 On 5/16/19 8:09 PM, Philippe Waroquiers wrote: > Hello, > I have retested with the last version > (commit e33bd5169a20460e44fab690bbba8545cc72f2e8 (HEAD -> users/palves/cli-options, > origin/users/palves/cli-options) > Find below the updated list of problems and/or suggestions. > Thanks! Most of these are fixed in my local branch. I should push an update quite soon. More below. > * print /x does not combine with the new options e.g. >     (gdb) print /x 4 >     $2 = 0x4 >     (gdb) print -pretty -- 4 >     $3 = 4 >     (gdb) print -pretty -- /x 4 >     A syntax error in expression, near `/x 4'. >     (gdb) print /x -pretty -- 4 >     No symbol "pretty" in current context. >     (gdb)  >   The problem is because the function print_command_parse_format >   is called with *expp pointing at the space character following --. >   Wondering where this is better fixed. >   Maybe at the lowest level (i.e. check_for_argument) : if an argument >   is followed by spaces, I guess these spaces should be 'eaten' by >   check_for_argument. Indeed. I wrote a preparatory patch to make that change to check_for_argument. I made this work: (gdb) print -pretty -- /x 4 But not this: (gdb) print /x -pretty -- 4 Not entirely convinced of the latter, and I'd rather spend time on fixing the other issues for now. > * print usage should probably better mention /FMT e.g. >    Usage: print [[OPTION]... --] [/FMT] [EXP] >   instead of >    Usage: print [[OPTION]... --] [EXP] Fixed. > > * compile usage does not mention the new print options: >    Usage: compile print[/FMT] [EXPR] > Fixed. Also made the options actually work now. :-) > * Some 'enum' values (on, off, unlimited, ...) are not accepted as >   abbreviations, while some others are. >   E.g.  bt -e b works >   while  p -e u -- 4 does not >    (but u will complete to unlimited) > Eh, good catch. It turns out that this inconsistency also exists in the corresponding "set" commands. Unsurprising if you consider that parts of the code are shared between settings and options. I now write a test testcase to exercise all kinds of settings, var_uinteger, var_boolean, etc, etc. For that, I added a bunch of new settings-framework representative "maintenance test-settings set/show" commands, like: (gdb) maint test-settings set [TAB] auto-boolean enum integer string uinteger zuinteger boolean filename optional-filename string-noescape zinteger zuinteger-unlimited and then the testcase focus on settings parsing and completion. That exercises the issue you discovered, and others! > * bt fu has changed of behaviour. >   It now gives a lot more completion possibilities. >   This comment can probably just be ignored, as HEAD does in any case >   produce not very relevant completions. The issue here is that in master, "bt"'s completer is the default completer, which is symbol_completer. Since "backtrace"'s -COUNT argument is handled as an expression, I had made bt's completer call expression_completer instead. >   Alternatively, it might maybe be also be possible to complete on the >   'old option qualifier style'. Agreed. That's how I fixed this. > > * bt accepts now 2 'counts' to  limit on the nr of frame to show. >   This is a little bit confusing, so maybe the interactions between >   the 2 might be explained in the help. >   E.g. explain that the below will only give 2 frames: >     bt -limit 2 3 > I haven't addressed this one yet -- I'm thinking that maybe we should just drop that option? > * Now that we have nice command options completions, I wonder >   if the -q -c -s options should/could not be reworded as >     -quiet -continue -silent >   That will be backward compatible, and is better ergonomy. >   I can do that as a follow-up patch if that will help you. Agreed. I'll leave it as they are currently, and I'll be happy if you send a follow-up patch. > > * display and output commands have no OPTIONS yet.  >   For display, I guess this means the 'struct display' has to store >   the option values (or maybe the string options ?). Yeah, that seems intuitive. > > * (gdb) thread apply 1 3 -ascenTAB will complete >   but the resulting command fails: >    (gdb) thread apply 1 3 -ascending p $pc >    Invalid thread ID: -ascending p $pc >   (gdb) Haven't looked at this one yet. > > * help thread apply: the second line for the help for -ascending >   should probably better be indented to the right, like the first line. > > * help thread apply says: >    -q >       Disables printing the frame location information. >   It should be >       Disables printing the thread information. > I've fixed this one. The issue is that "-ascending" can only be used with "thread apply all". The fix is to remove "-ascending" from "thread apply TID"'s completer's supported options. Thanks, Pedro Alves