From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26455 invoked by alias); 29 Oct 2003 19:03:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26438 invoked from network); 29 Oct 2003 19:03:14 -0000 Received: from unknown (HELO mail-out4.apple.com) (17.254.13.23) by sources.redhat.com with SMTP; 29 Oct 2003 19:03:14 -0000 Received: from mailgate1.apple.com (a17-128-100-225.apple.com [17.128.100.225]) by mail-out4.apple.com (8.12.10/8.12.9) with ESMTP id h9TJ4iqY018178 for ; Wed, 29 Oct 2003 11:04:44 -0800 (PST) Received: from scv2.apple.com (scv2.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.2.1) with ESMTP id ; Wed, 29 Oct 2003 11:02:42 -0800 Received: from [17.201.22.245] (inghji6.apple.com [17.201.22.245]) by scv2.apple.com (8.12.9/8.12.9) with ESMTP id h9TJ2tEV018344; Wed, 29 Oct 2003 11:02:55 -0800 (PST) In-Reply-To: <3F9E87A9.4030407@gnu.org> References: <20031028040347.GA26218@nevyn.them.org> <3F9D4B94.7040502@gnu.org> <07B0DBEF-097E-11D8-A22C-000A958F4C44@apple.com> <3F9E87A9.4030407@gnu.org> Mime-Version: 1.0 (Apple Message framework v606) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com From: Jim Ingham Subject: Re: report valid values for all errors for enum variables... Date: Wed, 29 Oct 2003 19:03:00 -0000 To: Andrew Cagney X-SW-Source: 2003-10/txt/msg00843.txt.bz2 Presumably only the line: fprintf_unfiltered (tmp_error_stream, c->enums[i]); since that is the only fprintf with a non-string literal format string. If I change this one, I get no warnings with -Wformat-nonliteral. Jim On Oct 28, 2003, at 7:13 AM, Andrew Cagney wrote: >> Sure, how 'bout: > > Yep! But you'll need to switch some of the fprintf_unfiltered's to > fputs_unfiltered before committing. Otherwize the build will barf due > to -Wformat-nonliteral warnings. > > thanks, > Andrew > > > -- Jim Ingham jingham@apple.com Developer Tools Apple Computer