From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119418 invoked by alias); 6 Aug 2019 12:18:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119410 invoked by uid 89); 6 Aug 2019 12:18:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR04-VI1-obe.outbound.protection.outlook.com Received: from mail-eopbgr80081.outbound.protection.outlook.com (HELO EUR04-VI1-obe.outbound.protection.outlook.com) (40.107.8.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 12:18:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WRBCQu1AwoQXe1wAqNjzq0cn2WnB+6pj/YKnUeUCwVs=; b=TuRXZWvbxpbl8rkKgpKIaX/LKuFV1Lq08ZuMDflQffcKVANO950vjDvZNvSLLzfnzbdIHwm1d4ngVfaRdvgAwlBMfui1RUXXdgisaZEq+AL+j2RDitEb57HE6vo2vYIXAd6z5Wu9BftcS4U/fEcuipNVZThRkNDZJkCPdsmaEpU= Received: from VI1PR08CA0200.eurprd08.prod.outlook.com (2603:10a6:800:d2::30) by HE1PR0801MB1852.eurprd08.prod.outlook.com (2603:10a6:3:7c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Tue, 6 Aug 2019 12:18:34 +0000 Received: from AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::209) by VI1PR08CA0200.outlook.office365.com (2603:10a6:800:d2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2136.16 via Frontend Transport; Tue, 6 Aug 2019 12:18:34 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT059.mail.protection.outlook.com (10.152.17.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Tue, 6 Aug 2019 12:18:32 +0000 Received: ("Tessian outbound cc8a947d4660:v26"); Tue, 06 Aug 2019 12:18:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c4f2bb6f830877d6 X-CR-MTA-TID: 64aa7808 Received: from f00dc513ba87.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.14.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id C845DC43-ECF1-4498-86B2-A7F0EFBEB4EA.1; Tue, 06 Aug 2019 12:18:23 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f00dc513ba87.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Aug 2019 12:18:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Slz9gIKXfW6wwJxg7XnWHDhd6RNqKAdu3eBsCgrxc5lVXE89tkhpvXySv6/jYXMJ1BytghL61pfNFUyMeQTEqWz8f3IFVBdrtroI9viRwRkYT5qwP2T5gtieKdnntNoCjtzWRdJTNWIv9+2E90hADcFxHUf+DiexeK/iSvS2WWsNh2S3wPkbYDaw4e/0IMDqYTDOfBzuCgZvNtTWh2RK6QlajnxOYBzfr79ySRc1mCYJyCJjHyfSADlS9y6TVPFxgcc40RjlNHXd7SKnv7ou8QfzLZjh+u6vM9MccD1xKZlKZ0Egx6BC2vSg1Qp0b77dOPYQd0haL37OLeJYFlroZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WRBCQu1AwoQXe1wAqNjzq0cn2WnB+6pj/YKnUeUCwVs=; b=eEuM9XVmbti4qkHWSbwBL55MCTHt8xr1fiGjUtC4T8YuDOJ3jlLAOwuvCo+ECk7xALBtWtFr5MJlu/8cos649A4sTHqe9Zvwp+9GkPhAhQ2wPW5cIWP/OnY+cyZN/Q8P6dOYnA9xpNW2ofu1HTNy0BCGC4pjyw6h2tp6/NRqgrrUqVqbYfKFXPsZnqNb6t7PF+pHBp1qIVsP7mZR1wb8NKOBWZXv4mlVMOooFDUKE6x3H5ix7LtWaFq7l8GJUUEdoAE9ky18I7orQQVHqu+7HqBSC0SMmOlMH6sN3M2MRi/Si7jz/OZL7/NL1us7lup92v26Gl74OZebrn/HSPbl5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WRBCQu1AwoQXe1wAqNjzq0cn2WnB+6pj/YKnUeUCwVs=; b=TuRXZWvbxpbl8rkKgpKIaX/LKuFV1Lq08ZuMDflQffcKVANO950vjDvZNvSLLzfnzbdIHwm1d4ngVfaRdvgAwlBMfui1RUXXdgisaZEq+AL+j2RDitEb57HE6vo2vYIXAd6z5Wu9BftcS4U/fEcuipNVZThRkNDZJkCPdsmaEpU= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2277.eurprd08.prod.outlook.com (10.172.226.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.14; Tue, 6 Aug 2019 12:18:22 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1%6]) with mapi id 15.20.2136.018; Tue, 6 Aug 2019 12:18:22 +0000 From: Alan Hayward To: Richard Earnshaw CC: Tom Tromey , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] AArch64: Allow additional sizes in prologue Date: Tue, 06 Aug 2019 12:18:00 -0000 Message-ID: References: <20190805124152.26127-1-alan.hayward@arm.com> <8736ifcxu8.fsf@tromey.com> <16866921-5116-49AE-A00E-9D738CE212BD@arm.com> <793a518d-be9c-75f0-96a5-9acdc90d7a62@arm.com> In-Reply-To: <793a518d-be9c-75f0-96a5-9acdc90d7a62@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2277; x-ms-exchange-transport-forked: True x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(189003)(199004)(66476007)(81166006)(81156014)(6486002)(66556008)(57306001)(76116006)(6512007)(36756003)(305945005)(256004)(14444005)(6436002)(64756008)(6862004)(91956017)(5660300002)(66446008)(3846002)(316002)(486006)(53936002)(25786009)(7736002)(6246003)(6116002)(2616005)(476003)(11346002)(229853002)(446003)(2906002)(54906003)(37006003)(102836004)(4326008)(8676002)(50226002)(66066001)(86362001)(6636002)(26005)(53546011)(6506007)(14454004)(8936002)(76176011)(186003)(99286004)(66946007)(68736007)(33656002)(71190400001)(71200400001)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2277;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: 1aitzYM7kB16+4btTHCXcKKyEoG/prfPxCRVLu5U73e+bHSoVmZ7dDen1Yu7JYWvscht2FGZKLn5XrZYF16fXs3ucn8f3+NpDZzA5C19puDLhc3cMc3UUyGOcPGfYnhGwc1t3juHPV8h3QTQjwBP0v1KE0w0BV2ph71X2/MHjyYeZKA/GygMnzYgvTvCtZRwGMxQ5kYdDexZEHvYaPB+/GOxO9GUd5CYz7BJK4ayZHcjvHnW7drFRdXAGbYc9iWvnYINJ9WQ9NYOVA6ew7WTXIR8K44DJiMvlwD/amfqZOt/z8OT3jIXkHMHkcpebNv+8UngkgB98ltnKCP+hXmKCPNm5KSRkSay6NyBdtIN3w7gt3SxIKDwkV5eFsD/crspNQ7UGknjo2TcEYKTNzcb5z5S8dRyW87CX4vATbHGysU= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d312b2b5-e049-426b-a30e-08d71a682c6a X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00133.txt.bz2 > On 6 Aug 2019, at 10:56, Richard Earnshaw (lists) wrote: >=20 > On 06/08/2019 09:58, Alan Hayward wrote: >>> On 5 Aug 2019, at 18:43, Tom Tromey wrote: >>>=20 >>>>>>>> "Alan" =3D=3D Alan Hayward writes: >>>=20 >>> Alan> When saving registers to the stack at the start of a function, no= t all state >>> Alan> needs to be saved. For example, only the first 64bits of float re= gisters need >>> Alan> saving. However, a program may choose to store extra state if it= wishes, >>> Alan> there is nothing preventing it doing so. >>>=20 >>> Alan> The aarch64_analyze_prologue will error if it detects extra state= being >>> Alan> stored. Relex this restriction. >>>=20 >>> I don't know anything about AArch64, so I can't really comment on the >>> content of the patch, but I did happen to see a nit: >>>=20 >>> Alan> stack.store (pv_add_constant (regs[rn], >>> Alan> inst.operands[1].addr.offset.imm), >>> Alan> - is64 ? 8 : 4, regs[rt]); >>> Alan> + size, regs[rt]); >>>=20 >>> ...this addition looked mis-indented to me. >> Thanks. >> I probably missed that because the correct formatting looks horrible: >> stack.store (pv_add_constant (regs[rn], >> inst.operands[1].addr.offset.imm), >> size, regs[rt]); >> Instead, I can update it to the following >> stack.store ( >> pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm), >> size, regs[rt]); >=20 > I think the coding convention in that case is to write: >=20 >=20 > stack.store > (pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm), > size, regs[rt]); >=20 > R. Ok, will use that way. Alan. >From gdb-patches-return-157997-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Aug 06 13:50:35 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 27702 invoked by alias); 6 Aug 2019 13:50:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 27689 invoked by uid 89); 6 Aug 2019 13:50:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:629 X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.197.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 13:50:32 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 0C11036CE3 for ; Tue, 6 Aug 2019 08:50:31 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uzrDhNHs5dnCeuzrDhp9lt; Tue, 06 Aug 2019 08:50:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Cc5bIVMIyPWW4OXyvFlyNEoQc3yCNHiWj+I9p1xC+fs=; b=dhFOQ7jaA92KoTi3ABnCgM/qSf NQwKX7b5QqdetvdYB/eE5pgRkF64eIeQfnK7REaULAo/z1pd7e7te0muz+pOTyj4VZ5jBK3mI6hX7 CfqwWcJYEgzFE+ZH+QWVG/rBk; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:51666 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1huzrC-001Rfp-PS; Tue, 06 Aug 2019 08:50:30 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] Replace int with enum block_enum where appropriate. References: <20190805185833.236434-1-cbiesinger@google.com> Date: Tue, 06 Aug 2019 13:50:00 -0000 In-Reply-To: <20190805185833.236434-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 5 Aug 2019 13:58:33 -0500") Message-ID: <874l2ubdy2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00134.txt.bz2 Content-length: 573 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> For better readability and type safety. Christian> gdb/ChangeLog: Christian> 2019-08-05 Christian Biesinger Christian> * symtab.c (symbol_cache_lookup): Change int to enum block_enum. Christian> (error_in_psymtab_expansion): Likewise. Christian> (lookup_symbol_via_quick_fns): Likewise. Christian> (basic_lookup_transparent_type_quick): Likewise. Christian> (basic_lookup_transparent_type_1): Likewise. Thank you. This is ok. Tom