From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /xLfBCXmtWYoEgEAWB0awg (envelope-from ) for ; Fri, 09 Aug 2024 05:49:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=HOTMAIL.DE header.i=@HOTMAIL.DE header.a=rsa-sha256 header.s=selector1 header.b=SbaS5mch; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F40671E0D0; Fri, 9 Aug 2024 05:49:24 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 07BE11E08C for ; Fri, 9 Aug 2024 05:49:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9DEFB385841D for ; Fri, 9 Aug 2024 09:49:21 +0000 (GMT) Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazolkn190100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:d201::]) by sourceware.org (Postfix) with ESMTPS id C440D3858D34 for ; Fri, 9 Aug 2024 09:48:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C440D3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C440D3858D34 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:d201:: ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1723196941; cv=pass; b=Zwoa0pIAnGVlGFv7jnCXpUkQftWs/dSr3UKa99RbudCoG/s5m+Xl6u28UFeNltdYIgjBe2FFN0/2qs6VKNEyBHw3XwtCYMfvQUzl/xxP9GXRaVbvlzjCj8QIESNJL6IlwnkMHMpDxsK1/VhipWyWDnMwDLJHvJ0/5/qyg2yHu40= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1723196941; c=relaxed/simple; bh=A0KQQbe/b42DLmBJZucI+umdwWtub6wNQ/tZ2EEfXSo=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=SFLk+bxifZwVWpkukNi/HsIBJ8+4NSQP5lu7YJiqNJ70Z9V+loGRMA8lmc7E4lqRervXe9YJAGTzFk9VEdGJDRBLfcaqHmHNNdBoJJZrGO+DaZ37Daz5ogqlxrNUAHokDv0rtT16jLKsBV1cbzAzBWaZoljQmEFZCZInxbx+EBs= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cHb932CapQsF64AtEbunTITQSjAnR+NMNRmmsWVeljp9TPcK7X3pQL2vDXLihW/hz7RccoImx7V58Rbi1dlQeYgcwpBPkX1dQA+mZAYXdzm8wsa7LJjMyFL4EU2c8hjdGmHC7NlZiqKbJFM4mmAJ7kK+ouVCE/czLXzA5PAxbKa8UtvdlhYxaSK6jjiXeY60k9ZrfJX2AzfU/WXO+JMpgMqCSlbjlK/ffSHp8pyNSVFpHmy389I5udGBSzGWZpryvwoQ2GRghMMEtqf/TmFfJQ+D/F5H0Lp6hsOUTBG5bwra6s83/yisQe35PS/G4dXtauYQ+LSlxExScuLcd97/Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8rGJO7cBQI9f85ILt6lGDVb5PYqiFvwkRFYq0N2IFhU=; b=bQioBcZxQ/tMFDtJYEfspxITWXhtrF7SLYQAs6ktaBVJDt+sQz4bSy6Bkq44+XU42u5nWrFXYchLYG8LevbA3wn4thnViOQ+aloBxMnnd8qTTP0AZXyXIe82MTfm0p9aj4uzAB3s9LSY0YbJKapxIcHkmwnq3B15v65yZ4LbxTj++UzJzC3NqAg5gf6HfUy2RYjFFupg5vOZnOWO3vQd6hIaJQrrFd9SnajHOrhACMjECJLX1LruWe0f3rT/j7AsCgrQx2SBY6RL+D0ju9vpvt2m4WLGTcasMGdsncGn+INlw/0sW2pDPML1+DsulHhdPhQkDghn4UwlpLwjtMqhRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8rGJO7cBQI9f85ILt6lGDVb5PYqiFvwkRFYq0N2IFhU=; b=SbaS5mchDlhM+SPWMS6kTrxm9NgInfWTOoFdJ7AjK6fbMc7u21fXp1J/4/So89SDJ5pBOMSRYweMssux8qsOJMR1qcXBwY7x2jf+/TBkujFxoSC+YsS2BNZIoZ/DxORTx7w3DYRiSydc2z7WSqepBUl+lfW78n4wD+ln4+0lgzHadDT3+p4DxQXyvUHrTUGX5B1ZuxWa4+B3bS0LBIjZwKPzqxyyiPYGfOSa1hdJypHxCWGZN8IpPRBTM8OQSVBVqu5JUkaqgshB4Hc08TKjZrenrp8hLlKPxW1ovKkM9I1pEA9ZMmAlK9znEpQl3MvYqa40qqqQQmJheBdD1rwNxQ== Received: from AS1PR01MB9465.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d3::20) by AM7PR01MB7010.eurprd01.prod.exchangelabs.com (2603:10a6:20b:1c2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.15; Fri, 9 Aug 2024 09:48:54 +0000 Received: from AS1PR01MB9465.eurprd01.prod.exchangelabs.com ([fe80::ea10:4661:33e:18c]) by AS1PR01MB9465.eurprd01.prod.exchangelabs.com ([fe80::ea10:4661:33e:18c%7]) with mapi id 15.20.7849.013; Fri, 9 Aug 2024 09:48:54 +0000 Message-ID: Date: Fri, 9 Aug 2024 11:48:49 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix test failures when TUI is not enabled To: Tom de Vries , "gdb-patches@sourceware.org" References: <1cdc325d-4692-425d-a2cb-52197054c015@suse.de> Content-Language: en-US From: Bernd Edlinger In-Reply-To: <1cdc325d-4692-425d-a2cb-52197054c015@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TMN: [Au5EV2PciqXNbfr0ufIMml1iqnJHJnYCXNy1qXRZYdOpKFB93eSYS2SMaZCWG3OT] X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To AS1PR01MB9465.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d3::20) X-Microsoft-Original-Message-ID: <219c0460-0c19-471a-95ae-70b507503cb7@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS1PR01MB9465:EE_|AM7PR01MB7010:EE_ X-MS-Office365-Filtering-Correlation-Id: 389f770e-ac80-4e0e-d6fe-08dcb8587b48 X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799003|19110799003|5072599009|461199028|8060799006|1602099012|3412199025|440099028|4302099013; X-Microsoft-Antispam-Message-Info: zzpUZvNrBAOZB+bx3rDzY6SzfzfHG+Z2YNAFNNofA3qNF5HlaQ9jt+uTeSZUyT3UeSDMkwvYu2T62oJmRpZrdXy0CMsMA5DLiwZ9qNTivDQldcRkCj8xT+0piMVPORCIe0w4lWc15b93qVBatQK/wDyaSyYYvDt06VfFA7G+qPNd0L5xqp1+VSTkogN8k0ehRpKty7WxtHLhz8BeXneCoxJT+BZ5YEPF3aZHdyGEQud8PquPEuIu2Z318XbvY0ck+2Y9RMv8bA34rRpNjXh063evj9GPx211RAy7Ynt8S9hE0RzXcubFKdfNRnhrI/Y9TfvuN/hiwD1YF8pC9VbiHI58w01VIipAPyYsQf7neWemZxTrczYYOr8A/fX+rolbnvfYu+byM1x3YT2fp45M2b6J13nCu6H0Owrb15yCLZZCWR1Yq2pr6nEKrm9zEfvq8FPys+pOU4SHajeiOEBk9voliq1QJI2FsSIFGWFvJM7+gqhNxJI7hFwGVQKe/2cAA8PWUPf+nsep+lEiKxTqf5WThf4v/4HDxr8d4729y8I9/BWg/VyP0ko4k3e0HI2PdLMCTnnqmegIWHq31tUDYh5f8u/pUT764VHGVqmwRxgEVUPE0K6hXUC+mLskPZEqa8ySdkGqyJsYU/uqF2YUSUzMl/xazYTEmOS0Pzw7JFmdWDcm93ZWQdfLiSn8YOR3TvypbsZx6ynGkJu+7TbSECeBdHl9+3+I19aZQzKD+UYuVKckpdoy/5POs7h5XCtJp33HcLDRD1xdiCvP5PU2kGG7eJ8UEEpNPsDv+DV5/9aMKhl7bEXUNnqZFa8ZLZ37 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTBqMkFYL29oajV5MXViRG5FMzV5RUtWaFRETWo2SUZSb1NBVDl6TVN0SEF2?= =?utf-8?B?elZNaytxZlUvYWp6MitjMENRcm5uTmFjckt5VUJBQ0FVQjUwa1RQS3ZTelpU?= =?utf-8?B?K0VNOFZkQ1JLZFpKalcrMHlhVktCeHR4VjRnZEhqQWY2cy9UVUxLNzRNZU1p?= =?utf-8?B?bmRTWWc4QkhZOUs3ZFpJMnU5UUd5UlJaWlhmSVlOUytNNG1RLzdPK0IzOXZz?= =?utf-8?B?QzNxNWVEald1cjk0bnRWUXZ4ZmdKUUxFRE5WK2lJcW1nRXNMeXdSM1psNENw?= =?utf-8?B?bTZBYTNJSDlNcTh3LzRLcHJpWmsrbVVtR2NCeDlxeEhiQVBQS3FaajRBbzVB?= =?utf-8?B?SERobm9yeENaNGJTWC9MTzVVTDJlbU5mNWFvTDEvbEFMT1MzTXhmeVBZR29t?= =?utf-8?B?MkJOZlVwYnZHTHhyWDVxVnBpcW81VXowUUs1MzZheVp1VnNvTUpyeFI0ai9q?= =?utf-8?B?RitnWEV1Q2pLTVJLcmVGcGtWS2ZTZXozNUt6dHQwL3M1dERuMXNuUkMwZ01I?= =?utf-8?B?dFZsTXkra1g5dWF6d0poTkpnTDRYemwwRnRhLzduZ2UxbHVXVm1LTFZha0Mv?= =?utf-8?B?NlFsbDVoZ3JNbmM0T1F2a0NPRkk3ZkFHRWsxTXJUeVNyTTVRTjUza3NBdGpK?= =?utf-8?B?TDBxOTFZZy9pTFJJaEVDcFlzK3lqdTg2d1dFZW1PUHJ0RWZsaGlac1hCK0tZ?= =?utf-8?B?M2c2WW9EWUJUdXRFc3pIS1JFZy82YjczL2VXc0Y1YVo3WDJxVkxqcDVwTWtj?= =?utf-8?B?T0NFU1ZHdkljUW1hV01YTU9lL1JqcFFoaTRUUUxxTXIyd2JMd0hTa2VuV1Qy?= =?utf-8?B?RU44ZE5MUFowb202bUlXSEY5czcrN1NvaXRKUkhuYlExdEtuRVJ4c2hJb0d3?= =?utf-8?B?c09oNzlVbG85Y0xPdDgwTE1xS1VFKzNHU3NIS1lCUC9vcENleExoNXFTTkJJ?= =?utf-8?B?Nzc5eXBvejQrYzR1a3BqMVhTL05ta1RaOUVYK2t5ZXc3U3cxMUQ1ZktzbkdI?= =?utf-8?B?MFI3bWFCc1RtYmRld25TQmNpOWw1Tkkzb1FKeVF1Vld6YjR3ZVdyVzZrN1R2?= =?utf-8?B?c3dGQ1lkSGZ0NEFxc05FdEJGRk5MSVJVc1FSeUJLRUw0SHRBd2EwZlhkMllU?= =?utf-8?B?UjZIYTNkdXpWU0F1T3Y1aFBTMHB1cjBMenQ1cFYrRXJ0SHkwU0d0aGpnblAy?= =?utf-8?B?dEV3MUViQXM5T2hZSnMzRzZsZnhoUWZ3azlXOTVoMCs2UFJDMG1YZDgwVjgw?= =?utf-8?B?SGZ4bmtsYlZ4UjM4SlFObm1jKzA2cWozVFlVQjgwUDhpUVhQcmZmN2w4VWND?= =?utf-8?B?T2F1TTR5NGJSdWJVNnFjWjh4elNvZlpjTDgvbWEza2VRdllhMW5uK1B2V3l0?= =?utf-8?B?cWFOc010YVpja2FSQjRSUFIyZ2sxMnp4aWxNK2NNQXVuWGJFdFpKWXFqcXh6?= =?utf-8?B?aG9PRlRjOHA5Nk0wUm5PSjZiL245Y3NybkU2bmJjR2gvQWxQNHQ0cFhXbmF4?= =?utf-8?B?Zlh1U2lxUTltR1lzelE2TjY3RHpKOXh1SmhmQlVpcXZHMmFFMExEamJwOEdL?= =?utf-8?B?MUE3ajIwQUpyVmw2OXBFcmhsWXljRzlTam8yMEhVWlVLaU9BZytwZjA3UllX?= =?utf-8?B?by8yK2VORDV1YUxMZW9mTTJBWkd6UW9NRHB1YUtJRzVpcTRjTC9MUmJ2Ny83?= =?utf-8?B?dkxyVTlOeHJ3cFYzcHFnWjBCMHV4ZWNrZ0cwaTNRNlpzdTljL014L1lFazIw?= =?utf-8?Q?Ujo/BxFiLsH8aTjTQvJU+bHXgOSp5Ba98pqozCl?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ba98d.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 389f770e-ac80-4e0e-d6fe-08dcb8587b48 X-MS-Exchange-CrossTenant-AuthSource: AS1PR01MB9465.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2024 09:48:54.7108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR01MB7010 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/9/24 11:28, Tom de Vries wrote: > On 8/9/24 10:47, Bernd Edlinger wrote: >> This adds some missing require allow_tui_tests. >> >> When tui is not enabled those test cases do typically >> fail, but most of them only after a long time-out: >> >> FAIL: gdb.base/new-ui.exp: do_test_invalid_args: new-ui with tui >> FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout) >> FAIL: gdb.base/wrap-line.exp: term=ansi: width-auto-detected: wrap (timeout) >> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width >> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: wrap (timeout) >> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width == $readline_width >> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: wrap (timeout) >> FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: wrap >> FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: prompt after wrap >> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: wrap >> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: prompt after wrap >> --- > > Hi, > > I disabled tui support using --disable-tui, and can't reproduce the wrap-line fails you see. > > Is it possible that you're running into "[gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)" @ https://sourceware.org/bugzilla/show_bug.cgi?id=31201 ? > Yes, that could be the case. I did not explicitly opt-out tui, I just did never care to install e.g. libcurses etc. and the configure did the rest. > Anyway, adding require allow_tui_tests in those two test-cases looks wrong. > Okay, but what is going on then? > In the case of gdb.tui/wrap-line.exp, there is already a test that bails > out if TUI is unsupported, but still allows testing of things that should work regardless. > > In the case of gdb.base/wrap-line.exp, it's a test-case I added specifically to test the behaviour of prompt wrapping in the CLI, not in TUI, so requiring allow_tui_tests there is non-sensical. > Well is there a better way to detect the issue without going into this long timeout, or can it be fixed somehow? > The change in gdb.base/new-ui.exp LGTM.  You could submit a v2 with just that change. > OK, will do. Thanks Bernd.