From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oVIIOSRS+WC1TwAAWB0awg (envelope-from ) for ; Thu, 22 Jul 2021 07:10:28 -0400 Received: by simark.ca (Postfix, from userid 112) id D844D1EDFB; Thu, 22 Jul 2021 07:10:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=1.0 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 715091E4A3 for ; Thu, 22 Jul 2021 07:10:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A1E23990C35 for ; Thu, 22 Jul 2021 11:10:27 +0000 (GMT) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2082f.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::82f]) by sourceware.org (Postfix) with ESMTPS id 126D53857C6C for ; Thu, 22 Jul 2021 11:10:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 126D53857C6C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S32mk7CAtx5CiHPaiwfzrHHPI2IIh7EBxQo07wl5MCOBaYboqiZTHNHtZi2Vi8UEJ3xMGJCHJRq3/yCflGLcYKt9NaaMgDUiUDItdFHS6lHhMZ195FdgueZXfupUR+knFf4AsEwNjKwDPwqNdEqKRylUbUSDRfK8fGRfI2QoZLZAcaYUqidzP/58Afp467dNZhJ0/xcsqANFB5f7m/BznhqgTclTBEzekLtEbBptygR6uVPlq3QnyRxE/jc2EpOy2JvY3DA5d5Pu6YIj2tymbNjyJXrqmyHvidTGJVAkfoslsyKx4uPwyQwNxRLrbTZ6kBa53ir9d6+zvGCk+X05Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4sRljDMLC9lKk5Nl5AzqjpTmHwtJnCrJHdGuNiD5y7A=; b=lrO5eaI0PJvDQNyrw3AYcNtnLzLKrqIDgvJhrV1JfqGpKSTuAjTayIPIMd+ccPX+HCW5O0Gal2ZjZWsbR+Te2o5QJf5gh+117RLB+NLWUBbkl0z1a5z8Q7eHzeGDIXznQq/SyfORGZFkN1K95XGfkM52dgIYFNhPf0AhewS7PNz3KE9GSjTf6osDdgnLOXne6Tj/ENJiqDN21xtQWugyY6whEwG0Ep1X/x4tZ+aPV0P38dO9a+re+NOMALDtzOhjagQ3xTA6AvjRKuWihUqD2wwsi2o+GhfxUDMS7uJWrxip0ZWR/1k10nEBLE04WXu7Omq1jJpLll8QUFAD+Rq06w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM6EUR05FT037.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc11::43) by AM6EUR05HT011.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc11::432) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24; Thu, 22 Jul 2021 11:10:13 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:fc11::4e) by AM6EUR05FT037.mail.protection.outlook.com (2a01:111:e400:fc11::440) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Thu, 22 Jul 2021 11:10:13 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:8B573723C8613C520AB797E6009F30CCD1E923C0054C4A378C535D1D42B02EB3; UpperCasedChecksum:8B552614EA248535C34A169E5EFD3E7D7A3A8606200B41294F8661B4D760AD47; SizeAsReceived:7696; Count:45 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::3d30:d151:570a:8a16]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::3d30:d151:570a:8a16%7]) with mapi id 15.20.4331.034; Thu, 22 Jul 2021 11:10:13 +0000 To: "gdb-patches@sourceware.org" , Simon Marchi From: Bernd Edlinger Subject: [PATCH] Fix the crash at the end of the runtest Message-ID: Date: Thu, 22 Jul 2021 13:10:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [xcrxJtUjSgQIYKYftRX5Yutju9lyEK4c] X-ClientProxiedBy: PR3PR09CA0003.eurprd09.prod.outlook.com (2603:10a6:102:b7::8) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: <9fc6d190-3481-56c7-d5aa-753f866e5f61@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (88.76.118.196) by PR3PR09CA0003.eurprd09.prod.outlook.com (2603:10a6:102:b7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Thu, 22 Jul 2021 11:10:12 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 48799d35-eda7-41f2-eb2a-08d94d0146b9 X-MS-TrafficTypeDiagnostic: AM6EUR05HT011: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c9QGXHTznVxxnpeqx2z+psJX3FZB/m/YTASLVMmmOotuVHIE9DyVfg0pXdln1QqMDQKMuJ6//l6f+p3eZc3essKQXDKcYh7b6THYZuIm8hc6oQH0bXCH6q13SiMK2UUxtecJlGGr6hvt+SCyvR7VZCvvcjKW8VvrX3wj59RE/AO6xAi4ZrD9NcBgwgnlNlb5xuQWyT2jHJ6fzZ2UWloJ0iQfcNRW0ebL9735WNzYiGHs3Hc7rBn6xiGmIOUYojxAIKKqEHZ5r4s7IO5+8WdLo/ZbAhwjBdWpiGsR9c7MBd2zxkw6unwtK8EpR5pUYY/CmoG1skNAAdYQM5K4qCn1nVf8Si8O4ng3OVi5pExuvTLHuJI5vUwhBRnSAUHwy/6VLTHgWkM4Nu8H0b5rBmTGjEgFZffHCASx1t6mUTtDDgr5MBWmH5MTra3pI2zX0UP3P8u4HO9QUmMX9yGGqXUrhGWVRc4V6byHtxoZFcmVXS4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Q9JkZtDgZtbctg5TXWJvqrsuLQdBMOzTeCXIZZ7WNULMrlGhfdabo7aIqUlvp6jogQ+t6hJpwwRduOFjKXUjP4WW9VP0tcfZGFVI3+E8J2p2swoGu8ueIgPRX+DNeXUonuolcq7pptDIDKEkZuMBJg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48799d35-eda7-41f2-eb2a-08d94d0146b9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2021 11:10:13.0583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: AM6EUR05FT037.eop-eur05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6EUR05HT011 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" due to unknown reasons the runtest process crashes at the end of the testrun when this script is executed. #0 0x00007fe176cd8b69 in exp_close (interp=interp@entry=0x5595b70269d0, esPtr=0x5595bb6968b0) at exp_command.c:370 #1 0x00007fe176ceef9a in exp_close_all (interp=0x5595b70269d0) at exp_chan.c:582 #2 0x00007fe176bd5b72 in InvokeExitHandlers () at ./generic/tclEvent.c:911 #3 0x00007fe176bd5c0a in Tcl_Exit (status=1) at ./generic/tclEvent.c:976 #4 0x00007fe176cdb959 in Exp_ExitObjCmd (clientData=, interp=0x5595b70269d0, objc=, objv=) at exp_command.c:2531 #5 0x00007fe176b4d5f2 in TclNRRunCallbacks (interp=interp@entry=0x5595b70269d0, result=0, rootPtr=0x0) at ./generic/tclBasic.c:4492 #6 0x00007fe176b4cfc5 in Tcl_EvalObjv (interp=interp@entry=0x5595b70269d0, objc=objc@entry=1, objv=objv@entry=0x5595b70342d0, flags=flags@entry=2097168) at ./generic/tclBasic.c:4215 #7 0x00007fe176b4e924 in TclEvalEx (interp=interp@entry=0x5595b70269d0, script=0x5595b70ade40 "# runtest.exp -- Test framework driver\n# Copyright (C) 1992-2016 Free Software Foundation, Inc.\n#\n# This file is part of DejaGnu.\n#\n# DejaGnu is free software; you can redistribute it and/or modify it"..., numBytes=, flags=flags@entry=0, line=1908, line@entry=1, clNextOuter=clNextOuter@entry=0x0, outerScript=0x5595b70ade40 "# runtest.exp -- Test framework driver\n# Copyright (C) 1992-2016 Free Software Foundation, Inc.\n#\n# This file is part of DejaGnu.\n#\n# DejaGnu is free software; you can redistribute it and/or modify it"...) at ./generic/tclBasic.c:5361 #8 0x00007fe176c08f79 in Tcl_FSEvalFileEx (encodingName=, pathPtr=0x5595b7063510, interp=0x5595b70269d0) at ./generic/tclIOUtil.c:1824 #9 Tcl_FSEvalFileEx (interp=0x5595b70269d0, pathPtr=0x5595b7063510, encodingName=) at ./generic/tclIOUtil.c:1724 #10 0x00007fe176c0784c in Tcl_EvalFile (interp=0x5595b70269d0, fileName=) at ./generic/tclIOUtil.c:424 #11 0x00007fe176ce856e in exp_interpret_cmdfilename (interp=0x5595b70269d0, filename=0x7fff61eef573 "/usr/share/dejagnu/runtest.exp") at exp_main_sub.c:953 #12 0x00005595b6cad2e9 in main (argc=4, argv=0x7fff61eeee38) at exp_main_exp.c:48 This started after commit 9edb1e0191e ("gdb/testsuite: capture GDB tty name in default_gdb_spawn") Temporarily renaming builtin_spawn to spawn fixes the issue. 2021-07-22 Bernd Edlinger * gdb.base/gnu-debugdata.exp (pipeline): Temporarily undo the effect of commit 9edb1e0191e in this function. --- Hi, Is this OK for trunk, and the gdb-11-branch? Thanks Bernd. gdb/testsuite/gdb.base/gnu-debugdata.exp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gdb/testsuite/gdb.base/gnu-debugdata.exp b/gdb/testsuite/gdb.base/gnu-debugdata.exp index f6d0cd7..0dc8191 100644 --- a/gdb/testsuite/gdb.base/gnu-debugdata.exp +++ b/gdb/testsuite/gdb.base/gnu-debugdata.exp @@ -52,11 +52,20 @@ proc pipeline {test args} { } verbose "cooked args are [list $program $arguments $input $output]" + # undo the effect of spawn_capture_tty_name + # this avoids a crash at the end of the test run + rename spawn dummy_spawn + rename builtin_spawn spawn + if {[run_on_host "$test - invoke $program" $program $arguments \ $input $output]} { return -1 } + # restore the original spawn script + rename spawn builtin_spawn + rename dummy_spawn spawn + set input_file $output } return 0 -- 1.9.1