From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LoEcHiHJD2BmHwAAWB0awg (envelope-from ) for ; Tue, 26 Jan 2021 02:47:45 -0500 Received: by simark.ca (Postfix, from userid 112) id 5CB931EF80; Tue, 26 Jan 2021 02:47:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BFD6F1E939 for ; Tue, 26 Jan 2021 02:47:44 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA5D3385803F; Tue, 26 Jan 2021 07:47:43 +0000 (GMT) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072085.outbound.protection.outlook.com [40.92.72.85]) by sourceware.org (Postfix) with ESMTPS id A734B385803F for ; Tue, 26 Jan 2021 07:47:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A734B385803F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7CPWDeK/YcLYgTtKpb2epcs3ZAWy98+2VqquYaxS5CHni0KI2/bYvS7iu3kAiexJGcJZkbsAjB1Rr49Q8+yjccNPk0pGw8Pu2i4yAXByG4S0p0HjcdRcWIoNI9NaCGQWUyU17+ToAXsxxq6Nu8EyFASgOAN3AFpNtNNeSs2KBzzgyut7rJThvwps85yN2VbNLrqFyCC7FaJJOFhp8Jo5sVjad5HgY7bNy6EqdQLTnutzSadAOiuraL1rZDHJrA+2F8uzlFSCrh+Brupmsk4sSkDWRZhh58a74Ib2FGy6z7J1/e0ueib/qOLcWpNwgY7tTPNk7ok6dVrp3udlnUVrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fGsmAxNrmGQfQvmVkEn3MyhBT5P+7BFAX7ztxGz9LlQ=; b=ALvHpCWWE7Kz3vV19DjIVQoDbwavgmCBuGxFQZQq6Mo+0TZ/rnWxq0QMAmb6eXEmemv/NEg/SlVOWxuf+2NILrFYzBoKh0Dc2mZmV3tF/xzcHkpEPq3JXPQH7KSrBe1SsFQ6TRl8qLPI6qcIzu849gEwh0sfizbPQK8CteNO54kz4AIj2VEFwxohIXP0FvtnS9rUX+8qj8H7OPM1y78T7gukrhlI+V0C5z05cftGXg4WVsNKKAMFnsLdUa23J4MDjXZEsxkK5JCBGORmJaMQhfwpc68DyG4jPJSyxQQL72VZIzLZQ3M68cuqJyZCW2ReYvQTeKvwB0kKfCRkBoBGxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2a01:111:e400:7e08::41) by AM5EUR03HT061.eop-EUR03.prod.protection.outlook.com (2a01:111:e400:7e08::506) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11; Tue, 26 Jan 2021 07:47:39 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:7e08::42) by AM5EUR03FT039.mail.protection.outlook.com (2a01:111:e400:7e08::441) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11 via Frontend Transport; Tue, 26 Jan 2021 07:47:39 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:6616C124C24D7F469071BA687B0A4210416905ABEAD85BCCA0596F5460F4F7D5; UpperCasedChecksum:68EC8937C566DCDE97D89B9FF4A8F06E3F3C0D87DFA2B8591AE603886D4E2A76; SizeAsReceived:8440; Count:48 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::7510:8a00:1c00:1147]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::7510:8a00:1c00:1147%5]) with mapi id 15.20.3784.019; Tue, 26 Jan 2021 07:47:39 +0000 Subject: Re: [PATCH][gdb/symtab] Handle DW_AT_ranges with DW_FORM_sec_off in partial DIE To: Simon Marchi , Tom de Vries , gdb-patches@sourceware.org References: <20210125122444.GA15885@delia> <56f38801-477e-fa38-5e16-22a4ed73437c@polymtl.ca> From: Bernd Edlinger Message-ID: Date: Tue, 26 Jan 2021 08:47:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [anziq4ZXVfFvLPUwm9OtpcrcmrzEe05e] X-ClientProxiedBy: AM3PR07CA0098.eurprd07.prod.outlook.com (2603:10a6:207:6::32) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: <895ff948-9aea-c4a1-c12b-5826992b3131@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (88.68.3.2) by AM3PR07CA0098.eurprd07.prod.outlook.com (2603:10a6:207:6::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.6 via Frontend Transport; Tue, 26 Jan 2021 07:47:39 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a0c6d856-7b62-45f7-4fae-08d8c1cea7c7 X-MS-TrafficTypeDiagnostic: AM5EUR03HT061: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P04KTArVGLgIschV8CuohmZpT4+J274ltPzDjKTXIHNPLs9F2ZMN5l0kirnEm/cvGbglmwyT/u3oHle9uLUynx6piy2/EfBSsZ6tRqKI4WS5/ZIXEiBQX5ZKuJVFy1HZ/hLDdw2mDo0+jiXbonLNWJZE34MdoQDNQR0A85B5mLMgddbN/V1BodIMCVodUGraH3kf+3w1iHu3uEC/OwwzA/sxonSMjTe+InFyPTtKG/EU59mXwYr44br9dZlBpRAgzq82g3xmTKq8BrfG9FaxXwudfL7qrZUXa43yXk9Vh38dvxVSv+zeQ3Ph8TPKvT0svJFVzsGhAHBTjSSqXL33uWSZe4BuLFFm0DReyPxjojE6fkySjxYqhOb1PsNtZYz/ekZy3YtqZI0Ic9WnQjmy1JedqNmqf7m6TCARAbYaNF5G0TQ6TDrs5mIA4K0uArD6 X-MS-Exchange-AntiSpam-MessageData: 1mDEeXN+R4vZsXPy+91S3W5CXfbrkQX4Rv5Dt6xjdu7fHPCdb+TNc1QzifdXccnNlBZhwD12Z0JbLAWoUsBco2YJALWZZeGe1g6e8zHyOcxls1j5A7qLEfLJ9Pu7bjlzOZJn4ard3p9v18SS7NbAbQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0c6d856-7b62-45f7-4fae-08d8c1cea7c7 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2021 07:47:39.8242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR03HT061 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 1/26/21 2:52 AM, Simon Marchi wrote: > On 2021-01-25 1:53 p.m., Bernd Edlinger wrote: >> On 1/25/21 7:12 PM, Simon Marchi wrote: >>> >>> >>> On 2021-01-25 12:42 p.m., Bernd Edlinger wrote: >>>> On 1/25/21 5:36 PM, Simon Marchi wrote: >>>>>> Yes, unfortunately I have not any experience with writing such assembly >>>>>> tests, but I am always impressed when one of you does it though :-) >>>>>> >>>>>> Nevertheless, the test case seems to be stable from gcc-4.8 .. gcc-11, >>>>>> that it fails without the patch and passes with the patch. >>>>>> >>>>>> So is it okay to push my partial symbols test as-is? >>>>> >>>>> My patch here adds a test that uses DW_FORM_sec_offset to point >>>>> to a .debug_rnglists (DWARF5) section. Maybe that's sufficient, >>>>> but if not I could probably do a DWARF4 equivalent. >>>>> >>>>> https://sourceware.org/pipermail/gdb-patches/2021-January/175229.html >>>>> >>>> >>>> Yeah, the hardest part on a one-line change like this is always the test case. >>>> >>>> So, I tried this patch on current trunk, but it fails: >>>> >>>> Running /home/ed/gnu/gdb-build-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.dwarf2/rnglists-multiple-cus.exp ... >>>> ERROR: Couldn't load rnglists-multiple-cus-dw32 into GDB (GDB internal error). >>>> ERROR: Couldn't load rnglists-multiple-cus-dw64 into GDB (GDB internal error). >>>> Running /home/ed/gnu/gdb-build-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.dwarf2/rnglists-sec-offset.exp ... >>>> FAIL: gdb.dwarf2/rnglists-sec-offset.exp: is_64=false: p/x &foo >>>> FAIL: gdb.dwarf2/rnglists-sec-offset.exp: is_64=true: p/x &foo >>>> >>>> This probably means that your test tests more than this single-line change alone? >>> >>> Hmm, with current master (so with Tom's patch merged), >>> gdb.dwarf2/rnglists-sec-offset.exp passes for me. >>> >> >> That will probably need investigation. >> Let's first check if I applied the corrrect test case, >> see attached patch.txt. > > It looks like the right patch (I looked at your second patch.txt). > Ah, sorry, my fault. I have done the test with the wrong version, now the test passes for me as well. Bernd.