From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ztruGMmZnmAUIAAAWB0awg (envelope-from ) for ; Fri, 14 May 2021 11:39:53 -0400 Received: by simark.ca (Postfix, from userid 112) id 58DDB1F11C; Fri, 14 May 2021 11:39:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=1.0 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C03381E783 for ; Fri, 14 May 2021 11:39:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E181386FC03; Fri, 14 May 2021 15:39:52 +0000 (GMT) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073085.outbound.protection.outlook.com [40.92.73.85]) by sourceware.org (Postfix) with ESMTPS id 408903851C07 for ; Fri, 14 May 2021 15:39:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 408903851C07 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=blH4P32Pde997bzqf+lqfelu+tTLV5x3h+307J5O1t83cfQtIx7qeynCFHIeMDOUiirprnVNQ/5z3rgM0paZG1glxvOGCo/Zp+OTHS8f4/oT27eivu6VHJnbxKiv0P3qE4geZVAtwCv0vjQNdtnJJqGtyUKPJ9MBUj7mPMQTANzXboqzxhkulNTQftTZ4kibtFBaCquq6ZJEsP25Df7YWgtguIEEybNntOAT6X7/L+RVky87FagYkMRmi+ZdnYbXS1SDRrvLdqtKQyOdNfj3ovsotYkGb8cy3hybIS+81ZoicwAxhTeTg3wMuKf2yri8edUZywnQGsH6bF5LUdkoyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oKA2FJr+r4hZE8xgPJG+qO4aKxRwdrsPNJYKmeKT5gw=; b=BRFdwkcQ8KDQErWEb0psSjw4I/KYdiVZJ2LTO3SWIV3LRYL+Dq5wROsSVahkbYpYIPkWiBwPy8to7DgbdPIAXxPEzndpsoShQisZUjKTyPytKtq25cigpZieRK05cOGeRL8BSJvA7damnGlRdqkxxzl0mN2eFAqKndA12JT4QZc8lOEOQb0rujl1cZsOl3BYClYZFpUh4YEIdb1WkwczwUGN7FoKoPXJ+n35lr33NGe3XcnG/v+FoqeUR0MsFCO1PH8Wp07n9AIAk5Emn1wQYTXUeDgxTDWEu6JN3ApY4bsw4jpDLriI+3U44Vn34Crmdk5hysTA4HmBx9v72jZLEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1EUR04FT006.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::44) by VI1EUR04HT116.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::362) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Fri, 14 May 2021 15:39:48 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:7e0e::4e) by VI1EUR04FT006.mail.protection.outlook.com (2a01:111:e400:7e0e::276) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Fri, 14 May 2021 15:39:48 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:FF24858C9F4874DA684888DE8ADBEE17FB033C3A62843A48278288B29FDA9C9A; UpperCasedChecksum:6B3CB921A1C4A7F3892BAF4870E23A7B52A3B76AD2CA88900C55FF0EC58DAA13; SizeAsReceived:8051; Count:46 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::e41b:107f:af82:150a]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::e41b:107f:af82:150a%7]) with mapi id 15.20.4129.026; Fri, 14 May 2021 15:39:48 +0000 Subject: Re: [PP?] [PATCH] testsuite: Cleanup some temp dirs with gdb-index files To: Simon Marchi , "gdb-patches@sourceware.org" References: <41e8702a-b0cb-57dd-efa2-4e059ec7c9d1@polymtl.ca> <67f531fa-9f90-e56a-8543-b8d6198bc33d@polymtl.ca> From: Bernd Edlinger Message-ID: Date: Fri, 14 May 2021 17:39:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <67f531fa-9f90-e56a-8543-b8d6198bc33d@polymtl.ca> Content-Type: multipart/mixed; boundary="------------55A47C2C6EBD5D99040D804F" Content-Language: en-US X-TMN: [6q6kiKjWnETNL+CM4E3uCg8ZikQ2r8Xb] X-ClientProxiedBy: PR2P264CA0016.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::28) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: <452d29c2-c977-56b2-1bd0-a046a963f447@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (84.57.61.94) by PR2P264CA0016.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Fri, 14 May 2021 15:39:47 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 2ddf8532-f3b4-40ae-4f95-08d916ee81a3 X-MS-TrafficTypeDiagnostic: VI1EUR04HT116: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QcWGXpjETf7QBLC8gwx41VSuKYoHVJl4cC225YKgFQLPW0thrvlYidLkIy2bkL6CuX2giD8SiwgVHZYrpTXLyRdJnJwijJ//zr63Hf+l3w9MlUX9fTC9BaomSl34NRm84U3iUY4qjZhEV/m4ZeiQj1koTQUVWAeKhQkLiFwFegeIcatjDHKfQz6HcC4AGUA9rceb4Je5c0cA2r7HL0cWNjBs1ofL2cIwGzPXLxJoWGQ6nmnsnM8LGlV0NxlqWyLHqmo/3cBrGTldIpb9+Z3eMPEUs2QZFRRSK9XtlMogzPyS0opgwAesHxB1Ejp+SiZSwEhTUgc4V/AkxB8C12iRDLyWyFYj2lgBEbgCH/5MGMKuqqMCBamjAYPaF/WLZ7s/Xz113r5SjUfpxUP1P8fasw== X-MS-Exchange-AntiSpam-MessageData: sQetwNYnDiNyEh/CLg1anK90/Wu+JZ/Mfv8QQcSdF4nbWpD5o0oF+gXzU2zJrbpnLZav/ECFI1MVyiOXNYt8vMmiuxDxTMaLCuMsUevVi5H3j5tRpAPjM3PxA+cajHFExYMYkeJlgOzOGvf68ACm0Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ddf8532-f3b4-40ae-4f95-08d916ee81a3 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2021 15:39:48.5474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: VI1EUR04FT006.eop-eur04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR04HT116 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --------------55A47C2C6EBD5D99040D804F Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 5/14/21 5:23 PM, Simon Marchi wrote: > > > On 2021-05-14 11:03 a.m., Bernd Edlinger wrote: >> On 5/14/21 3:26 PM, Simon Marchi wrote: >>> On 2021-05-14 9:20 a.m., Bernd Edlinger wrote: >>>> Hi, >>>> >>>> I'd like to cleanup some files/directories which >>>> remain after the gdb testsute runs. >>>> >>>> I want to avoid using "rm -rf ..." since that can be dangerous. >>>> Therefore I remove the *.gdb-index files, if any, and use >>>> rmdir instead. I am not sure if there is a better way, >>>> instead of using "remote_exec host sh -c" to do the globbing. >>>> >>>> Tested on x86_64-pc-linux-gnu. >>>> Is it OK for trunk? >>>> >>>> >>>> gdb/testsuite: >>>> 2021-05-14 Bernd Edlinger >>>> >>>> * gdb.base/index-cache.exp: Cleanup $cache_dir/*.gdb-index and >>>> remove the directory. >>>> * gdb.dwarf2/per-bfd-sharing.exp: Likewise. >>>> >>> >>> LGTM, but I have one question: if the rm or rmdir ever fails (because >>> there are additional files to delete, for example), would we know about >>> it or would it silently fail? I think it would be nice if the error >>> was noisy so we could fix it. >>> >> >> Ah Yes, good point, that would be as silent as before. >> >> So, how about this new version? > > LGTM, but while at it let's check the return value of both commands. > Yeah Okay. I think then I should also remove the -f switch from the rm command, so it has something to complain about when there is nothing to there to delete, since there should always be one index file at the end of the tests which have just completed. So like this? Thanks Bernd. --------------55A47C2C6EBD5D99040D804F Content-Type: text/x-patch; name="0001-testsuite-Cleanup-some-temp-dirs-with-gdb-index-file.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-testsuite-Cleanup-some-temp-dirs-with-gdb-index-file.pa"; filename*1="tch" RnJvbSA3MzAxNjYyZWY5NzMzNmYyZWIzMzNlODFjNzFkMjE4MWIyZGQ5NTNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBFZGxpbmdlciA8YmVybmQuZWRsaW5nZXJAaG90bWFp bC5kZT4KRGF0ZTogRnJpLCAxNCBNYXkgMjAyMSAxNDo1MzoxOSArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIHRlc3RzdWl0ZTogQ2xlYW51cCBzb21lIHRlbXAgZGlycyB3aXRoIGdkYi1pbmRleCBmaWxl cwoKQWZ0ZXIgdGhlIGdkYiB0ZXN0LXN1aXRlIHJ1bnMgdGhlcmUgYXJlIHNvbWUgZmlsZXMKbGVm dCBpbiAvdG1wL3RtcCovKi5nZGItaW5kZXgsIHJlbW92ZSB0aG9zZSBmaWxlcwphbmQgdGhlIGRp cmVjdG9yeSBhdCB0aGUgZW5kIG9mIHRoZSB0ZXN0IGNhc2UuCgpnZGIvdGVzdHN1aXRlOgoyMDIx LTA1LTE0ICBCZXJuZCBFZGxpbmdlciAgPGJlcm5kLmVkbGluZ2VyQGhvdG1haWwuZGU+CgoJKiBn ZGIuYmFzZS9pbmRleC1jYWNoZS5leHA6IENsZWFudXAgJGNhY2hlX2Rpci8qLmdkYi1pbmRleCBh bmQKCXJlbW92ZSB0aGUgZGlyZWN0b3J5LgoJKiBnZGIuZHdhcmYyL3Blci1iZmQtc2hhcmluZy5l eHA6IExpa2V3aXNlLgotLS0KIGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW5kZXgtY2FjaGUuZXhw ICAgICAgIHwgMTEgKysrKysrKysrKysKIGdkYi90ZXN0c3VpdGUvZ2RiLmR3YXJmMi9wZXItYmZk LXNoYXJpbmcuZXhwIHwgMTIgKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2luZGV4LWNhY2hl LmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW5kZXgtY2FjaGUuZXhwCmluZGV4IDEzZDU1 MzIuLjBkYWY3YmIgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW5kZXgtY2Fj aGUuZXhwCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW5kZXgtY2FjaGUuZXhwCkBAIC0y MjYsMyArMjI2LDE0IEBAIHRlc3RfY2FjaGVfZW5hYmxlZF9oaXQgJGNhY2hlX2RpcgogIyBUZXN0 IGFnYWluIHdpdGggdGhlIGNhY2hlIGRpc2FibGVkLCBub3cgdGhhdCBpdCBpcyBwb3B1bGF0ZWQu CiB0ZXN0X2NhY2hlX2Rpc2FibGVkICRjYWNoZV9kaXIgImFmdGVyIHBvcHVsYXRlIgogCitsYXNz aWduIFtyZW1vdGVfZXhlYyBob3N0IHNoICItYyBcInJtICRjYWNoZV9kaXIvKi5nZGItaW5kZXhc IiJdIHJldAoraWYgeyAkcmV0ICE9IDAgfSB7CisgICAgZmFpbCAiY291bGRuJ3QgcmVtb3ZlIGZp bGVzIGluIHRlbXBvcmFyeSBjYWNoZSBkaXIiCisgICAgcmV0dXJuCit9CisKK2xhc3NpZ24gW3Jl bW90ZV9leGVjIGhvc3Qgcm1kaXIgIiRjYWNoZV9kaXIiXSByZXQKK2lmIHsgJHJldCAhPSAwIH0g eworICAgIGZhaWwgImNvdWxkbid0IHJlbW92ZSB0ZW1wb3JhcnkgY2FjaGUgZGlyIgorICAgIHJl dHVybgorfQpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuZHdhcmYyL3Blci1iZmQtc2hh cmluZy5leHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5kd2FyZjIvcGVyLWJmZC1zaGFyaW5nLmV4cApp bmRleCAyMmFiOTFmLi4wODEwODhhIDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5kd2Fy ZjIvcGVyLWJmZC1zaGFyaW5nLmV4cAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5kd2FyZjIvcGVy LWJmZC1zaGFyaW5nLmV4cApAQCAtOTEsMyArOTEsMTUgQEAgZm9yZWFjaF93aXRoX3ByZWZpeCBm aXJzdCAkbWV0aG9kcyB7CiAJfQogICAgIH0KIH0KKworbGFzc2lnbiBbcmVtb3RlX2V4ZWMgaG9z dCBzaCAiLWMgXCJybSAkY2FjaGVfZGlyLyouZ2RiLWluZGV4XCIiXSByZXQKK2lmIHsgJHJldCAh PSAwIH0geworICAgIGZhaWwgImNvdWxkbid0IHJlbW92ZSBmaWxlcyBpbiB0ZW1wb3JhcnkgY2Fj aGUgZGlyIgorICAgIHJldHVybgorfQorCitsYXNzaWduIFtyZW1vdGVfZXhlYyBob3N0IHJtZGly ICIkY2FjaGVfZGlyIl0gcmV0CitpZiB7ICRyZXQgIT0gMCB9IHsKKyAgICBmYWlsICJjb3VsZG4n dCByZW1vdmUgdGVtcG9yYXJ5IGNhY2hlIGRpciIKKyAgICByZXR1cm4KK30KLS0gCjEuOS4xCgo= --------------55A47C2C6EBD5D99040D804F--