From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YMZ0DDWRnmAWHwAAWB0awg (envelope-from ) for ; Fri, 14 May 2021 11:03:17 -0400 Received: by simark.ca (Postfix, from userid 112) id 250D31F11C; Fri, 14 May 2021 11:03:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=1.0 required=5.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 988001E783 for ; Fri, 14 May 2021 11:03:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 58BEB394B01E; Fri, 14 May 2021 15:03:16 +0000 (GMT) Received: from EUR06-VI1-obe.outbound.protection.outlook.com (mail-vi1eur06olkn2087.outbound.protection.outlook.com [40.92.17.87]) by sourceware.org (Postfix) with ESMTPS id 90F6F3949F32 for ; Fri, 14 May 2021 15:03:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 90F6F3949F32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dZa6y7/WDj+zLe5FgrQUuxAXwlivcqFiAFORyoThYqr+Z840+K+4ibvDnZx9TV1NeJ/BVv1GouxVrVwSWHSNlXVo0Z+bZyIPr+Vt1BePsPNIAY7gJfSPmaKvvw/3swSnvx2ELfbj4Jn+3AKYUI80HMQ81NIGY3ozebsTo9hUIZ2vJXdktlJ8BG18CAsPOkGlvzbWJsKKevalK5lKgmwnMFYH/IX81GEbvkkJqi2itl4YUNlzJtniTvBsaSve4Ij0vgtfDY+Y/Dp+7FecSD3LBYb8FIzy5/l6cDsMhAeKxCKJdpXgLQnsC3oW7L5cbW3YO6AlcHro9JKC3IG8BQKDYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TU5H5UWlbDbYv9OeYOmwknXlr+WKyCkQmVhTzwO0JG4=; b=M7BP50GDaYgrboAGFs4Pl/200lAUcoQiw0OLQ8ZS2oR/vHKlBC8oM4ouhFWmTG5ILrATVZ/1/Yv2t4QgxYMI7PuUpX2KJSOpSOR+k5HoYTffT1/47YgzE6D37GkolpgZQ4lnwJzfUbBqBrbLiGACeZ8cpCehSvkgUhc7QmY6Dp6y31yuzjmvdF5XqJKN9Bjzt2STqJadpt+7kCeh4Qp7F/cQo9KukE5FlijhTvV81v7pWT4Q1FB+rp7YawgH1TJZObanCOMtHCmGZCUNd9KA6ltGz1g/NiGXxj5FClk5eJ7rnerg5ICjEosRKcPSdXOOB/iXZLihjxKtnAkRnHp9CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM7EUR06FT034.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::43) by AM7EUR06HT206.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Fri, 14 May 2021 15:03:11 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:fc36::53) by AM7EUR06FT034.mail.protection.outlook.com (2a01:111:e400:fc36::158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Fri, 14 May 2021 15:03:11 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:ACE8CB01F0A6A48FB677A3C1CCC9CAD499928981A5F2BB64E6D0D9D50D0DCBDF; UpperCasedChecksum:4707D9EBE039ADAE5523D6192D3FB4654C0399B0F85A4372D233D06291D6CE59; SizeAsReceived:7930; Count:46 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::e41b:107f:af82:150a]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::e41b:107f:af82:150a%7]) with mapi id 15.20.4129.026; Fri, 14 May 2021 15:03:11 +0000 Subject: Re: [PP?] [PATCH] testsuite: Cleanup some temp dirs with gdb-index files To: Simon Marchi , "gdb-patches@sourceware.org" References: <41e8702a-b0cb-57dd-efa2-4e059ec7c9d1@polymtl.ca> From: Bernd Edlinger Message-ID: Date: Fri, 14 May 2021 17:03:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <41e8702a-b0cb-57dd-efa2-4e059ec7c9d1@polymtl.ca> Content-Type: multipart/mixed; boundary="------------566E4CD2D1DB1F42BC9138C6" Content-Language: en-US X-TMN: [z8ZWNsOF+GoDfBHnEa7mvazmhQfUQoVv] X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (84.57.61.94) by FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Fri, 14 May 2021 15:03:10 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: b1f12e47-72b9-411b-6b25-08d916e963d9 X-MS-TrafficTypeDiagnostic: AM7EUR06HT206: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pjnXqrnpQ4g4Zyl0lPGnqLcMR/0pNUGzh1PDm6+8uq8hfdP/zlEN1xE78Df6dxCuoyo6jcRJjpqu4DEVOBNUzN+hcqWHLeCZOLYCHlVKpqz44h+c+u7jeP+wg9QFBO5+TVdKC87eALyBLlXguPSPPX1hLJIdtjVRiPbW2mv/0xKD9ZleTLbS4RjiDjz3xYMIj4jrmJBj0FK3vIzYPjPmwgcU478qtx+gzmZypgTZa7jTNcUi8N8LhLQiCnZKAz0ZDP6AC0cH3vKwEhALkrxns/uRhSQwcCPdIjjIu6cO4bVYipJXQiZlD3czUSoLYbyjXMZbC6wVKk60mO17gyaRxKqVDOIJV6rvJ38y/ZEfEWsOmFK5SzqZe8tHeyfgNPz57roBwGto3xFO47nKlwYHvA== X-MS-Exchange-AntiSpam-MessageData: ZDlZXS+wUsLEHOQVevI35VKMagh132NWNVP2lu7dInZM17cHfl9qMS1m1sJV6++9qPAboFA7CJ2D+E3jo8cajI7jq2zyNSl+55oyAam3lE0LSZdctyGGb5pFw3i18Z5CNCMxWxOo3zKUGrX5qRPOSw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1f12e47-72b9-411b-6b25-08d916e963d9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2021 15:03:11.0728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: AM7EUR06FT034.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7EUR06HT206 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --------------566E4CD2D1DB1F42BC9138C6 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 5/14/21 3:26 PM, Simon Marchi wrote: > On 2021-05-14 9:20 a.m., Bernd Edlinger wrote: >> Hi, >> >> I'd like to cleanup some files/directories which >> remain after the gdb testsute runs. >> >> I want to avoid using "rm -rf ..." since that can be dangerous. >> Therefore I remove the *.gdb-index files, if any, and use >> rmdir instead. I am not sure if there is a better way, >> instead of using "remote_exec host sh -c" to do the globbing. >> >> Tested on x86_64-pc-linux-gnu. >> Is it OK for trunk? >> >> >> gdb/testsuite: >> 2021-05-14 Bernd Edlinger >> >> * gdb.base/index-cache.exp: Cleanup $cache_dir/*.gdb-index and >> remove the directory. >> * gdb.dwarf2/per-bfd-sharing.exp: Likewise. >> > > LGTM, but I have one question: if the rm or rmdir ever fails (because > there are additional files to delete, for example), would we know about > it or would it silently fail? I think it would be nice if the error > was noisy so we could fix it. > Ah Yes, good point, that would be as silent as before. So, how about this new version? Thanks Bernd. --------------566E4CD2D1DB1F42BC9138C6 Content-Type: text/x-patch; name="0001-testsuite-Cleanup-some-temp-dirs-with-gdb-index-file.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-testsuite-Cleanup-some-temp-dirs-with-gdb-index-file.pa"; filename*1="tch" RnJvbSAwNDU2OWVkMWZmMGYyZWUwOTM1MmYzYWFlZTdjZTUxNzc2NmIyYWVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBFZGxpbmdlciA8YmVybmQuZWRsaW5nZXJAaG90bWFp bC5kZT4KRGF0ZTogRnJpLCAxNCBNYXkgMjAyMSAxNDo1MzoxOSArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIHRlc3RzdWl0ZTogQ2xlYW51cCBzb21lIHRlbXAgZGlycyB3aXRoIGdkYi1pbmRleCBmaWxl cwoKQWZ0ZXIgdGhlIGdkYiB0ZXN0LXN1aXRlIHJ1bnMgdGhlcmUgYXJlIHNvbWUgZmlsZXMKbGVm dCBpbiAvdG1wL3RtcCovKi5nZGItaW5kZXgsIHJlbW92ZSB0aG9zZSBmaWxlcwphbmQgdGhlIGRp cmVjdG9yeSBhdCB0aGUgZW5kIG9mIHRoZSB0ZXN0IGNhc2UuCgpnZGIvdGVzdHN1aXRlOgoyMDIx LTA1LTE0ICBCZXJuZCBFZGxpbmdlciAgPGJlcm5kLmVkbGluZ2VyQGhvdG1haWwuZGU+CgoJKiBn ZGIuYmFzZS9pbmRleC1jYWNoZS5leHA6IENsZWFudXAgJGNhY2hlX2Rpci8qLmdkYi1pbmRleCBh bmQKCXJlbW92ZSB0aGUgZGlyZWN0b3J5LgoJKiBnZGIuZHdhcmYyL3Blci1iZmQtc2hhcmluZy5l eHA6IExpa2V3aXNlLgotLS0KIGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW5kZXgtY2FjaGUuZXhw ICAgICAgIHwgNiArKysrKysKIGdkYi90ZXN0c3VpdGUvZ2RiLmR3YXJmMi9wZXItYmZkLXNoYXJp bmcuZXhwIHwgNyArKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKykKCmRp ZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2luZGV4LWNhY2hlLmV4cCBiL2dkYi90 ZXN0c3VpdGUvZ2RiLmJhc2UvaW5kZXgtY2FjaGUuZXhwCmluZGV4IDEzZDU1MzIuLmRlNTgxZjcg MTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW5kZXgtY2FjaGUuZXhwCisrKyBi L2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW5kZXgtY2FjaGUuZXhwCkBAIC0yMjYsMyArMjI2LDkg QEAgdGVzdF9jYWNoZV9lbmFibGVkX2hpdCAkY2FjaGVfZGlyCiAjIFRlc3QgYWdhaW4gd2l0aCB0 aGUgY2FjaGUgZGlzYWJsZWQsIG5vdyB0aGF0IGl0IGlzIHBvcHVsYXRlZC4KIHRlc3RfY2FjaGVf ZGlzYWJsZWQgJGNhY2hlX2RpciAiYWZ0ZXIgcG9wdWxhdGUiCiAKK3JlbW90ZV9leGVjIGhvc3Qg c2ggIi1jIFwicm0gLWYgJGNhY2hlX2Rpci8qLmdkYi1pbmRleFwiIgorbGFzc2lnbiBbcmVtb3Rl X2V4ZWMgaG9zdCBybWRpciAiJGNhY2hlX2RpciJdIHJldAoraWYgeyAkcmV0ICE9IDAgfSB7Cisg ICAgZmFpbCAiY291bGRuJ3QgcmVtb3ZlIHRlbXBvcmFyeSBjYWNoZSBkaXIiCisgICAgcmV0dXJu Cit9CmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5kd2FyZjIvcGVyLWJmZC1zaGFyaW5n LmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmR3YXJmMi9wZXItYmZkLXNoYXJpbmcuZXhwCmluZGV4 IDIyYWI5MWYuLjM3MTc4MjUgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLmR3YXJmMi9w ZXItYmZkLXNoYXJpbmcuZXhwCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmR3YXJmMi9wZXItYmZk LXNoYXJpbmcuZXhwCkBAIC05MSwzICs5MSwxMCBAQCBmb3JlYWNoX3dpdGhfcHJlZml4IGZpcnN0 ICRtZXRob2RzIHsKIAl9CiAgICAgfQogfQorCityZW1vdGVfZXhlYyBob3N0IHNoICItYyBcInJt IC1mICRjYWNoZV9kaXIvKi5nZGItaW5kZXhcIiIKK2xhc3NpZ24gW3JlbW90ZV9leGVjIGhvc3Qg cm1kaXIgIiRjYWNoZV9kaXIiXSByZXQKK2lmIHsgJHJldCAhPSAwIH0geworICAgIGZhaWwgImNv dWxkbid0IHJlbW92ZSB0ZW1wb3JhcnkgY2FjaGUgZGlyIgorICAgIHJldHVybgorfQotLSAKMS45 LjEKCg== --------------566E4CD2D1DB1F42BC9138C6--