From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2OxnCjoy0GBjMgAAWB0awg (envelope-from ) for ; Mon, 21 Jun 2021 02:31:22 -0400 Received: by simark.ca (Postfix, from userid 112) id 274001F1F2; Mon, 21 Jun 2021 02:31:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CDDB31E54D for ; Mon, 21 Jun 2021 02:31:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3158E388187E for ; Mon, 21 Jun 2021 06:31:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3158E388187E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624257081; bh=BknyOlq3W3rBNbXi/JUGAi0If6hRMy7muepyT99zDUY=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ujhNgeZsraIaw4ssJ66eCdILL3GcIjaYgEYAUIJ8mSpdaBS+fjahwJ/EE8BTw/ZjK 39o8csSYz1Rg4IoNg3wi+prZWMyLJR0Sut7sp0AyGIriKFAfvg5R/L9znP+u2WFQQc Sr3ronDkRYzYxpF/tnS87OBNlqG8Dja9w1hwUs88= Received: from mx08-00271601.pphosted.com (mx08-00271601.pphosted.com [185.132.182.208]) by sourceware.org (Postfix) with ESMTPS id D16CB3835801 for ; Mon, 21 Jun 2021 06:31:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D16CB3835801 Received: from pps.filterd (m0107398.ppops.net [127.0.0.1]) by mx08-00271601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15L6U8et002984; Mon, 21 Jun 2021 08:30:51 +0200 Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by mx08-00271601.pphosted.com with ESMTP id 3996jdnx1f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Jun 2021 08:30:51 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2sAc5K29qCoNV7RL5SX6jxWDK2qDfDmIcNmBeWFhUzfVvSXFYZefG0KJVQ9C2jyQG7NkOs0SoCemcWdy65kfvOJTbbhFuE56zVyculVM4qE3Qd9DjwT7aSjkznQbIXWfZYF6Rr+KUTJ6RcZM9L/V7bHDNnPM9H6vkxt1pDhVmdPymcyVlLPq1vXSSKlOPB2ZwBTANKkwEy81y9gPiXU6KHSreECYKfxZpqRIJm4XgWUL6QrfhFRfTR6Zibn1zdVbIIn309LjxBrBk35xQU7y6L4QzBFwqgRznUZnxCwlp31qyomlrWEE5euAyIFZolN6yvTR4/t8OP2rXGoNo5wEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BknyOlq3W3rBNbXi/JUGAi0If6hRMy7muepyT99zDUY=; b=KmXJeBWqh9xwN236QuUlLuvkpIulDRJGEPIwibHZ7qLzZ7vb/nQxwX0iFG6m7fM2K4i9gP3rVWsy8Qs3+6aUZTrcbg9ndbILXtPKtwDr2bgMR+6q96tEoEYuzkTmI3PjiJ1JqNCvA+Er+0QnLWHUVlkDclviQ67dgvqI3LvfubcHJ9HYstGnAsMwfSxNeogG4aITpf/5swuKT1Hyv8fjSPGNDoq38PIRA+fZ21h94/dtscGJJVsA6HjK9ErxPd/utOh2WYae8bGrJf4hWFphVtMblpE1hyYCpIW31tggB7sohGzltRU3mfJU0k4p24H9zg1TDCiLJQhfshmzyyKIlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=verisure.com; dmarc=pass action=none header.from=verisure.com; dkim=pass header.d=verisure.com; arc=none Received: from AM8PR10MB4658.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:357::9) by AM8PR10MB4627.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:365::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15; Mon, 21 Jun 2021 06:30:49 +0000 Received: from AM8PR10MB4658.EURPRD10.PROD.OUTLOOK.COM ([fe80::311b:7ee9:83a6:bf6c]) by AM8PR10MB4658.EURPRD10.PROD.OUTLOOK.COM ([fe80::311b:7ee9:83a6:bf6c%6]) with mapi id 15.20.4242.023; Mon, 21 Jun 2021 06:30:49 +0000 To: Luis Machado , Andrew Burgess Subject: [PATCH] sim: arm: add support for handling core dumps Thread-Topic: [PATCH] sim: arm: add support for handling core dumps Thread-Index: AQHXZmb5gmbcrCVdO0K/IHyrHhdMwg== Date: Mon, 21 Jun 2021 06:30:49 +0000 Message-ID: References: <20210118110922.GT265215@embecosm.com>, <0327e6b6-2a4e-cf4f-333c-5f3cde18c49c@linaro.org> In-Reply-To: <0327e6b6-2a4e-cf4f-333c-5f3cde18c49c@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [62.13.16.210] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd84e185-da0e-44d4-4d45-08d9347e1c31 x-ms-traffictypediagnostic: AM8PR10MB4627: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qSBHk07ItSRApfFy14Y2d4TBEz4oCIxmki+WZvs2Q4APOM855WiAmxAlhYl5jso/82GfOEl90o5XD2MB79tW14a6Kmk8NBLHnUmNQnvuzKn0B1bmrXBAAToOx/BdsIPfxwbVoM3WFFn7ZYtAQ05pm30eVFMz7jN9zT6a4pD5XysgvGJISD6k1aJNjZCQSCO8+jdQkcyXRjPI3qB1Z8AiTEMGSrWfgFeA9JoN4VtUk9trC6y9PmJ3cGO+0S51XURvVzadpzJB77VBL+MomWuCEnafLlS33Dob7HcRBBP6hMwpZuBylV1x7HkNRtrlT57zw6vczzOYMd4p+ePgTzXNbqomTrVVWlsAZMy+zIV94ZKBhZoRE+CQw4bQFMHQNcmeJ7B2AP5up2i+htLXSjHYE953bLUWKZXGO6Mq/021pYKBtLtIEI8D8JTBrbDvyo5FkdpVFG/gu5bOxKzSmLiBGFmJmhWOyWv2l1SPgUSuAHcmxH3Awfl8iR6a9KUFL/03h9XdxxEQIw5aZOfr0m7iAyPv0EDkwhlk8RnmgpXcTfGInpSNoITnjzQ2ETgzEXsZ7cANXq3ewKWyaUUvwLHE/zybhmzNqkh1bqhx1iOOnVU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR10MB4658.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(39850400004)(366004)(136003)(66476007)(66556008)(26005)(33656002)(4326008)(66446008)(64756008)(6506007)(66946007)(52536014)(5660300002)(8936002)(2906002)(122000001)(8676002)(76116006)(71200400001)(91956017)(55016002)(186003)(9686003)(38100700002)(316002)(7696005)(86362001)(44832011)(54906003)(110136005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?5tgo9qEN6nEfeUBnZjouaIKNmDRy+GDHhxO+t6BBGfwjKuD8LLzYGlSlVW?= =?iso-8859-1?Q?HMTRCN1U9qls9TEDXE1LDeSux/owimKXqiZUgQCkt5HgjcE0bTlP8l6Ure?= =?iso-8859-1?Q?dqwd0G9NHLrF98bvt1AwRp+pXpuYYhbiSO/s+/x2gEK3pgiTPHUPeSxr/M?= =?iso-8859-1?Q?Hi2H4wJczHdfR547dU29l9w0aEDI8ZNtHILwqtWGuu4cX32FeFM11rrghF?= =?iso-8859-1?Q?f67AU8ueYpb1q91j9aeZTEKtgmbJvUwSqzJltJ+NrNQpFqHEmuYgLDj56j?= =?iso-8859-1?Q?XjDVVgXs6+JkO6RAHrDI97Pqro+qVPHK3V96w0Opv7yQeC0RWiezd/HpEH?= =?iso-8859-1?Q?vGYNqtoE8AmpX6BWhjVh3JqdqKhhubsoRH1RusRk7S/28xu12feghipf8O?= =?iso-8859-1?Q?epVC5Hzu/wteH8TGbzsOT1oohcBtsIL5Kf8ZLlcUUmdoei8nGgAZze1kZi?= =?iso-8859-1?Q?H3HNs0YuqYrsnhGRImJfJQzPx2WYLEai3cmKQiV8fbdK3sfQnm5f5rLfjR?= =?iso-8859-1?Q?h+/f4em544chJabFmAUMInR8tHpbeQhnO2YxdshVDII59XG9XR/hN9QOaP?= =?iso-8859-1?Q?iiy1ZYAtd1YJINfoSUAnY4//NcKjE94H4pYpVNqNKvZA3uxEJ+PeM2EAdG?= =?iso-8859-1?Q?E1orQIsMJdkkEppyAb09H3EGuyFQdFr8iRBaFsWVtOyoFNmG+gKQpmy/i8?= =?iso-8859-1?Q?/hZKF5B94YEAfsGHz5IwD3STFoofivIFdPDEGcQ7TnsKS5cuWcQ7TILOvS?= =?iso-8859-1?Q?Kpb9BXYfU4e0kcnpIlbGbpsYnSPKhd8OSQicH+RxgiOycEGJvTca9q0oeG?= =?iso-8859-1?Q?uzxZoTVtKsndih8g3ea+wVYmHghIWzmcKHfRs9nizCe7/OECePqyGRJNI1?= =?iso-8859-1?Q?Tqgi/AZMjx8Et04nkswXt449WuhbfbTJxyeXJbaXBRzTEzP7QxyprT9Uj4?= =?iso-8859-1?Q?obUgvGN6xi5v8LRjTOYfLwfCTZRFDSjToue9Hq/C9A22Yx3R+b1JMq6R1Z?= =?iso-8859-1?Q?xAU5RjgU1ooIDntMb9DgUPMu67wJPOpubxbyrHsJ92ljLxjbRQ9JPIaQvP?= =?iso-8859-1?Q?MFKw+uSisNU71su+4lFAqTzGGZcswx7oDv/0wc+a9RZwNNhnKhTC2dAo1g?= =?iso-8859-1?Q?jpdSCJ3nqkRgs85RnDCHRjzUeGvRHl7xFbkY0s2sBlJ8x25jMUREgnfuxW?= =?iso-8859-1?Q?d6siqBmCCCf3hKIzjThtxSNp7/z773QgKhftjueucnwVv4FkNU3YuBAitj?= =?iso-8859-1?Q?n+lC4C+26ewk2S/tT5STZ0tIgdmfG7xpGXUSEuctjMhYALy4nV3FOp1ZxX?= =?iso-8859-1?Q?ny1cWodkqcXfV3wDC6+bd90zEzrAzPhivVKUMwYjehqt1SU=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: verisure.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR10MB4658.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: fd84e185-da0e-44d4-4d45-08d9347e1c31 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2021 06:30:49.2590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3055fa7f-a944-4927-801e-a62b63119e43 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XDhPrnYcl9kRvSyXUQXnv/5qIifzwMkw0Qzo3X0YjDQp59QK9Fcds/pPC9cEshR/0xF4gEsLmN0dmoq37hoTyEiN/kP81IkvpcCv7wtSzSiti/bBWfrZ65/PXPa16zaX X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB4627 X-Proofpoint-GUID: qCszFrO51vovg5Hx_1TzJg_pXcLuQxTO X-Proofpoint-ORIG-GUID: qCszFrO51vovg5Hx_1TzJg_pXcLuQxTO X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-06-21_02:2021-06-20, 2021-06-21 signatures=0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Fredrik Hederstierna via Gdb-patches Reply-To: Fredrik Hederstierna Cc: Simon Marchi , "gdb-patches@sourceware.org" , Paul Mathieu Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" The ARM simulator does not support all registers, and also crash in case of= entering zero length when fetching registers.=0A= This patch allow gcore to also work in ARM simulator, though by default it = seems to dump full memory space 4GB, so core files get very large, though s= eems to work ok anyhow.=0A= =0A= BR Fredrik=0A= =0A= =0A= diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c=0A= index 857a52a9a51..2820e456cf7 100644=0A= --- a/gdb/arm-tdep.c=0A= +++ b/gdb/arm-tdep.c=0A= @@ -4246,6 +4246,10 @@ arm_register_sim_regno (struct gdbarch *gdbarch, int= regnum)=0A= if (regnum >=3D ARM_WCGR0_REGNUM && regnum <=3D ARM_WCGR7_REGNUM)=0A= return regnum - ARM_WCGR0_REGNUM + SIM_ARM_IWMMXT_COP1R8_REGNUM;=0A= =0A= + /* The current GDB ARM simulator does not support D0-D31 nor FPSCR. */= =0A= + if (regnum >=3D ARM_D0_REGNUM && regnum <=3D ARM_FPSCR_REGNUM)=0A= + return -1;=0A= +=0A= if (reg < NUM_GREGS)=0A= return SIM_ARM_R0_REGNUM + reg;=0A= reg -=3D NUM_GREGS;=0A= diff --git a/sim/arm/wrapper.c b/sim/arm/wrapper.c=0A= index e697d55a6b5..2a8a539b939 100644=0A= --- a/sim/arm/wrapper.c=0A= +++ b/sim/arm/wrapper.c=0A= @@ -526,6 +526,10 @@ arm_reg_fetch (SIM_CPU *cpu, int rn, unsigned char *me= mory, int length)=0A= =0A= init ();=0A= =0A= + /* Check that memory and length are valid before fetching the register. = */=0A= + if ((memory =3D=3D NULL) || (length =3D=3D 0))=0A= + return 0;=0A= +=0A= switch ((enum sim_arm_regs) rn)=0A= {=0A= case SIM_ARM_R0_REGNUM:=0A= =0A=