> > Two minor, but important, nits to fix: > > Missing 2x Changelogs. > ... > > Missing copyright file header. > > Apologies, the ChangeLog is below, and I've added the copyright header that has gone in aarch64-disp-stepping.s inline so you can check it easily. The patch (created from `git format-patch`) is attached. I don't have commit rights to GDB, so if this is OK could you apply the patch? Thanks, Matthew ChangeLogs to apply: ------ gdb/ChangeLog: 2020-07-23 Matthew Malcomson * aarch64-tdep.c (aarch64_displaced_step_others): Account for BLR and BR instructions. * arch/aarch64-insn.h (enum aarch64_opcodes): Add BR opcode. (enum aarch64_masks): New. gdb/testsuite/ChangeLog: 2020-07-23 Matthew Malcomson * gdb.arch/aarch64-disp-stepping.exp: New test runner. * gdb.arch/aarch64-disp-stepping.s: New test. ------- Additional Copyright header added to aarch64-disp-stepping.s: diff --git a/gdb/testsuite/gdb.arch/aarch64-disp-stepping.s b/gdb/testsuite/gdb.arch/aarch64-disp-stepping.s new file mode 100644 index 0000000000000000000000000000000000000000..c7a67a12f250abee4250a1edfca411f25bc3a113 --- /dev/null +++ b/gdb/testsuite/gdb.arch/aarch64-disp-stepping.s @@ -0,0 +1,111 @@ +/* Copyright 2020 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . + + This file is part of the gdb testsuite. + + Test displaced stepping over AArch64 instructions. */ +